From: Michal Hocko <mhocko@suse.com>
To: kbuild test robot <fengguang.wu@intel.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: kbuild-all@01.org, Johannes Weiner <hannes@cmpxchg.org>,
Zi Yan <zi.yan@cs.rutgers.edu>,
Linux Memory Management List <linux-mm@kvack.org>
Subject: Re: [mmotm:master 149/256] mm/memory-failure.c:1587:33: error: passing argument 2 of 'migrate_pages' from incompatible pointer type
Date: Fri, 5 Jan 2018 09:52:59 +0100 [thread overview]
Message-ID: <20180105085259.GH2801@dhcp22.suse.cz> (raw)
In-Reply-To: <201801051033.yyDREhgU%fengguang.wu@intel.com>
Hi,
On Fri 05-01-18 10:51:40, Wu Fengguang wrote:
> tree: git://git.cmpxchg.org/linux-mmotm.git master
> head: 1ceb98996d2504dd4e0bcb5f4cb9009a18cd8aaa
> commit: c714f7da3636f838c8ed46c7c477525c2ea98a0f [149/256] mm, migrate: remove reason argument from new_page_t
> config: i386-randconfig-i1-201800 (attached as .config)
> compiler: gcc-7 (Debian 7.2.0-12) 7.2.1 20171025
> reproduce:
> git checkout c714f7da3636f838c8ed46c7c477525c2ea98a0f
> # save the attached .config to linux build tree
> make ARCH=i386
>
> All errors (new ones prefixed by >>):
>
> mm/memory-failure.c: In function 'soft_offline_huge_page':
> >> mm/memory-failure.c:1587:33: error: passing argument 2 of 'migrate_pages' from incompatible pointer type [-Werror=incompatible-pointer-types]
> ret = migrate_pages(&pagelist, new_page, NULL, MPOL_MF_MOVE_ALL,
> ^~~~~~~~
> In file included from mm/memory-failure.c:51:0:
> include/linux/migrate.h:68:12: note: expected 'struct page * (*)(struct page *, long unsigned int)' but argument is of type 'struct page * (*)(struct page *, long unsigned int, int **)'
> extern int migrate_pages(struct list_head *l, new_page_t new, free_page_t free,
> ^~~~~~~~~~~~~
> mm/memory-failure.c: In function '__soft_offline_page':
> mm/memory-failure.c:1665:34: error: passing argument 2 of 'migrate_pages' from incompatible pointer type [-Werror=incompatible-pointer-types]
> ret = migrate_pages(&pagelist, new_page, NULL, MPOL_MF_MOVE_ALL,
> ^~~~~~~~
> In file included from mm/memory-failure.c:51:0:
> include/linux/migrate.h:68:12: note: expected 'struct page * (*)(struct page *, long unsigned int)' but argument is of type 'struct page * (*)(struct page *, long unsigned int, int **)'
> extern int migrate_pages(struct list_head *l, new_page_t new, free_page_t free,
> ^~~~~~~~~~~~~
> cc1: some warnings being treated as errors
Sorry about missing this one. I am wondering none of my configs has
CONFIG_MEMORY_FAILURE enabled... I've fixed that. Anyway, the fix is
trivial. Andrew, could you fold it to mm-migrate-remove-reason-argument-from-new_page_t.patch
---
prev parent reply other threads:[~2018-01-05 8:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-05 2:51 [mmotm:master 149/256] mm/memory-failure.c:1587:33: error: passing argument 2 of 'migrate_pages' from incompatible pointer type kbuild test robot
2018-01-05 8:52 ` Michal Hocko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180105085259.GH2801@dhcp22.suse.cz \
--to=mhocko@suse.com \
--cc=akpm@linux-foundation.org \
--cc=fengguang.wu@intel.com \
--cc=hannes@cmpxchg.org \
--cc=kbuild-all@01.org \
--cc=linux-mm@kvack.org \
--cc=zi.yan@cs.rutgers.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).