Linux-mm Archive on lore.kernel.org
 help / color / Atom feed
From: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: "Kirill A. Shutemov" <kirill@shutemov.name>,
	Zi Yan <zi.yan@sent.com>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Vlastimil Babka <vbabka@suse.cz>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: [PATCH] mm: shmem: enable thp migration (Re: [PATCH v1] mm: consider non-anonymous thp as unmovable page)
Date: Fri, 6 Apr 2018 03:07:11 +0000
Message-ID: <20180406030706.GA2434@hori1.linux.bs1.fc.nec.co.jp> (raw)
In-Reply-To: <20180405160317.GP6312@dhcp22.suse.cz>

Hi everyone,

On Thu, Apr 05, 2018 at 06:03:17PM +0200, Michal Hocko wrote:
> On Thu 05-04-18 18:55:51, Kirill A. Shutemov wrote:
> > On Thu, Apr 05, 2018 at 05:05:47PM +0200, Michal Hocko wrote:
> > > On Thu 05-04-18 16:40:45, Kirill A. Shutemov wrote:
> > > > On Thu, Apr 05, 2018 at 02:48:30PM +0200, Michal Hocko wrote:
> > > [...]
> > > > > RIght, I confused the two. What is the proper layer to fix that then?
> > > > > rmap_walk_file?
> > > > 
> > > > Maybe something like this? Totally untested.
> > > 
> > > This looks way too complex. Why cannot we simply split THP page cache
> > > during migration?
> > 
> > This way we unify the codepath for archictures that don't support THP
> > migration and shmem THP.
> 
> But why? There shouldn't be really nothing to prevent THP (anon or
> shemem) to be migratable. If we cannot migrate it at once we can always
> split it. So why should we add another thp specific handling all over
> the place?

If thp migration works fine for shmem, we can keep anon/shmem thp to
be migratable and we don't need any ad-hoc workaround.
So I wrote a patch to enable it.
This patch does not change any shmem specific code, so I think that
it works for file thp (not only shmem,) but I don't test it yet.

Thanks,
Naoya Horiguchi
-----

  parent reply index

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-03  4:46 [PATCH v1] mm: consider non-anonymous thp as unmovable page Naoya Horiguchi
2018-04-03  7:59 ` Michal Hocko
2018-04-03  8:24   ` Naoya Horiguchi
2018-04-03  8:34     ` Michal Hocko
2018-04-03 10:54       ` Kirill A. Shutemov
2018-04-03 10:58         ` Michal Hocko
2018-04-03 11:16           ` Kirill A. Shutemov
2018-04-03 11:33             ` Michal Hocko
2018-04-05  8:59         ` Michal Hocko
2018-04-05 12:28           ` Kirill A. Shutemov
2018-04-05 12:48             ` Michal Hocko
2018-04-05 13:40               ` Kirill A. Shutemov
2018-04-05 15:05                 ` Michal Hocko
2018-04-05 15:55                   ` Kirill A. Shutemov
2018-04-05 16:03                     ` Michal Hocko
2018-04-05 17:58                       ` Zi Yan
2018-04-05 19:04                         ` Michal Hocko
2018-04-05 19:09                           ` Zi Yan
2018-04-06  3:07                       ` Naoya Horiguchi [this message]
2018-04-06  5:14                         ` [PATCH] mm: shmem: enable thp migration (Re: [PATCH v1] mm: consider non-anonymous thp as unmovable page) Naoya Horiguchi
2018-04-06  7:08                           ` Michal Hocko
2018-04-09  7:14                             ` Naoya Horiguchi
2018-04-10 11:16                         ` Kirill A. Shutemov
2018-04-11  9:26                         ` Michal Hocko
2018-04-11 19:27                           ` Andrew Morton
2018-04-11 19:43                             ` Michal Hocko
2018-04-23  3:03                         ` Matthew Wilcox
2018-04-23  7:21                           ` Naoya Horiguchi
2018-04-05 16:42 ` [PATCH v1] mm: consider non-anonymous thp as unmovable page Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180406030706.GA2434@hori1.linux.bs1.fc.nec.co.jp \
    --to=n-horiguchi@ah.jp.nec.com \
    --cc=akpm@linux-foundation.org \
    --cc=kirill@shutemov.name \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@kernel.org \
    --cc=vbabka@suse.cz \
    --cc=zi.yan@sent.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-mm Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-mm/0 linux-mm/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-mm linux-mm/ https://lore.kernel.org/linux-mm \
		linux-mm@kvack.org
	public-inbox-index linux-mm

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kvack.linux-mm


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git