From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <owner-linux-mm@kvack.org>
Received: from mail-wr0-f198.google.com (mail-wr0-f198.google.com [209.85.128.198])
	by kanga.kvack.org (Postfix) with ESMTP id 496706B05C1
	for <linux-mm@kvack.org>; Thu, 10 May 2018 02:37:33 -0400 (EDT)
Received: by mail-wr0-f198.google.com with SMTP id d4-v6so693988wrn.15
        for <linux-mm@kvack.org>; Wed, 09 May 2018 23:37:33 -0700 (PDT)
Received: from newverein.lst.de (verein.lst.de. [213.95.11.211])
        by mx.google.com with ESMTPS id n185-v6si279457wmb.29.2018.05.09.23.37.32
        for <linux-mm@kvack.org>
        (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
        Wed, 09 May 2018 23:37:32 -0700 (PDT)
Date: Thu, 10 May 2018 08:41:09 +0200
From: Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 06/33] mm: give the 'ret' variable a better name
	__do_page_cache_readahead
Message-ID: <20180510064109.GC11422@lst.de>
References: <20180509074830.16196-1-hch@lst.de> <20180509074830.16196-7-hch@lst.de> <20180509154501.GD1313@bombadil.infradead.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180509154501.GD1313@bombadil.infradead.org>
Sender: owner-linux-mm@kvack.org
List-ID: <linux-mm.kvack.org>
To: Matthew Wilcox <willy@infradead.org>
Cc: Christoph Hellwig <hch@lst.de>, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-mm@kvack.org

On Wed, May 09, 2018 at 08:45:01AM -0700, Matthew Wilcox wrote:
> On Wed, May 09, 2018 at 09:48:03AM +0200, Christoph Hellwig wrote:
> > It counts the number of pages acted on, so name it nr_pages to make that
> > obvious.
> > 
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
> 
> Yes!
> 
> Also, it can't return an error, so how about changing it to unsigned int?
> And deleting the error check from the caller?

I'll take a look at that.