From: Matthew Wilcox <willy@infradead.org>
To: Souptick Joarder <jrdr.linux@gmail.com>
Cc: akpm@linux-foundation.org, mhocko@suse.com, hughd@google.com,
dan.j.williams@intel.com, rientjes@google.com,
mike.kravetz@oracle.com, n-horiguchi@ah.jp.nec.com,
aneesh.kumar@linux.vnet.ibm.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mm: Change return type to vm_fault_t
Date: Fri, 11 May 2018 11:15:46 -0700 [thread overview]
Message-ID: <20180511181546.GA25613@bombadil.infradead.org> (raw)
In-Reply-To: <20180511180639.GA1792@jordon-HP-15-Notebook-PC>
On Fri, May 11, 2018 at 11:36:39PM +0530, Souptick Joarder wrote:
> mm/hugetlb.c | 2 +-
> mm/mmap.c | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
Don't we also need to convert include/linux/mm_types.h:
@@ -621,7 +621,7 @@ struct vm_special_mapping {
* If non-NULL, then this is called to resolve page faults
* on the special mapping. If used, .pages is not checked.
*/
- int (*fault)(const struct vm_special_mapping *sm,
+ vm_fault_t (*fault)(const struct vm_special_mapping *sm,
struct vm_area_struct *vma,
struct vm_fault *vmf);
or are you leaving that for a later patch?
next prev parent reply other threads:[~2018-05-11 18:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-11 18:06 [PATCH v2] mm: Change return type to vm_fault_t Souptick Joarder
2018-05-11 18:15 ` Matthew Wilcox [this message]
2018-05-11 18:26 ` Souptick Joarder
-- strict thread matches above, loose matches on Subject: below --
2018-03-10 16:23 Souptick Joarder
2018-03-19 14:43 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180511181546.GA25613@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=dan.j.williams@intel.com \
--cc=hughd@google.com \
--cc=jrdr.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=mike.kravetz@oracle.com \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).