From: Mel Gorman <mgorman@suse.de>
To: Christoph Hellwig <hch@lst.de>
Cc: Trond Myklebust <trondmy@hammerspace.com>,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
linux-nfs@vger.kernel.org
Subject: Re: do we still need ->is_dirty_writeback
Date: Mon, 21 May 2018 10:05:47 +0100 [thread overview]
Message-ID: <20180521090547.shpifu2sivrishas@suse.de> (raw)
In-Reply-To: <20180518170812.GA5190@lst.de>
On Fri, May 18, 2018 at 07:08:12PM +0200, Christoph Hellwig wrote:
> Hi Mel,
>
> you added the is_dirty_writeback callback a couple years ago mostly
> to work around the crazy ext3 writeback code, which is long gone now.
> We still use buffer_check_dirty_writeback on the block device, but
> without that ext3 case we really should not need it anymore.
>
> That leaves NFS, where I don't understand why it doesn't simply
> use PageWrite?
If you mean PageWriteback the patch was to treat some pages as if they were
under writeback even if the page state didn't reflect that. The intent was
to catch the case when kswapd was scanning that it would not prematurely
skip over pages under writeback or were really dirty from being skipped and
clean pages being reclaimed instead. In an extreme case, it would avoid
a premature OOM if the number of clean pages that could be reclaimed was
too small. However, it was (is?) a corner case and the mechanisms that
control throttling have changed a lot since.
If the callback is problematic for some reason, I don't object to it
being removed. At worst, there will be rare cases where reclaim finds
clean pages and steals them prematurely. There are plenty of other cases
where page age inversion issues exist (e.g. NUMA machines that reclaim
young pages from local node when the working set is larger than a node)
and it's rare that people notice.
--
Mel Gorman
SUSE Labs
prev parent reply other threads:[~2018-05-21 9:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-18 17:08 do we still need ->is_dirty_writeback Christoph Hellwig
2018-05-21 9:05 ` Mel Gorman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180521090547.shpifu2sivrishas@suse.de \
--to=mgorman@suse.de \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nfs@vger.kernel.org \
--cc=trondmy@hammerspace.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).