From: Johannes Weiner <hannes@cmpxchg.org>
To: Vinayak Menon <vinmenon@codeaurora.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-block@vger.kernel.org, cgroups@vger.kernel.org,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Andrew Morton <akpm@linuxfoundation.org>,
Tejun Heo <tj@kernel.org>, Balbir Singh <bsingharora@gmail.com>,
Mike Galbraith <efault@gmx.de>, Oliver Yang <yangoliver@me.com>,
Shakeel Butt <shakeelb@google.com>, xxx xxx <x.qendo@gmail.com>,
Taras Kondratiuk <takondra@cisco.com>,
Daniel Walker <danielwa@cisco.com>,
Ruslan Ruslichenko <rruslich@cisco.com>,
kernel-team@fb.com
Subject: Re: [PATCH 6/7] psi: pressure stall information for CPU, memory, and IO
Date: Wed, 23 May 2018 09:17:47 -0400 [thread overview]
Message-ID: <20180523131747.GA4086@cmpxchg.org> (raw)
In-Reply-To: <87060553-2e09-2e2a-13a2-a91345d6df30@codeaurora.org>
On Wed, May 09, 2018 at 04:33:24PM +0530, Vinayak Menon wrote:
> On 5/8/2018 2:31 AM, Johannes Weiner wrote:
> > + /* Kick the stats aggregation worker if it's gone to sleep */
> > + if (!delayed_work_pending(&group->clock_work))
>
> This causes a crash when the work is scheduled before system_wq is up. In my case when the first
> schedule was called from kthreadd. And I had to do this to make it work.
> if (keventd_up() && !delayed_work_pending(&group->clock_work))
>
> > + schedule_delayed_work(&group->clock_work, MY_LOAD_FREQ);
I was trying to figure out how this is possible, and it didn't make
sense because we do initialize the system_wq way before kthreadd.
Did you by any chance backport this to a pre-4.10 kernel which does
not have 3347fa092821 ("workqueue: make workqueue available early
during boot") yet?
> > +void psi_task_change(struct task_struct *task, u64 now, int clear, int set)
> > +{
> > + struct cgroup *cgroup, *parent;
>
> unused variables
They're used in the next patch, I'll fix that up.
Thanks
next prev parent reply other threads:[~2018-05-23 13:15 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-07 21:01 [PATCH 0/7] psi: pressure stall information for CPU, memory, and IO Johannes Weiner
2018-05-07 21:01 ` [PATCH 1/7] mm: workingset: don't drop refault information prematurely Johannes Weiner
2018-05-07 21:01 ` [PATCH 2/7] mm: workingset: tell cache transitions from workingset thrashing Johannes Weiner
2018-05-07 21:01 ` [PATCH 3/7] delayacct: track delays from thrashing cache pages Johannes Weiner
2018-05-07 21:01 ` [PATCH 4/7] sched: loadavg: consolidate LOAD_INT, LOAD_FRAC, CALC_LOAD Johannes Weiner
2018-05-07 21:01 ` [PATCH 5/7] sched: loadavg: make calc_load_n() public Johannes Weiner
2018-05-09 9:49 ` Peter Zijlstra
2018-05-10 13:46 ` Johannes Weiner
2018-05-07 21:01 ` [PATCH 6/7] psi: pressure stall information for CPU, memory, and IO Johannes Weiner
2018-05-08 0:42 ` Randy Dunlap
2018-05-08 14:06 ` Johannes Weiner
2018-05-08 1:35 ` kbuild test robot
2018-05-08 3:04 ` kbuild test robot
2018-05-08 14:05 ` Johannes Weiner
2018-05-09 9:59 ` Peter Zijlstra
2018-05-10 13:49 ` Johannes Weiner
2018-05-09 10:04 ` Peter Zijlstra
2018-05-10 14:10 ` Johannes Weiner
2018-05-09 10:05 ` Peter Zijlstra
2018-05-10 14:13 ` Johannes Weiner
2018-05-09 10:14 ` Peter Zijlstra
2018-05-10 14:18 ` Johannes Weiner
2018-05-09 10:21 ` Peter Zijlstra
2018-05-10 14:24 ` Johannes Weiner
2018-05-09 10:26 ` Peter Zijlstra
2018-05-09 10:46 ` Peter Zijlstra
2018-05-09 11:38 ` Peter Zijlstra
2018-05-10 13:41 ` Johannes Weiner
2018-05-14 8:33 ` Peter Zijlstra
2018-05-09 10:55 ` Peter Zijlstra
2018-05-09 11:03 ` Vinayak Menon
2018-05-23 13:17 ` Johannes Weiner [this message]
2018-05-23 13:19 ` Vinayak Menon
2018-06-07 0:46 ` Suren Baghdasaryan
2018-05-07 21:01 ` [PATCH 7/7] psi: cgroup support Johannes Weiner
2018-05-09 11:07 ` Peter Zijlstra
2018-05-10 14:49 ` Johannes Weiner
2018-05-14 15:39 ` [PATCH 0/7] psi: pressure stall information for CPU, memory, and IO Christopher Lameter
2018-05-14 17:35 ` Bart Van Assche
2018-05-14 18:55 ` Johannes Weiner
2018-05-14 20:15 ` Christopher Lameter
2018-05-26 0:29 ` Suren Baghdasaryan
2018-05-29 18:16 ` Johannes Weiner
2018-05-30 23:32 ` Suren Baghdasaryan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180523131747.GA4086@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=akpm@linuxfoundation.org \
--cc=bsingharora@gmail.com \
--cc=cgroups@vger.kernel.org \
--cc=danielwa@cisco.com \
--cc=efault@gmx.de \
--cc=kernel-team@fb.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rruslich@cisco.com \
--cc=shakeelb@google.com \
--cc=takondra@cisco.com \
--cc=tj@kernel.org \
--cc=vinmenon@codeaurora.org \
--cc=x.qendo@gmail.com \
--cc=yangoliver@me.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).