From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f197.google.com (mail-wr0-f197.google.com [209.85.128.197]) by kanga.kvack.org (Postfix) with ESMTP id 60C156B0007 for ; Mon, 4 Jun 2018 10:01:50 -0400 (EDT) Received: by mail-wr0-f197.google.com with SMTP id l17-v6so19249273wrm.3 for ; Mon, 04 Jun 2018 07:01:50 -0700 (PDT) Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com. [148.163.158.5]) by mx.google.com with ESMTPS id r6-v6si186515wma.177.2018.06.04.07.01.48 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 04 Jun 2018 07:01:49 -0700 (PDT) Received: from pps.filterd (m0098414.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w54E0gNU107744 for ; Mon, 4 Jun 2018 10:01:47 -0400 Received: from e06smtp05.uk.ibm.com (e06smtp05.uk.ibm.com [195.75.94.101]) by mx0b-001b2d01.pphosted.com with ESMTP id 2jd4yndxac-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 04 Jun 2018 10:01:46 -0400 Received: from localhost by e06smtp05.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 4 Jun 2018 15:01:43 +0100 Date: Mon, 4 Jun 2018 07:01:35 -0700 From: Ram Pai Subject: Re: pkeys on POWER: Access rights not reset on execve Reply-To: Ram Pai References: <20180519011947.GJ5479@ram.oc3035372033.ibm.com> <20180519202747.GK5479@ram.oc3035372033.ibm.com> <20180520060425.GL5479@ram.oc3035372033.ibm.com> <20180520191115.GM5479@ram.oc3035372033.ibm.com> <20180603201832.GA10109@ram.oc3035372033.ibm.com> <4e53b91f-80a7-816a-3e9b-56d7be7cd092@redhat.com> MIME-Version: 1.0 In-Reply-To: <4e53b91f-80a7-816a-3e9b-56d7be7cd092@redhat.com> Message-Id: <20180604140135.GA10088@ram.oc3035372033.ibm.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit Content-Disposition: inline Sender: owner-linux-mm@kvack.org List-ID: To: Florian Weimer Cc: Andy Lutomirski , Linux-MM , linuxppc-dev , Dave Hansen On Mon, Jun 04, 2018 at 12:12:07PM +0200, Florian Weimer wrote: > On 06/03/2018 10:18 PM, Ram Pai wrote: > >On Mon, May 21, 2018 at 01:29:11PM +0200, Florian Weimer wrote: > >>On 05/20/2018 09:11 PM, Ram Pai wrote: > >>>Florian, > >>> > >>> Does the following patch fix the problem for you? Just like x86 > >>> I am enabling all keys in the UAMOR register during > >>> initialization itself. Hence any key created by any thread at > >>> any time, will get activated on all threads. So any thread > >>> can change the permission on that key. Smoke tested it > >>> with your test program. > >> > >>I think this goes in the right direction, but the AMR value after > >>fork is still strange: > >> > >>AMR (PID 34912): 0x0000000000000000 > >>AMR after fork (PID 34913): 0x0000000000000000 > >>AMR (PID 34913): 0x0000000000000000 > >>Allocated key in subprocess (PID 34913): 2 > >>Allocated key (PID 34912): 2 > >>Setting AMR: 0xffffffffffffffff > >>New AMR value (PID 34912): 0x0fffffffffffffff > >>About to call execl (PID 34912) ... > >>AMR (PID 34912): 0x0fffffffffffffff > >>AMR after fork (PID 34914): 0x0000000000000003 > >>AMR (PID 34914): 0x0000000000000003 > >>Allocated key in subprocess (PID 34914): 2 > >>Allocated key (PID 34912): 2 > >>Setting AMR: 0xffffffffffffffff > >>New AMR value (PID 34912): 0x0fffffffffffffff > >> > >>I mean this line: > >> > >>AMR after fork (PID 34914): 0x0000000000000003 > >> > >>Shouldn't it be the same as in the parent process? > > > >Fixed it. Please try this patch. If it all works to your satisfaction, I > >will clean it up further and send to Michael Ellermen(ppc maintainer). > > > > > >commit 51f4208ed5baeab1edb9b0f8b68d7144449b3527 > >Author: Ram Pai > >Date: Sun Jun 3 14:44:32 2018 -0500 > > > > Fix for the fork bug. > > Signed-off-by: Ram Pai > > Is this on top of the previous patch, or a separate fix? top of previous patch. RP