From: Mike Rapoport <rppt@linux.vnet.ibm.com>
To: Timofey Titovets <nefelim4ag@gmail.com>
Cc: pasha.tatashin@oracle.com, linux-mm@kvack.org,
Sioh Lee <solee@os.korea.ac.kr>,
Andrea Arcangeli <aarcange@redhat.com>,
kvm@vger.kernel.org
Subject: Re: [PATCH V6 2/2 RESEND] ksm: replace jhash2 with faster hash
Date: Thu, 7 Jun 2018 14:52:33 +0300 [thread overview]
Message-ID: <20180607115232.GA8245@rapoport-lnx> (raw)
In-Reply-To: <CAGqmi74G-7bM5mbbaHjzOkTvuEpCcAbZ8Q0PVCMkyP09XaVSkA@mail.gmail.com>
On Thu, Jun 07, 2018 at 11:58:05AM +0300, Timofey Titovets wrote:
> D2N?, 29 D 1/4 D?N? 2018 D3. D2 17:46, Pavel Tatashin <pasha.tatashin@oracle.com>:
> >
> > > What about moving choice_fastest_hash() to run_store()?
> >
> > > KSM anyway starts with ksm_run = KSM_RUN_STOP and does not scan until
> > > userspace writes !0 to /sys/kernel/mm/ksm/run.
> >
> > > Selection of the hash function when KSM is actually enabled seems quite
> > > appropriate...
> >
> > Hi Mike,
> >
> > This is a good idea to select hash function from run_store() when (flags &
> > KSM_RUN_MERGE) is set for the first time.
> >
> > Pavel
>
> IIRC, run_store hidden under '#ifdef CONFIG_SYSFS'
> So, what's about case without CONFIG_SYSFS?
With CONFIG_SYSFS=n there is nothing that will set ksm_run to anything but
zero and ksm_do_scan will never be called.
> --
> Have a nice day,
> Timofey.
>
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2018-06-07 11:52 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-18 19:32 [PATCH V6 0/2 RESEND] KSM replace hash algo with faster hash Timofey Titovets
2018-04-18 19:32 ` [PATCH V6 1/2 RESEND] xxHash: create arch dependent 32/64-bit xxhash() Timofey Titovets
2018-04-18 19:32 ` [PATCH V6 2/2 RESEND] ksm: replace jhash2 with faster hash Timofey Titovets
2018-05-08 15:26 ` Claudio Imbrenda
2018-05-11 23:06 ` Timofey Titovets
2018-05-14 10:17 ` Claudio Imbrenda
2018-05-16 10:26 ` Timofey Titovets
2018-05-22 20:22 ` Pavel Tatashin
2018-05-23 13:45 ` Timofey Titovets
2018-05-23 14:24 ` Pavel Tatashin
2018-05-24 8:01 ` Timofey Titovets
2018-05-25 1:16 ` Pavel Tatashin
2018-05-26 20:25 ` [PATCH] " kbuild test robot
2018-05-26 21:06 ` kbuild test robot
2018-05-27 13:03 ` [PATCH V6 2/2 RESEND] " Mike Rapoport
2018-05-29 14:45 ` Pavel Tatashin
2018-06-07 8:58 ` Timofey Titovets
2018-06-07 11:52 ` Mike Rapoport [this message]
2018-06-08 1:29 ` Pavel Tatashin
2018-06-10 5:38 ` Mike Rapoport
2018-06-22 18:48 ` Pavel Tatashin
2018-06-25 8:48 ` Mike Rapoport
2018-09-13 10:35 ` Timofey Titovets
2018-09-13 18:01 ` Mike Rapoport
2018-09-13 18:10 ` Pasha Tatashin
-- strict thread matches above, loose matches on Subject: below --
2018-02-07 10:22 [PATCH V6 0/2 RESEND] KSM replace hash algo " Timofey Titovets
2018-02-07 10:22 ` [PATCH V6 2/2 RESEND] ksm: replace jhash2 " Timofey Titovets
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180607115232.GA8245@rapoport-lnx \
--to=rppt@linux.vnet.ibm.com \
--cc=aarcange@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nefelim4ag@gmail.com \
--cc=pasha.tatashin@oracle.com \
--cc=solee@os.korea.ac.kr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).