From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f71.google.com (mail-pg0-f71.google.com [74.125.83.71]) by kanga.kvack.org (Postfix) with ESMTP id 9E9636B0007 for ; Thu, 28 Jun 2018 02:18:42 -0400 (EDT) Received: by mail-pg0-f71.google.com with SMTP id x6-v6so1964680pgp.9 for ; Wed, 27 Jun 2018 23:18:42 -0700 (PDT) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org. [140.211.169.12]) by mx.google.com with ESMTPS id a9-v6si5671007pla.377.2018.06.27.23.18.41 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 27 Jun 2018 23:18:41 -0700 (PDT) Date: Wed, 27 Jun 2018 23:18:39 -0700 From: Andrew Morton Subject: Re: [PATCH -mm -v4 00/21] mm, THP, swap: Swapout/swapin THP in one piece Message-Id: <20180627231839.e5ac2f38e0397979d3db7765@linux-foundation.org> In-Reply-To: <87muvffp7w.fsf@yhuang-dev.intel.com> References: <20180622035151.6676-1-ying.huang@intel.com> <20180627215144.73e98b01099191da59bff28c@linux-foundation.org> <87r2krfpi2.fsf@yhuang-dev.intel.com> <20180627223118.dd2f52d87f53e7e002ed0153@linux-foundation.org> <87muvffp7w.fsf@yhuang-dev.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: "Huang, Ying" Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Hugh Dickins , "Kirill A. Shutemov" , Daniel Jordan , Matthew Wilcox On Thu, 28 Jun 2018 13:35:15 +0800 "Huang\, Ying" wrote: > Andrew Morton writes: > > > On Thu, 28 Jun 2018 13:29:09 +0800 "Huang\, Ying" wrote: > > > >> Andrew Morton writes: > >> > >> > On Fri, 22 Jun 2018 11:51:30 +0800 "Huang, Ying" wrote: > >> > > >> >> This is the final step of THP (Transparent Huge Page) swap > >> >> optimization. After the first and second step, the splitting huge > >> >> page is delayed from almost the first step of swapout to after swapout > >> >> has been finished. In this step, we avoid splitting THP for swapout > >> >> and swapout/swapin the THP in one piece. > >> > > >> > It's a tremendously good performance improvement. It's also a > >> > tremendously large patchset :( > >> > > >> > And it depends upon your > >> > mm-swap-fix-race-between-swapoff-and-some-swap-operations.patch and > >> > mm-fix-race-between-swapoff-and-mincore.patch, the first of which has > >> > been floating about since February without adequate review. > >> > > >> > I'll give this patchset a spin in -mm to see what happens and will come > >> > back later to take a closer look. But the best I can do at this time > >> > is to hopefully cc some possible reviewers :) > >> > >> Thanks a lot for your help! Hope more people can review it! > > > > I took it out of -mm again, temporarily. Due to a huge tangle with the > > xarray conversions in linux-next. > > No problem. I will rebase the patchset on your latest -mm tree, or the > next version to be released? We need to figure that out with Matthew. Probably the xarray conversions are simpler and more mature so yes, probably they should be staged first.