From: Will Deacon <will.deacon@arm.com>
To: "Kani, Toshi" <toshi.kani@hpe.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
"joro@8bytes.org" <joro@8bytes.org>,
"x86@kernel.org" <x86@kernel.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"hpa@zytor.com" <hpa@zytor.com>,
"mingo@redhat.com" <mingo@redhat.com>,
"Hocko, Michal" <MHocko@suse.com>,
"cpandya@codeaurora.org" <cpandya@codeaurora.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v4 2/3] ioremap: Update pgtable free interfaces with addr
Date: Fri, 29 Jun 2018 13:23:59 +0100 [thread overview]
Message-ID: <20180629122358.GC17859@arm.com> (raw)
In-Reply-To: <1530115885.14039.295.camel@hpe.com>
Hi Toshi, Thomas,
On Wed, Jun 27, 2018 at 04:13:22PM +0000, Kani, Toshi wrote:
> On Wed, 2018-06-27 at 16:56 +0100, Will Deacon wrote:
> > On Wed, Jun 27, 2018 at 08:13:47AM -0600, Toshi Kani wrote:
> > > From: Chintan Pandya <cpandya@codeaurora.org>
> > >
> > > The following kernel panic was observed on ARM64 platform due to a stale
> > > TLB entry.
> > >
> > > 1. ioremap with 4K size, a valid pte page table is set.
> > > 2. iounmap it, its pte entry is set to 0.
> > > 3. ioremap the same address with 2M size, update its pmd entry with
> > > a new value.
> > > 4. CPU may hit an exception because the old pmd entry is still in TLB,
> > > which leads to a kernel panic.
> > >
> > > Commit b6bdb7517c3d ("mm/vmalloc: add interfaces to free unmapped page
> > > table") has addressed this panic by falling to pte mappings in the above
> > > case on ARM64.
> > >
> > > To support pmd mappings in all cases, TLB purge needs to be performed
> > > in this case on ARM64.
> > >
> > > Add a new arg, 'addr', to pud_free_pmd_page() and pmd_free_pte_page()
> > > so that TLB purge can be added later in seprate patches.
> >
> > So I acked v13 of Chintan's series posted here:
> >
> > http://lists.infradead.org/pipermail/linux-arm-kernel/2018-June/582953.html
> >
> > any chance this lot could all be merged together, please?
>
> Chintan's patch 2/3 and 3/3 apply cleanly on top of my series. Can you
> please coordinate with Thomas on the logistics?
Sure. I guess having this series on a common branch that I can pull into
arm64 and apply Chintan's other patches on top would work.
How does that sound?
Will
next prev parent reply other threads:[~2018-06-29 12:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-27 14:13 [PATCH v4 0/3] fix free pmd/pte page handlings on x86 Toshi Kani
2018-06-27 14:13 ` [PATCH v4 1/3] x86/mm: disable ioremap free page handling on x86-PAE Toshi Kani
2018-06-27 14:13 ` [PATCH v4 2/3] ioremap: Update pgtable free interfaces with addr Toshi Kani
2018-06-27 15:56 ` Will Deacon
2018-06-27 16:13 ` Kani, Toshi
2018-06-29 12:23 ` Will Deacon [this message]
2018-06-29 16:01 ` Kani, Toshi
2018-07-03 21:02 ` Thomas Gleixner
2018-07-04 17:36 ` Will Deacon
2018-07-04 19:39 ` Thomas Gleixner
2018-07-05 17:16 ` Will Deacon
2018-06-27 14:13 ` [PATCH v4 3/3] x86/mm: add TLB purge to free pmd/pte page interfaces Toshi Kani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180629122358.GC17859@arm.com \
--to=will.deacon@arm.com \
--cc=MHocko@suse.com \
--cc=akpm@linux-foundation.org \
--cc=cpandya@codeaurora.org \
--cc=hpa@zytor.com \
--cc=joro@8bytes.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@redhat.com \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=toshi.kani@hpe.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).