From: Mike Rapoport <rppt@linux.vnet.ibm.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: Vlastimil Babka <vbabka@suse.cz>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Greg Ungerer <gerg@linux-m68k.org>, Sam Creasey <sammy@sammy.net>,
linux-m68k <linux-m68k@lists.linux-m68k.org>,
Linux MM <linux-mm@kvack.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 3/3] m68k: switch to MEMBLOCK + NO_BOOTMEM
Date: Wed, 4 Jul 2018 15:57:21 +0300 [thread overview]
Message-ID: <20180704125720.GG4352@rapoport-lnx> (raw)
In-Reply-To: <20180704125121.GO22503@dhcp22.suse.cz>
On Wed, Jul 04, 2018 at 02:51:21PM +0200, Michal Hocko wrote:
> On Wed 04-07-18 15:43:35, Mike Rapoport wrote:
> > On Wed, Jul 04, 2018 at 02:36:27PM +0200, Michal Hocko wrote:
> [...]
> > > diff --git a/mm/memblock.c b/mm/memblock.c
> > > index 03d48d8835ba..2acec4033389 100644
> > > --- a/mm/memblock.c
> > > +++ b/mm/memblock.c
> > > @@ -227,7 +227,8 @@ phys_addr_t __init_memblock memblock_find_in_range_node(phys_addr_t size,
> > > * so we use WARN_ONCE() here to see the stack trace if
> > > * fail happens.
> > > */
> > > - WARN_ONCE(1, "memblock: bottom-up allocation failed, memory hotunplug may be affected\n");
> > > + WARN_ONCE(IS_ENABLED(CONFIG_MEMORY_HOTREMOVE),
> > > + "memblock: bottom-up allocation failed, memory hotremove may be affected\n");
> >
> > nit: isn't the warning indented too much?
>
> this is what vim did for me. The string doesn't fit into 80 even if I
> indented it to the first bracket. If you feel strongly I can do that
> though.
Not really. With wrapping if looks better like this :)
> --
> Michal Hocko
> SUSE Labs
>
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2018-07-04 12:57 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-04 6:28 [PATCH v2 0/3] m68k: switch to MEMBLOCK + NO_BOOTMEM Mike Rapoport
2018-07-04 6:28 ` [PATCH v2 1/3] m68k/bitops: convert __ffs to match generic declaration Mike Rapoport
2018-07-04 6:28 ` [PATCH v2 2/3] m68k/page_no.h: force __va argument to be unsigned long Mike Rapoport
2018-07-04 6:28 ` [PATCH v2 3/3] m68k: switch to MEMBLOCK + NO_BOOTMEM Mike Rapoport
2018-07-04 7:44 ` Geert Uytterhoeven
2018-07-04 7:54 ` Michal Hocko
2018-07-04 8:21 ` Geert Uytterhoeven
2018-07-04 12:22 ` Vlastimil Babka
2018-07-04 12:36 ` Michal Hocko
2018-07-04 12:43 ` Mike Rapoport
2018-07-04 12:51 ` Michal Hocko
2018-07-04 12:57 ` Mike Rapoport [this message]
2018-07-04 13:05 ` Geert Uytterhoeven
2018-07-04 13:14 ` Michal Hocko
2018-07-06 6:17 ` Michal Hocko
2018-07-05 12:13 ` [PATCH v2 0/3] " Greg Ungerer
2018-07-18 11:39 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180704125720.GG4352@rapoport-lnx \
--to=rppt@linux.vnet.ibm.com \
--cc=geert@linux-m68k.org \
--cc=gerg@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=sammy@sammy.net \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).