From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Michal Hocko <mhocko@kernel.org>,
Kirill Tkhai <ktkhai@virtuozzo.com>,
cgroups@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] memcg: Remove memcg_cgroup::id from IDR on mem_cgroup_css_alloc() failure
Date: Wed, 1 Aug 2018 19:22:35 +0300 [thread overview]
Message-ID: <20180801162235.j3v7xipyw5afnj4x@esperanza> (raw)
In-Reply-To: <20180801155552.GA8600@cmpxchg.org>
On Wed, Aug 01, 2018 at 11:55:52AM -0400, Johannes Weiner wrote:
> On Tue, Jul 31, 2018 at 04:39:08PM -0700, Andrew Morton wrote:
> > On Mon, 30 Jul 2018 11:31:13 -0400 Johannes Weiner <hannes@cmpxchg.org> wrote:
> >
> > > Subject: [PATCH] mm: memcontrol: simplify memcg idr allocation and error
> > > unwinding
> > >
> > > The memcg ID is allocated early in the multi-step memcg creation
> > > process, which needs 2-step ID allocation and IDR publishing, as well
> > > as two separate IDR cleanup/unwind sites on error.
> > >
> > > Defer the IDR allocation until the last second during onlining to
> > > eliminate all this complexity. There is no requirement to have the ID
> > > and IDR entry earlier than that. And the root reference to the ID is
> > > put in the offline path, so this matches nicely.
> >
> > This patch isn't aware of Kirill's later "mm, memcg: assign memcg-aware
> > shrinkers bitmap to memcg", which altered mem_cgroup_css_online():
> >
> > @@ -4356,6 +4470,11 @@ static int mem_cgroup_css_online(struct
> > {
> > struct mem_cgroup *memcg = mem_cgroup_from_css(css);
> >
> > + if (memcg_alloc_shrinker_maps(memcg)) {
> > + mem_cgroup_id_remove(memcg);
> > + return -ENOMEM;
> > + }
> > +
> > /* Online state pins memcg ID, memcg ID pins CSS */
> > atomic_set(&memcg->id.ref, 1);
> > css_get(css);
> >
>
> Hm, that looks out of place too. The bitmaps are allocated for the
> entire lifetime of the css, not just while it's online.
>
> Any objections to the following fixup to that patch?
That would be incorrect. Memory cgroups that haven't been put online
are invisible to for_each_mem_cgroup(), which is used for expanding
shrinker maps of all cgroups - see memcg_expand_shrinker_maps(). So if
memcg_expand_shrinker_maps() is called between css_alloc and css_online,
it will miss this cgroup and its shrinker_map won't be reallocated to
fit the new id. Allocating the shrinker map in css_online guarantees
that it won't happen. Looks like this code lacks a comment...
next prev parent reply other threads:[~2018-08-01 16:22 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-12 14:52 [PATCH] memcg: Remove memcg_cgroup::id from IDR on mem_cgroup_css_alloc() failure Kirill Tkhai
2018-04-13 8:55 ` Michal Hocko
2018-04-13 9:35 ` Kirill Tkhai
2018-04-13 11:02 ` Michal Hocko
2018-04-13 11:06 ` Kirill Tkhai
2018-04-13 11:20 ` Michal Hocko
2018-04-13 11:29 ` Kirill Tkhai
2018-04-13 11:38 ` Michal Hocko
2018-04-13 11:49 ` Kirill Tkhai
2018-04-13 11:54 ` Michal Hocko
2018-04-13 12:07 ` Kirill Tkhai
2018-04-13 12:14 ` Michal Hocko
2018-04-13 12:51 ` Michal Hocko
2018-07-26 23:25 ` Andrew Morton
2018-07-27 19:31 ` Johannes Weiner
2018-07-29 19:26 ` Vladimir Davydov
2018-07-30 15:31 ` Johannes Weiner
2018-07-31 23:39 ` Andrew Morton
2018-08-01 15:55 ` Johannes Weiner
2018-08-01 16:22 ` Vladimir Davydov [this message]
2018-08-02 8:03 ` Kirill Tkhai
2018-08-02 8:13 ` [PATCH] memcg: Add comment to mem_cgroup_css_online() Kirill Tkhai
2018-08-01 16:16 ` [PATCH] memcg: Remove memcg_cgroup::id from IDR on mem_cgroup_css_alloc() failure Vladimir Davydov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180801162235.j3v7xipyw5afnj4x@esperanza \
--to=vdavydov.dev@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=ktkhai@virtuozzo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).