From: Matthew Wilcox <willy@infradead.org>
To: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v1] tools/vm/slabinfo.c: fix sign-compare warning
Date: Sat, 25 Aug 2018 19:21:14 -0700 [thread overview]
Message-ID: <20180826022114.GA23206@bombadil.infradead.org> (raw)
In-Reply-To: <1535103134-20239-1-git-send-email-n-horiguchi@ah.jp.nec.com>
On Fri, Aug 24, 2018 at 06:32:14PM +0900, Naoya Horiguchi wrote:
> - int hwcache_align, object_size, objs_per_slab;
> - int sanity_checks, slab_size, store_user, trace;
> + int hwcache_align, objs_per_slab;
> + int sanity_checks, store_user, trace;
> int order, poison, reclaim_account, red_zone;
> + unsigned int object_size, slab_size;
Surely hwcache_align and objs_per_slab can't be negative either?
Nor the other three. So maybe convert all seven of these variables to
unsigned int?
next prev parent reply other threads:[~2018-08-26 2:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-24 9:32 [PATCH v1] tools/vm/slabinfo.c: fix sign-compare warning Naoya Horiguchi
2018-08-26 2:21 ` Matthew Wilcox [this message]
2018-08-26 23:49 ` [PATCH v2] " Naoya Horiguchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180826022114.GA23206@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=n-horiguchi@ah.jp.nec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).