From: Michal Hocko <mhocko@kernel.org>
To: Gerald Schaefer <gerald.schaefer@de.ibm.com>
Cc: Mikhail Zaslonko <zaslonko@linux.ibm.com>,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, Pavel.Tatashin@microsoft.com,
osalvador@suse.de
Subject: Re: [PATCH] memory_hotplug: fix the panic when memory end is not on the section boundary
Date: Wed, 12 Sep 2018 15:39:33 +0200 [thread overview]
Message-ID: <20180912133933.GI10951@dhcp22.suse.cz> (raw)
In-Reply-To: <20180912150356.642c1dab@thinkpad>
On Wed 12-09-18 15:03:56, Gerald Schaefer wrote:
[...]
> BTW, those sysfs attributes are world-readable, so anyone can trigger
> the panic by simply reading them, or just run lsmem (also available for
> x86 since util-linux 2.32). OK, you need a special not-memory-block-aligned
> mem= parameter and DEBUG_VM for poison check, but w/o DEBUG_VM you would
> still access uninitialized struct pages. This sounds very wrong, and I
> think it really should be fixed.
Ohh, absolutely. Nobody is questioning that. The thing is that the
code has been likely always broken. We just haven't noticed because
those unitialized parts where zeroed previously. Now that the implicit
zeroying is gone it is just visible.
All that I am arguing is that there are many places which assume
pageblocks to be fully initialized and plugging one place that blows up
at the time is just whack a mole. We need to address this much earlier.
E.g. by allowing only full pageblocks when adding a memory range.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2018-09-12 13:39 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-10 12:35 [PATCH] memory_hotplug: fix the panic when memory end is not on the section boundary Mikhail Zaslonko
2018-09-10 13:17 ` Michal Hocko
2018-09-10 13:46 ` Pasha Tatashin
2018-09-10 13:59 ` Michal Hocko
2018-09-10 14:11 ` Pasha Tatashin
2018-09-10 14:19 ` Michal Hocko
2018-09-10 14:32 ` Pasha Tatashin
2018-09-10 14:41 ` Michal Hocko
2018-09-10 15:26 ` Pasha Tatashin
2018-09-11 9:16 ` Michal Hocko
2018-09-12 14:28 ` Gerald Schaefer
2018-09-11 14:08 ` Zaslonko Mikhail
2018-09-11 14:06 ` Zaslonko Mikhail
2018-09-12 12:21 ` Michal Hocko
2018-09-12 13:03 ` Gerald Schaefer
2018-09-12 13:39 ` Michal Hocko [this message]
2018-09-12 14:27 ` Gerald Schaefer
2018-09-12 14:40 ` Pasha Tatashin
2018-09-12 15:51 ` Gerald Schaefer
2018-10-24 19:28 ` Zaslonko Mikhail
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180912133933.GI10951@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=Pavel.Tatashin@microsoft.com \
--cc=akpm@linux-foundation.org \
--cc=gerald.schaefer@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=osalvador@suse.de \
--cc=zaslonko@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).