From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by kanga.kvack.org (Postfix) with ESMTP id 3FCE96B0008 for ; Tue, 16 Oct 2018 19:16:47 -0400 (EDT) Received: by mail-pl1-f200.google.com with SMTP id b95-v6so19689891plb.10 for ; Tue, 16 Oct 2018 16:16:47 -0700 (PDT) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org. [140.211.169.12]) by mx.google.com with ESMTPS id b11-v6si14109641pgw.517.2018.10.16.16.16.45 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 16 Oct 2018 16:16:46 -0700 (PDT) Date: Tue, 16 Oct 2018 16:16:43 -0700 From: Andrew Morton Subject: Re: [PATCH 1/2] mm: thp: relax __GFP_THISNODE for MADV_HUGEPAGE mappings Message-Id: <20181016161643.9c16164889b4d99d6eff6763@linux-foundation.org> In-Reply-To: <20181016231149.GJ30832@redhat.com> References: <20181009094825.GC6931@suse.de> <20181009122745.GN8528@dhcp22.suse.cz> <20181009130034.GD6931@suse.de> <20181009142510.GU8528@dhcp22.suse.cz> <20181009230352.GE9307@redhat.com> <20181015154459.e870c30df5c41966ffb4aed8@linux-foundation.org> <20181016074606.GH6931@suse.de> <20181016153715.b40478ff2eebe8d6cf1aead5@linux-foundation.org> <20181016231149.GJ30832@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Andrea Arcangeli Cc: Mel Gorman , David Rientjes , Michal Hocko , Vlastimil Babka , Andrea Argangeli , Zi Yan , Stefan Priebe - Profihost AG , "Kirill A. Shutemov" , linux-mm@kvack.org, LKML , Stable tree On Tue, 16 Oct 2018 19:11:49 -0400 Andrea Arcangeli wrote: > This was a severe regression > compared to previous kernels that made important workloads unusable > and it starts when __GFP_THISNODE was added to THP allocations under > MADV_HUGEPAGE. It is not a significant risk to go to the previous > behavior before __GFP_THISNODE was added, it worked like that for > years. 5265047ac301 ("mm, thp: really limit transparent hugepage allocation to local node") was April 2015. That's a long time for a "severe regression" to go unnoticed?