From: Andrew Morton <akpm@linux-foundation.org>
To: David Rientjes <rientjes@google.com>
Cc: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
Michal Hocko <mhocko@kernel.org>,
Johannes Weiner <hannes@cmpxchg.org>,
linux-mm@kvack.org, syzkaller-bugs@googlegroups.com, guro@fb.com,
kirill.shutemov@linux.intel.com, linux-kernel@vger.kernel.org,
yang.s@alibaba-inc.com,
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
Petr Mladek <pmladek@suse.com>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH] mm,oom: Use timeout based back off.
Date: Wed, 24 Oct 2018 15:54:54 -0700 [thread overview]
Message-ID: <20181024155454.4e63191fbfaa0441f2e62f56@linux-foundation.org> (raw)
In-Reply-To: <alpine.DEB.2.21.1810221406400.120157@chino.kir.corp.google.com>
On Mon, 22 Oct 2018 14:11:10 -0700 (PDT) David Rientjes <rientjes@google.com> wrote:
> > Michal has been refusing timeout based approach, but I don't think this
> > is something we have to be frayed around the edge about possibility of
> > overlooking races/bugs just because Michal does not want to use timeout.
> > I believe that timeout based back off is the only approach we can use
> > for now.
> >
>
> I've proposed patches that have been running for months in a production
> environment that make the oom killer useful without serially killing many
> processes unnecessarily. At this point, it is *much* easier to just fork
> the oom killer logic rather than continue to invest time into fixing it in
> Linux. That's unfortunate because I'm sure you realize how problematic
> the current implementation is, how abusive it is, and have seen its
> effects yourself. I admire your persistance in trying to fix the issues
> surrounding the oom killer, but have come to the conclusion that forking
> it is a much better use of time.
The oom killer is, I think, fairly standalone and it shouldn't be too
hard to add the infrastructure to make the whole thing pluggable. At
runtime, not at build time.
But it is a last resort - it will result in fragmented effort and
difficult decisions for everyone regarding which should be used.
There has been a lot of heat and noise and confusion and handwaving in
all of this. What we're crying out for is simple testcases which
everyone can run. Find a problem, write the testcase, distribute that.
Develop a solution for that testcase then move on to the next one.
next prev parent reply other threads:[~2018-10-24 22:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-20 10:57 [PATCH] mm,oom: Use timeout based back off Tetsuo Handa
2018-10-22 21:11 ` David Rientjes
2018-10-23 5:56 ` Michal Hocko
2018-10-24 22:54 ` Andrew Morton [this message]
2018-10-25 7:11 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181024155454.4e63191fbfaa0441f2e62f56@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=pmladek@suse.com \
--cc=rientjes@google.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=sergey.senozhatsky@gmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=yang.s@alibaba-inc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).