From: Wei Yang <richard.weiyang@gmail.com>
To: cl@linux.com, penberg@kernel.org, rientjes@google.com
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
Wei Yang <richard.weiyang@gmail.com>
Subject: [PATCH 3/3] mm, slub: make the comment of put_cpu_partial() complete
Date: Thu, 25 Oct 2018 17:44:37 +0800 [thread overview]
Message-ID: <20181025094437.18951-3-richard.weiyang@gmail.com> (raw)
In-Reply-To: <20181025094437.18951-1-richard.weiyang@gmail.com>
There are two cases when put_cpu_partial() is invoked.
* __slab_free
* get_partial_node
This patch just makes it cover these two cases and fix one typo in
slub_def.h.
Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
---
include/linux/slub_def.h | 2 +-
mm/slub.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/linux/slub_def.h b/include/linux/slub_def.h
index 3a1a1dbc6f49..201a635be846 100644
--- a/include/linux/slub_def.h
+++ b/include/linux/slub_def.h
@@ -81,7 +81,7 @@ struct kmem_cache_order_objects {
*/
struct kmem_cache {
struct kmem_cache_cpu __percpu *cpu_slab;
- /* Used for retriving partial slabs etc */
+ /* Used for retrieving partial slabs etc */
slab_flags_t flags;
unsigned long min_partial;
unsigned int size; /* The size of an object including meta data */
diff --git a/mm/slub.c b/mm/slub.c
index 715372a786e3..3db6ce58e92e 100644
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -2201,8 +2201,8 @@ static void unfreeze_partials(struct kmem_cache *s,
}
/*
- * Put a page that was just frozen (in __slab_free) into a partial page
- * slot if available.
+ * Put a page that was just frozen (in __slab_free|get_partial_node) into a
+ * partial page slot if available.
*
* If we did not find a slot then simply move all the partials to the
* per node partial list.
--
2.15.1
next prev parent reply other threads:[~2018-10-25 9:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-25 9:44 [PATCH 1/3] mm, slub: not retrieve cpu_slub again in new_slab_objects() Wei Yang
2018-10-25 9:44 ` [PATCH 2/3] mm, slub: unify access to s->cpu_slab by replacing raw_cpu_ptr() with this_cpu_ptr() Wei Yang
2018-10-25 13:53 ` Christopher Lameter
2018-10-25 14:49 ` Wei Yang
2018-10-25 9:44 ` Wei Yang [this message]
2018-10-25 13:41 ` [PATCH 3/3] mm, slub: make the comment of put_cpu_partial() complete Christopher Lameter
2018-12-30 8:25 ` Wei Yang
2018-10-25 13:46 ` [PATCH 1/3] mm, slub: not retrieve cpu_slub again in new_slab_objects() Christopher Lameter
2018-10-25 14:54 ` Wei Yang
2018-10-26 4:33 ` Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181025094437.18951-3-richard.weiyang@gmail.com \
--to=richard.weiyang@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).