From: Mel Gorman <mgorman@techsingularity.net>
To: Linux-MM <linux-mm@kvack.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Vlastimil Babka <vbabka@suse.cz>,
David Rientjes <rientjes@google.com>,
Andrea Arcangeli <aarcange@redhat.com>,
Zi Yan <zi.yan@cs.rutgers.edu>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/5] mm: Reclaim small amounts of memory when an external fragmentation event occurs
Date: Wed, 31 Oct 2018 16:56:52 +0000 [thread overview]
Message-ID: <20181031165651.GE23537@techsingularity.net> (raw)
In-Reply-To: <20181031160645.7633-4-mgorman@techsingularity.net>
On Wed, Oct 31, 2018 at 04:06:43PM +0000, Mel Gorman wrote:
> An external fragmentation event was previously described as
>
> When the page allocator fragments memory, it records the event using
> the mm_page_alloc_extfrag event. If the fallback_order is smaller
> than a pageblock order (order-9 on 64-bit x86) then it's considered
> an event that will cause external fragmentation issues in the future.
>
This had a build error reported by the 0-day bot. It's trivially fixed
with
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 77bcc35903e0..e36c279dfade 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -3317,8 +3317,8 @@ static bool zone_allows_reclaim(struct zone *local_zone, struct zone *zone)
* probably too small. It only makes sense to spread allocations to avoid
* fragmentation between the Normal and DMA32 zones.
*/
-static inline unsigned int alloc_flags_nofragment(struct zone *zone,
- gfp_t gfp_mask)
+static inline unsigned int
+alloc_flags_nofragment(struct zone *zone, gfp_t gfp_mask)
{
if (zone_idx(zone) != ZONE_NORMAL)
return 0;
@@ -3340,7 +3340,8 @@ static inline unsigned int alloc_flags_nofragment(struct zone *zone,
return ALLOC_NOFRAGMENT;
}
#else
-static inline unsigned int alloc_flags_nofragment(struct zone *zone)
+static inline unsigned int
+alloc_flags_nofragment(struct zone *zone, gfp_t gfp_mask)
{
return 0;
}
--
Mel Gorman
SUSE Labs
next prev parent reply other threads:[~2018-10-31 16:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-31 16:06 [PATCH 0/5] Fragmentation avoidance improvements Mel Gorman
2018-10-31 16:06 ` [PATCH 1/5] mm, page_alloc: Spread allocations across zones before introducing fragmentation Mel Gorman
2018-10-31 16:06 ` [PATCH 2/5] mm: Move zone watermark accesses behind an accessor Mel Gorman
2018-10-31 16:06 ` [PATCH 3/5] mm: Reclaim small amounts of memory when an external fragmentation event occurs Mel Gorman
2018-10-31 16:56 ` Mel Gorman [this message]
2018-10-31 16:06 ` [PATCH 4/5] mm: Stall movable allocations until kswapd progresses during serious external fragmentation event Mel Gorman
2018-10-31 16:06 ` [PATCH 5/5] mm: Target compaction on pageblocks that were recently fragmented Mel Gorman
2018-11-07 18:38 [PATCH 0/5] Fragmentation avoidance improvements v2 Mel Gorman
2018-11-07 18:38 ` [PATCH 3/5] mm: Reclaim small amounts of memory when an external fragmentation event occurs Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181031165651.GE23537@techsingularity.net \
--to=mgorman@techsingularity.net \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
--cc=vbabka@suse.cz \
--cc=zi.yan@cs.rutgers.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).