From: Michal Hocko <mhocko@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Dan Williams <dan.j.williams@gmail.com>,
Johannes Thumshirn <jthumshirn@suse.de>,
linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] memory_hotplug: cond_resched in __remove_pages
Date: Wed, 31 Oct 2018 22:42:08 +0100 [thread overview]
Message-ID: <20181031214208.GA5564@dhcp22.suse.cz> (raw)
In-Reply-To: <20181031121550.2f0cbd10a948880e534beaf7@linux-foundation.org>
On Wed 31-10-18 12:15:50, Andrew Morton wrote:
> On Wed, 31 Oct 2018 13:58:40 +0100 Michal Hocko <mhocko@kernel.org> wrote:
>
> > From: Michal Hocko <mhocko@suse.com>
> >
> > We have received a bug report that unbinding a large pmem (>1TB)
> > can result in a soft lockup:
> >
> > ...
> >
> > It has been reported on an older (4.12) kernel but the current upstream
> > code doesn't cond_resched in the hot remove code at all and the given
> > range to remove might be really large. Fix the issue by calling cond_resched
> > once per memory section.
> >
>
> Worthy of a cc:stable, I suggest?
It is simple enough and we will surely have it in 4.12 based SLES
kernels. So I do not really mind cc: stable.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2018-10-31 21:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-31 12:58 [PATCH] memory_hotplug: cond_resched in __remove_pages Michal Hocko
2018-10-31 13:11 ` Johannes Thumshirn
2018-10-31 19:15 ` Andrew Morton
2018-10-31 21:42 ` Michal Hocko [this message]
2018-11-02 3:52 ` Balbir Singh
2018-11-02 7:05 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181031214208.GA5564@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@gmail.com \
--cc=jthumshirn@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).