From: Michal Hocko <mhocko@kernel.org>
To: Arun KS <arunks@codeaurora.org>
Cc: keescook@chromium.org, khlebnikov@yandex-team.ru,
minchan@kernel.org, getarunks@gmail.com,
gregkh@linuxfoundation.org, akpm@linux-foundation.org,
mhocko@kernel.org, vbabka@suse.cz, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH v1 4/4] mm: Remove managed_page_count spinlock
Date: Wed, 7 Nov 2018 11:36:30 +0100 [thread overview]
Message-ID: <20181107103630.GF2453@dhcp22.suse.cz> (raw)
In-Reply-To: <20181106141732.GR27423@dhcp22.suse.cz>
[for some reason I have dropped the rest of the cc list. Restored]
On Tue 06-11-18 15:17:32, Michal Hocko wrote:
> On Fri 26-10-18 16:31:02, Arun KS wrote:
> > Now totalram_pages and managed_pages are atomic varibles. No need
> > of managed_page_count spinlock.
>
> Yes this is the real improvement. The lock had really a weak consistency
> guarantee. It hasn't been used for anything but the update but no reader
> actually cares about all the values being updated to be in sync. I
> haven't really done an excavation work to see whether it used to be used
> in other contexts in the past but it simply doesn't have any meaning
> anymore.
>
> > Signed-off-by: Arun KS <arunks@codeaurora.org>
>
> Acked-by: Michal Hocko <mhocko@suse.com>
>
> Thanks for getting through all the hassles to reach to this end point.
>
> > ---
> > include/linux/mmzone.h | 6 ------
> > mm/page_alloc.c | 5 -----
> > 2 files changed, 11 deletions(-)
> >
> > diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h
> > index 597b0c7..aa960f6 100644
> > --- a/include/linux/mmzone.h
> > +++ b/include/linux/mmzone.h
> > @@ -428,12 +428,6 @@ struct zone {
> > * Write access to present_pages at runtime should be protected by
> > * mem_hotplug_begin/end(). Any reader who can't tolerant drift of
> > * present_pages should get_online_mems() to get a stable value.
> > - *
> > - * Read access to managed_pages should be safe because it's unsigned
> > - * long. Write access to zone->managed_pages and totalram_pages are
> > - * protected by managed_page_count_lock at runtime. Idealy only
> > - * adjust_managed_page_count() should be used instead of directly
> > - * touching zone->managed_pages and totalram_pages.
> > */
> > atomic_long_t managed_pages;
> > unsigned long spanned_pages;
> > diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> > index af832de..e29e78f 100644
> > --- a/mm/page_alloc.c
> > +++ b/mm/page_alloc.c
> > @@ -122,9 +122,6 @@
> > };
> > EXPORT_SYMBOL(node_states);
> >
> > -/* Protect totalram_pages and zone->managed_pages */
> > -static DEFINE_SPINLOCK(managed_page_count_lock);
> > -
> > atomic_long_t _totalram_pages __read_mostly;
> > unsigned long totalreserve_pages __read_mostly;
> > unsigned long totalcma_pages __read_mostly;
> > @@ -7062,14 +7059,12 @@ static int __init cmdline_parse_movablecore(char *p)
> >
> > void adjust_managed_page_count(struct page *page, long count)
> > {
> > - spin_lock(&managed_page_count_lock);
> > atomic_long_add(count, &page_zone(page)->managed_pages);
> > totalram_pages_add(count);
> > #ifdef CONFIG_HIGHMEM
> > if (PageHighMem(page))
> > totalhigh_pages_add(count);
> > #endif
> > - spin_unlock(&managed_page_count_lock);
> > }
> > EXPORT_SYMBOL(adjust_managed_page_count);
> >
> > --
> > 1.9.1
>
> --
> Michal Hocko
> SUSE Labs
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2018-11-07 10:36 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-26 11:00 [PATCH v1 0/4]mm: convert totalram_pages, totalhigh_pages and managed pages to atomic Arun KS
2018-10-26 11:00 ` [PATCH v1 1/4] mm: Fix multiple evaluvations of totalram_pages and managed_pages Arun KS
2018-10-26 11:01 ` [PATCH v1 2/4] mm: Convert zone->managed_pages to atomic variable Arun KS
2018-10-26 11:01 ` [PATCH v1 3/4] mm: convert totalram_pages and totalhigh_pages variables to atomic Arun KS
[not found] ` <20181106141438.GQ27423@dhcp22.suse.cz>
2018-11-07 10:38 ` Michal Hocko
2018-10-26 11:01 ` [PATCH v1 4/4] mm: Remove managed_page_count spinlock Arun KS
[not found] ` <20181106141732.GR27423@dhcp22.suse.cz>
2018-11-07 10:36 ` Michal Hocko [this message]
2018-11-07 11:50 ` Vlastimil Babka
2018-11-06 5:38 ` [PATCH v1 0/4]mm: convert totalram_pages, totalhigh_pages and managed pages to atomic Arun KS
2018-11-06 8:17 ` Konstantin Khlebnikov
2018-11-06 8:30 ` Arun KS
2018-11-06 8:37 ` Konstantin Khlebnikov
2018-11-06 8:43 ` Arun KS
2018-11-07 7:02 ` Konstantin Khlebnikov
2018-11-07 8:50 ` Vlastimil Babka
2018-11-07 10:28 ` Michal Hocko
2018-11-07 10:39 ` Michal Hocko
2018-11-07 0:22 ` Andrew Morton
2018-11-07 6:19 ` Arun KS
-- strict thread matches above, loose matches on Subject: below --
2018-10-26 11:00 Arun KS
2018-10-26 11:00 ` [PATCH v1 4/4] mm: Remove managed_page_count spinlock Arun KS
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181107103630.GF2453@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=arunks@codeaurora.org \
--cc=getarunks@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=keescook@chromium.org \
--cc=khlebnikov@yandex-team.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).