From: Borislav Petkov <bp@alien8.de>
To: Michal Hocko <mhocko@kernel.org>
Cc: David Hildenbrand <david@redhat.com>,
Dave Young <dyoung@redhat.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org, devel@linuxdriverproject.org,
linux-fsdevel@vger.kernel.org, linux-pm@vger.kernel.org,
xen-devel@lists.xenproject.org,
Andrew Morton <akpm@linux-foundation.org>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Baoquan He <bhe@redhat.com>, Omar Sandoval <osandov@fb.com>,
Arnd Bergmann <arnd@arndb.de>,
Matthew Wilcox <willy@infradead.org>,
Lianbo Jiang <lijiang@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH RFC 3/6] kexec: export PG_offline to VMCOREINFO
Date: Thu, 15 Nov 2018 15:13:07 +0100 [thread overview]
Message-ID: <20181115141307.GH26448@zn.tnic> (raw)
In-Reply-To: <20181115121102.GP23831@dhcp22.suse.cz>
On Thu, Nov 15, 2018 at 01:11:02PM +0100, Michal Hocko wrote:
> I am not familiar with kexec to judge this particular patch but we
> cannot simply define any range for these pages (same as for hwpoison
> ones) because they can be almost anywhere in the available memory range.
> Then there can be countless of them. There is no other way to rule them
> out but to check the page state.
I guess, especially if it is a monster box with a lot of memory in it.
> I am not really sure what is the concern here exactly. Kdump is so
> closly tight to the specific kernel version that the api exported
> specifically for its purpose cannot be seriously considered an ABI.
> Kdump has to adopt all the time.
Right...
Except, when people start ogling vmcoreinfo for other things and start
exporting all kinds of kernel internals in there, my alarm bells start
ringing.
But ok, kdump *is* special and I guess that's fine.
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
next prev parent reply other threads:[~2018-11-15 14:13 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-14 21:16 [PATCH RFC 0/6] mm/kdump: allow to exclude pages that are logically offline David Hildenbrand
2018-11-14 21:16 ` [PATCH RFC 1/6] mm: balloon: update comment about isolation/migration/compaction David Hildenbrand
2018-11-14 21:17 ` [PATCH RFC 2/6] mm: convert PG_balloon to PG_offline David Hildenbrand
2018-11-14 22:23 ` Matthew Wilcox
2018-11-14 22:49 ` David Hildenbrand
2018-11-15 2:07 ` Mike Rapoport
2018-11-15 9:21 ` David Hildenbrand
2018-11-15 12:19 ` Michal Hocko
2018-11-14 21:17 ` [PATCH RFC 3/6] kexec: export PG_offline to VMCOREINFO David Hildenbrand
2018-11-15 6:19 ` Dave Young
2018-11-15 9:23 ` David Hildenbrand
2018-11-15 11:10 ` Borislav Petkov
2018-11-15 11:20 ` David Hildenbrand
2018-11-15 11:52 ` Borislav Petkov
2018-11-15 12:01 ` David Hildenbrand
2018-11-15 17:58 ` Borislav Petkov
2018-11-15 12:11 ` Michal Hocko
2018-11-15 14:13 ` Borislav Petkov [this message]
2018-11-14 21:17 ` [PATCH RFC 4/6] xen/balloon: mark inflated pages PG_offline David Hildenbrand
2018-11-14 21:17 ` [PATCH RFC 5/6] hv_balloon: " David Hildenbrand
2018-11-14 21:17 ` [PATCH RFC 6/6] PM / Hibernate: exclude all PageOffline() pages David Hildenbrand
2018-11-15 7:48 ` Pavel Machek
2018-11-15 12:23 ` Michal Hocko
2018-11-15 12:29 ` David Hildenbrand
2018-11-14 22:57 ` [PATCH RFC 0/6] mm/kdump: allow to exclude pages that are logically offline Nadav Amit
2018-11-14 23:05 ` David Hildenbrand
2018-11-14 23:41 ` Nadav Amit
2018-11-15 1:42 ` Julien Freche
2018-11-16 18:23 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181115141307.GH26448@zn.tnic \
--to=bp@alien8.de \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=bhe@redhat.com \
--cc=david@redhat.com \
--cc=devel@linuxdriverproject.org \
--cc=dyoung@redhat.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=lijiang@redhat.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-pm@vger.kernel.org \
--cc=mhocko@kernel.org \
--cc=mst@redhat.com \
--cc=osandov@fb.com \
--cc=willy@infradead.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).