From: Michal Hocko <mhocko@kernel.org>
To: David Hildenbrand <david@redhat.com>
Cc: linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
Oscar Salvador <OSalvador@suse.com>,
Pavel Tatashin <pasha.tatashin@oracle.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH 2/3] mm, memory_hotplug: deobfuscate migration part of offlining
Date: Tue, 20 Nov 2018 15:34:22 +0100 [thread overview]
Message-ID: <20181120143422.GN22247@dhcp22.suse.cz> (raw)
In-Reply-To: <f25bfa30-96cf-799c-6885-86a3a537a977@redhat.com>
On Tue 20-11-18 15:26:43, David Hildenbrand wrote:
[...]
> > + do {
> > + for (pfn = start_pfn; pfn;)
> > + {
>
> { on a new line looks weird.
>
> > + /* start memory hot removal */
> > + ret = -EINTR;
>
> I think we can move that into the "if (signal_pending(current))"
>
> (if my eyes are not wrong, this will not be touched otherwise)
Better?
diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
index 9cd161db3061..6bc3aee30f5e 100644
--- a/mm/memory_hotplug.c
+++ b/mm/memory_hotplug.c
@@ -1592,11 +1592,10 @@ static int __ref __offline_pages(unsigned long start_pfn,
}
do {
- for (pfn = start_pfn; pfn;)
- {
+ for (pfn = start_pfn; pfn;) {
/* start memory hot removal */
- ret = -EINTR;
if (signal_pending(current)) {
+ ret = -EINTR;
reason = "signal backoff";
goto failed_removal_isolated;
}
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2018-11-20 14:34 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-20 13:43 [RFC PATCH 0/3] few memory offlining enhancements Michal Hocko
2018-11-20 13:43 ` [RFC PATCH 1/3] mm, memory_hotplug: try to migrate full section worth of pages Michal Hocko
2018-11-20 14:18 ` David Hildenbrand
2018-11-20 14:25 ` Michal Hocko
2018-11-20 14:27 ` David Hildenbrand
2018-11-20 14:33 ` Pavel Tatashin
2018-11-20 14:51 ` osalvador
2018-11-20 15:00 ` Michal Hocko
2018-11-20 13:43 ` [RFC PATCH 2/3] mm, memory_hotplug: deobfuscate migration part of offlining Michal Hocko
2018-11-20 14:26 ` David Hildenbrand
2018-11-20 14:34 ` Michal Hocko [this message]
2018-11-20 14:34 ` David Hildenbrand
2018-11-20 15:13 ` osalvador
2018-11-20 15:18 ` Michal Hocko
2018-11-20 13:43 ` [RFC PATCH 3/3] mm, fault_around: do not take a reference to a locked page Michal Hocko
2018-11-20 14:07 ` Kirill A. Shutemov
2018-11-20 14:12 ` Michal Hocko
2018-11-20 14:17 ` Kirill A. Shutemov
2018-11-20 14:25 ` Michal Hocko
2018-11-21 4:51 ` William Kucharski
2018-11-21 7:07 ` Michal Hocko
2018-11-20 14:33 ` David Hildenbrand
2018-11-21 1:47 ` Hugh Dickins
2018-11-21 7:11 ` Michal Hocko
2018-11-22 2:27 ` Hugh Dickins
2018-11-22 9:05 ` Michal Hocko
2018-11-23 20:22 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181120143422.GN22247@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=OSalvador@suse.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pasha.tatashin@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).