From: Catalin Marinas <catalin.marinas@arm.com>
To: Andrey Konovalov <andreyknvl@google.com>
Cc: Will Deacon <will.deacon@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Robin Murphy <robin.murphy@arm.com>,
Kees Cook <keescook@chromium.org>,
Kate Stewart <kstewart@linuxfoundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@kernel.org>,
"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
Shuah Khan <shuah@kernel.org>,
linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org,
linux-mm@kvack.org, linux-arch@vger.kernel.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
Chintan Pandya <cpandya@codeaurora.org>,
Jacob Bramley <Jacob.Bramley@arm.com>,
Ruben Ayrapetyan <Ruben.Ayrapetyan@arm.com>,
Lee Smith <Lee.Smith@arm.com>, Kostya Serebryany <kcc@google.com>,
Dmitry Vyukov <dvyukov@google.com>,
Ramana Radhakrishnan <Ramana.Radhakrishnan@arm.com>,
Luc Van Oostenryck <luc.vanoostenryck@gmail.com>,
Evgeniy Stepanov <eugenis@google.com>
Subject: Re: [PATCH v8 3/8] arm64: untag user addresses in access_ok and __uaccess_mask_ptr
Date: Thu, 29 Nov 2018 18:24:48 +0000 [thread overview]
Message-ID: <20181129182446.GJ22027@arrakis.emea.arm.com> (raw)
In-Reply-To: <b23c2374235a33328817f2586cc055c69d91a2ec.1541687720.git.andreyknvl@google.com>
On Thu, Nov 08, 2018 at 03:36:10PM +0100, Andrey Konovalov wrote:
> copy_from_user (and a few other similar functions) are used to copy data
> from user memory into the kernel memory or vice versa. Since a user can
> provided a tagged pointer to one of the syscalls that use copy_from_user,
> we need to correctly handle such pointers.
>
> Do this by untagging user pointers in access_ok and in __uaccess_mask_ptr,
> before performing access validity checks.
>
> Signed-off-by: Andrey Konovalov <andreyknvl@google.com>
Reviewed-by: Catalin Marinas <catalin.marinas@arm.com>
next prev parent reply other threads:[~2018-11-29 18:24 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-08 14:36 [PATCH v8 0/8] arm64: untag user pointers passed to the kernel Andrey Konovalov
2018-11-08 14:36 ` [PATCH v8 1/8] arm64: add type casts to untagged_addr macro Andrey Konovalov
2018-11-29 18:22 ` Catalin Marinas
2018-12-06 12:34 ` Andrey Konovalov
2018-11-08 14:36 ` [PATCH v8 2/8] uaccess: add untagged_addr definition for other arches Andrey Konovalov
2018-11-29 18:23 ` Catalin Marinas
2018-12-06 12:36 ` Andrey Konovalov
2018-11-08 14:36 ` [PATCH v8 3/8] arm64: untag user addresses in access_ok and __uaccess_mask_ptr Andrey Konovalov
2018-11-29 18:24 ` Catalin Marinas [this message]
2018-11-08 14:36 ` [PATCH v8 4/8] mm, arm64: untag user addresses in mm/gup.c Andrey Konovalov
2018-11-08 14:36 ` [PATCH v8 5/8] lib, arm64: untag addrs passed to strncpy_from_user and strnlen_user Andrey Konovalov
2018-11-08 14:36 ` [PATCH v8 6/8] fs, arm64: untag user address in copy_mount_options Andrey Konovalov
2018-11-08 14:36 ` [PATCH v8 7/8] arm64: update Documentation/arm64/tagged-pointers.txt Andrey Konovalov
2018-11-08 14:36 ` [PATCH v8 8/8] selftests, arm64: add a selftest for passing tagged pointers to kernel Andrey Konovalov
2018-11-08 14:48 ` [PATCH v8 0/8] arm64: untag user pointers passed to the kernel Andrey Konovalov
2018-11-29 18:16 ` Catalin Marinas
2018-12-06 12:44 ` Andrey Konovalov
2018-12-06 14:08 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181129182446.GJ22027@arrakis.emea.arm.com \
--to=catalin.marinas@arm.com \
--cc=Jacob.Bramley@arm.com \
--cc=Lee.Smith@arm.com \
--cc=Ramana.Radhakrishnan@arm.com \
--cc=Ruben.Ayrapetyan@arm.com \
--cc=akpm@linux-foundation.org \
--cc=andreyknvl@google.com \
--cc=cpandya@codeaurora.org \
--cc=dvyukov@google.com \
--cc=eugenis@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=kcc@google.com \
--cc=keescook@chromium.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=kstewart@linuxfoundation.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luc.vanoostenryck@gmail.com \
--cc=mark.rutland@arm.com \
--cc=mingo@kernel.org \
--cc=robin.murphy@arm.com \
--cc=shuah@kernel.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).