From: Cyrill Gorcunov <email@example.com> To: Kirill Tkhai <firstname.lastname@example.org> Cc: email@example.com, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org, email@example.com Subject: Re: [PATCH] ksm: React on changing "sleep_millisecs" parameter faster Date: Tue, 11 Dec 2018 13:03:46 +0300 Message-ID: <20181211100346.GE2342@uranus.lan> (raw) In-Reply-To: <firstname.lastname@example.org> On Tue, Dec 11, 2018 at 12:23:11PM +0300, Kirill Tkhai wrote: ... > > Kirill, can we rather reuse @ksm_thread variable from ksm_init > > (by moving it to static file level variable). > > I've considered using it, but this is not looks good for me. > The problem is ksm thread may be parked, or it even may fail > to start. But at the same time, parallel writes to "sleep_millisecs" > are possible. There is a place for races, so to use the local > variable in ksm_init() (like we have at the moment) looks better > for me. At the patch the mutex protects against any races. > > > Also wakening up > > unconditionally on write looks somehow suspicious to me > > though I don't have a precise argument against. > > The conditional wait requires one more wait_queue. This is > the thing I tried to avoid. But. I also had doubts about > this, so you are already the second person, who worries :) > It looks like we really need to change this. > > How are you about something like the below? I see. The code below looks a way better for me, thanks!
prev parent reply index Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-12-10 16:06 Kirill Tkhai 2018-12-10 20:10 ` Cyrill Gorcunov 2018-12-11 9:23 ` Kirill Tkhai 2018-12-11 10:03 ` Cyrill Gorcunov [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20181211100346.GE2342@uranus.lan \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-mm Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-mm/0 linux-mm/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-mm linux-mm/ https://lore.kernel.org/linux-mm \ firstname.lastname@example.org public-inbox-index linux-mm Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kvack.linux-mm AGPL code for this site: git clone https://public-inbox.org/public-inbox.git