From: Michal Hocko <mhocko@kernel.org>
To: Roman Penyaev <rpenyaev@suse.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Andrey Ryabinin <aryabinin@virtuozzo.com>,
Joe Perches <joe@perches.com>,
"Luis R. Rodriguez" <mcgrof@kernel.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] mm/vmalloc: pass VM_USERMAP flags directly to __vmalloc_node_range()
Date: Thu, 3 Jan 2019 16:23:48 +0100 [thread overview]
Message-ID: <20190103152348.GS31793@dhcp22.suse.cz> (raw)
In-Reply-To: <20190103145954.16942-4-rpenyaev@suse.de>
On Thu 03-01-19 15:59:54, Roman Penyaev wrote:
> vmalloc_user*() calls differ from normal vmalloc() only in that they
> set VM_USERMAP flags for the area. During the whole history of
> vmalloc.c changes now it is possible simply to pass VM_USERMAP flags
> directly to __vmalloc_node_range() call instead of finding the area
> (which obviously takes time) after the allocation.
Yes, this looks correct and a nice cleanup
> Signed-off-by: Roman Penyaev <rpenyaev@suse.de>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Michal Hocko <mhocko@suse.com>
> Cc: Andrey Ryabinin <aryabinin@virtuozzo.com>
> Cc: Joe Perches <joe@perches.com>
> Cc: "Luis R. Rodriguez" <mcgrof@kernel.org>
> Cc: linux-mm@kvack.org
> Cc: linux-kernel@vger.kernel.org
Acked-by: Michal Hocko <mhocko@suse.com>
> ---
> mm/vmalloc.c | 30 ++++++++----------------------
> 1 file changed, 8 insertions(+), 22 deletions(-)
>
> diff --git a/mm/vmalloc.c b/mm/vmalloc.c
> index dc6a62bca503..83fa4c642f5e 100644
> --- a/mm/vmalloc.c
> +++ b/mm/vmalloc.c
> @@ -1865,18 +1865,10 @@ EXPORT_SYMBOL(vzalloc);
> */
> void *vmalloc_user(unsigned long size)
> {
> - struct vm_struct *area;
> - void *ret;
> -
> - ret = __vmalloc_node(size, SHMLBA,
> - GFP_KERNEL | __GFP_ZERO,
> - PAGE_KERNEL, NUMA_NO_NODE,
> - __builtin_return_address(0));
> - if (ret) {
> - area = find_vm_area(ret);
> - area->flags |= VM_USERMAP;
> - }
> - return ret;
> + return __vmalloc_node_range(size, SHMLBA, VMALLOC_START, VMALLOC_END,
> + GFP_KERNEL | __GFP_ZERO, PAGE_KERNEL,
> + VM_USERMAP, NUMA_NO_NODE,
> + __builtin_return_address(0));
> }
> EXPORT_SYMBOL(vmalloc_user);
>
> @@ -1970,16 +1962,10 @@ EXPORT_SYMBOL(vmalloc_32);
> */
> void *vmalloc_32_user(unsigned long size)
> {
> - struct vm_struct *area;
> - void *ret;
> -
> - ret = __vmalloc_node(size, 1, GFP_VMALLOC32 | __GFP_ZERO, PAGE_KERNEL,
> - NUMA_NO_NODE, __builtin_return_address(0));
> - if (ret) {
> - area = find_vm_area(ret);
> - area->flags |= VM_USERMAP;
> - }
> - return ret;
> + return __vmalloc_node_range(size, 1, VMALLOC_START, VMALLOC_END,
> + GFP_VMALLOC32 | __GFP_ZERO, PAGE_KERNEL,
> + VM_USERMAP, NUMA_NO_NODE,
> + __builtin_return_address(0));
> }
> EXPORT_SYMBOL(vmalloc_32_user);
>
> --
> 2.19.1
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2019-01-03 15:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-03 14:59 [PATCH 0/3] mm/vmalloc: fix size check and few cleanups Roman Penyaev
2019-01-03 14:59 ` [PATCH 1/3] mm/vmalloc: fix size check for remap_vmalloc_range_partial() Roman Penyaev
2019-01-03 15:13 ` Michal Hocko
2019-01-03 19:27 ` Roman Penyaev
2019-01-03 19:40 ` Michal Hocko
2019-01-03 20:31 ` Roman Penyaev
2019-01-04 9:38 ` Michal Hocko
2019-01-04 10:21 ` Roman Penyaev
2019-01-04 10:28 ` Michal Hocko
2019-01-03 19:59 ` Michal Hocko
2019-01-04 11:06 ` Roman Penyaev
2019-01-11 19:19 ` Andrey Ryabinin
2019-01-03 14:59 ` [PATCH 2/3] mm/vmalloc: do not call kmemleak_free() on not yet accounted memory Roman Penyaev
2019-01-11 19:26 ` Andrey Ryabinin
2019-01-12 17:19 ` Roman Penyaev
2019-01-03 14:59 ` [PATCH 3/3] mm/vmalloc: pass VM_USERMAP flags directly to __vmalloc_node_range() Roman Penyaev
2019-01-03 15:23 ` Michal Hocko [this message]
2019-01-11 19:19 ` Andrey Ryabinin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190103152348.GS31793@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=aryabinin@virtuozzo.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mcgrof@kernel.org \
--cc=rpenyaev@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).