From: Michal Hocko <mhocko@kernel.org>
To: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>,
David Rientjes <rientjes@google.com>,
linux-mm@kvack.org, Kirill Tkhai <ktkhai@virtuozzo.com>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] memcg: killed threads should not invoke memcg OOM killer
Date: Mon, 7 Jan 2019 14:37:20 +0100 [thread overview]
Message-ID: <20190107133720.GH31793@dhcp22.suse.cz> (raw)
In-Reply-To: <b0c4748e-f024-4d5c-a233-63c269660004@i-love.sakura.ne.jp>
On Mon 07-01-19 22:07:43, Tetsuo Handa wrote:
> On 2019/01/07 20:41, Michal Hocko wrote:
> > On Sun 06-01-19 15:02:24, Tetsuo Handa wrote:
> >> Michal and Johannes, can we please stop this stupid behavior now?
> >
> > I have proposed a patch with a much more limited scope which is still
> > waiting for feedback. I haven't heard it wouldn't be working so far.
> >
>
> You mean
>
> mutex_lock_killable would take care of exiting task already. I would
> then still prefer to check for mark_oom_victim because that is not racy
> with the exit path clearing signals. I can update my patch to use
> _killable lock variant if we are really going with the memcg specific
> fix.
>
> ? No response for two months.
I mean http://lkml.kernel.org/r/20181022071323.9550-1-mhocko@kernel.org
which has died in nit picking. I am not very interested to go back there
and spend a lot of time with it again. If you do not respect my opinion
as the maintainer of this code then find somebody else to push it
through.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2019-01-07 13:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-26 10:13 [PATCH] memcg: killed threads should not invoke memcg OOM killer Tetsuo Handa
2018-12-28 10:22 ` Kirill Tkhai
2018-12-28 11:00 ` Tetsuo Handa
2018-12-28 11:28 ` Kirill Tkhai
2019-01-06 6:02 ` Tetsuo Handa
2019-01-06 6:02 ` Tetsuo Handa
2019-01-07 11:41 ` Michal Hocko
2019-01-07 13:07 ` Tetsuo Handa
2019-01-07 13:37 ` Michal Hocko [this message]
2019-01-07 14:20 ` Tetsuo Handa
2019-01-09 10:56 ` Tetsuo Handa
2019-01-09 10:56 ` Tetsuo Handa
2019-01-15 10:17 ` [PATCH v2] " Tetsuo Handa
2019-01-15 11:55 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190107133720.GH31793@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=ktkhai@virtuozzo.com \
--cc=linux-mm@kvack.org \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=rientjes@google.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).