From: Ira Weiny <ira.weiny@intel.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
John Hubbard <jhubbard@nvidia.com>,
Michal Hocko <mhocko@suse.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Jason Gunthorpe <jgg@ziepe.ca>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
"David S. Miller" <davem@davemloft.net>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Rich Felker <dalias@libc.org>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Ralf Baechle <ralf@linux-mips.org>,
James Hogan <jhogan@kernel.org>, linux-mm <linux-mm@kvack.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-mips@vger.kernel.org,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
linux-s390 <linux-s390@vger.kernel.org>,
Linux-sh <linux-sh@vger.kernel.org>,
sparclinux@vger.kernel.org, linux-rdma@vger.kernel.org,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [RESEND 3/7] mm/gup: Change GUP fast to use flags rather than a write 'bool'
Date: Mon, 25 Mar 2019 01:26:20 -0700 [thread overview]
Message-ID: <20190325082620.GB16366@iweiny-DESK2.sc.intel.com> (raw)
In-Reply-To: <CAA9_cmd9gUWMbpkP_AuxZ08iqvZdxjbtDoR-FpSjAyhZJisRZA@mail.gmail.com>
On Fri, Mar 22, 2019 at 03:05:53PM -0700, Dan Williams wrote:
> On Sun, Mar 17, 2019 at 7:36 PM <ira.weiny@intel.com> wrote:
> >
> > From: Ira Weiny <ira.weiny@intel.com>
> >
> > To facilitate additional options to get_user_pages_fast() change the
> > singular write parameter to be gup_flags.
> >
> > This patch does not change any functionality. New functionality will
> > follow in subsequent patches.
> >
> > Some of the get_user_pages_fast() call sites were unchanged because they
> > already passed FOLL_WRITE or 0 for the write parameter.
> >
> > Signed-off-by: Ira Weiny <ira.weiny@intel.com>
> >
> > ---
> > Changes from V1:
> > Rebase to current merge tree
> > arch/powerpc/mm/mmu_context_iommu.c no longer calls gup_fast
> > The gup_longterm was converted in patch 1
> >
> > arch/mips/mm/gup.c | 11 ++++++-----
> > arch/powerpc/kvm/book3s_64_mmu_hv.c | 4 ++--
> > arch/powerpc/kvm/e500_mmu.c | 2 +-
> > arch/s390/kvm/interrupt.c | 2 +-
> > arch/s390/mm/gup.c | 12 ++++++------
> > arch/sh/mm/gup.c | 11 ++++++-----
> > arch/sparc/mm/gup.c | 9 +++++----
> > arch/x86/kvm/paging_tmpl.h | 2 +-
> > arch/x86/kvm/svm.c | 2 +-
> > drivers/fpga/dfl-afu-dma-region.c | 2 +-
> > drivers/gpu/drm/via/via_dmablit.c | 3 ++-
> > drivers/infiniband/hw/hfi1/user_pages.c | 3 ++-
> > drivers/misc/genwqe/card_utils.c | 2 +-
> > drivers/misc/vmw_vmci/vmci_host.c | 2 +-
> > drivers/misc/vmw_vmci/vmci_queue_pair.c | 6 ++++--
> > drivers/platform/goldfish/goldfish_pipe.c | 3 ++-
> > drivers/rapidio/devices/rio_mport_cdev.c | 4 +++-
> > drivers/sbus/char/oradax.c | 2 +-
> > drivers/scsi/st.c | 3 ++-
> > drivers/staging/gasket/gasket_page_table.c | 4 ++--
> > drivers/tee/tee_shm.c | 2 +-
> > drivers/vfio/vfio_iommu_spapr_tce.c | 3 ++-
> > drivers/vhost/vhost.c | 2 +-
> > drivers/video/fbdev/pvr2fb.c | 2 +-
> > drivers/virt/fsl_hypervisor.c | 2 +-
> > drivers/xen/gntdev.c | 2 +-
> > fs/orangefs/orangefs-bufmap.c | 2 +-
> > include/linux/mm.h | 4 ++--
> > kernel/futex.c | 2 +-
> > lib/iov_iter.c | 7 +++++--
> > mm/gup.c | 10 +++++-----
> > mm/util.c | 8 ++++----
> > net/ceph/pagevec.c | 2 +-
> > net/rds/info.c | 2 +-
> > net/rds/rdma.c | 3 ++-
> > 35 files changed, 79 insertions(+), 63 deletions(-)
>
>
> >
> > diff --git a/arch/mips/mm/gup.c b/arch/mips/mm/gup.c
> > index 0d14e0d8eacf..4c2b4483683c 100644
> > --- a/arch/mips/mm/gup.c
> > +++ b/arch/mips/mm/gup.c
> > @@ -235,7 +235,7 @@ int __get_user_pages_fast(unsigned long start, int nr_pages, int write,
> > * get_user_pages_fast() - pin user pages in memory
> > * @start: starting user address
> > * @nr_pages: number of pages from start to pin
> > - * @write: whether pages will be written to
> > + * @gup_flags: flags modifying pin behaviour
> > * @pages: array that receives pointers to the pages pinned.
> > * Should be at least nr_pages long.
> > *
> > @@ -247,8 +247,8 @@ int __get_user_pages_fast(unsigned long start, int nr_pages, int write,
> > * requested. If nr_pages is 0 or negative, returns 0. If no pages
> > * were pinned, returns -errno.
> > */
> > -int get_user_pages_fast(unsigned long start, int nr_pages, int write,
> > - struct page **pages)
> > +int get_user_pages_fast(unsigned long start, int nr_pages,
> > + unsigned int gup_flags, struct page **pages)
>
> This looks a tad scary given all related thrash especially when it's
> only 1 user that wants to do get_user_page_fast_longterm, right?
Agreed but the discussion back in Feb agreed that it would be better to make
get_user_pages_fast() use flags rather than add another *_longterm call, and I
agree.
> Maybe
> something like the following. Note I explicitly moved the flags to the
> end so that someone half paying attention that calls
> __get_user_pages_fast will get a compile error if they specify the
> args in the same order.
I did this to remain consistent with the other public calls. They put the
"return" pages parameter at the end. For example get_user_pages() is defined
this way with pages and vmas at the end.
long get_user_pages(unsigned long start, unsigned long nr_pages,
unsigned int gup_flags, struct page **pages,
struct vm_area_struct **vmas)
I'm pretty sure I got all the callers. Is this worth making the signature
"non-standard" WRT the other calls?
Ira
>
> diff --git a/include/linux/mm.h b/include/linux/mm.h
> index 76ba638ceda8..c6c743bc2c68 100644
> --- a/include/linux/mm.h
> +++ b/include/linux/mm.h
> @@ -1505,8 +1505,15 @@ static inline long
> get_user_pages_longterm(unsigned long start,
> }
> #endif /* CONFIG_FS_DAX */
>
> -int get_user_pages_fast(unsigned long start, int nr_pages, int write,
> - struct page **pages);
> +
> +int __get_user_pages_fast(unsigned long start, int nr_pages,
> + struct page **pages, unsigned int gup_flags);
> +
> +static inline int get_user_pages_fast(unsigned long start, int
> nr_pages, int write,
> + struct page **pages)
> +{
> + return __get_user_pages_fast(start, nr_pages, pages, write ?
> FOLL_WRITE);
> +}
>
> /* Container for pinned pfns / pages */
> struct frame_vector {
>
next prev parent reply other threads:[~2019-03-25 16:27 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-17 18:34 [RESEND PATCH 0/7] Add FOLL_LONGTERM to GUP fast and use it ira.weiny
2019-03-17 18:34 ` [RESEND 1/7] mm/gup: Replace get_user_pages_longterm() with FOLL_LONGTERM ira.weiny
2019-03-22 21:24 ` Dan Williams
2019-03-25 6:19 ` Ira Weiny
2019-03-25 16:45 ` Dan Williams
2019-03-25 8:46 ` Ira Weiny
2019-03-25 10:27 ` Ira Weiny
2019-03-17 18:34 ` [RESEND 2/7] mm/gup: Change write parameter to flags in fast walk ira.weiny
2019-03-22 21:30 ` Dan Williams
2019-03-17 18:34 ` [RESEND 3/7] mm/gup: Change GUP fast to use flags rather than a write 'bool' ira.weiny
2019-03-22 22:05 ` Dan Williams
2019-03-25 8:26 ` Ira Weiny [this message]
2019-03-17 18:34 ` [RESEND 4/7] mm/gup: Add FOLL_LONGTERM capability to GUP fast ira.weiny
2019-03-22 22:12 ` Dan Williams
2019-03-25 8:42 ` Ira Weiny
2019-03-25 16:47 ` Jason Gunthorpe
2019-03-25 9:23 ` Ira Weiny
2019-03-25 17:51 ` Jason Gunthorpe
2019-03-25 14:21 ` Ira Weiny
2019-03-25 22:36 ` Dan Williams
2019-03-25 14:54 ` Ira Weiny
2019-03-17 18:34 ` [RESEND 5/7] IB/hfi1: Use the new FOLL_LONGTERM flag to get_user_pages_fast() ira.weiny
2019-03-22 22:14 ` Dan Williams
2019-03-25 8:43 ` Ira Weiny
2019-03-17 18:34 ` [RESEND 6/7] IB/qib: " ira.weiny
2019-03-22 22:15 ` Dan Williams
2019-03-17 18:34 ` [RESEND 7/7] IB/mthca: " ira.weiny
2019-03-19 22:19 ` [RESEND PATCH 0/7] Add FOLL_LONGTERM to GUP fast and use it Andrew Morton
2019-03-21 8:40 ` Ira Weiny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190325082620.GB16366@iweiny-DESK2.sc.intel.com \
--to=ira.weiny@intel.com \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=bp@alien8.de \
--cc=dalias@libc.org \
--cc=dan.j.williams@intel.com \
--cc=davem@davemloft.net \
--cc=heiko.carstens@de.ibm.com \
--cc=jgg@ziepe.ca \
--cc=jhogan@kernel.org \
--cc=jhubbard@nvidia.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mhocko@suse.com \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=ralf@linux-mips.org \
--cc=schwidefsky@de.ibm.com \
--cc=sparclinux@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).