From: Andrew Morton <akpm@linux-foundation.org>
To: Jan Kara <jack@suse.cz>
Cc: Linux MM <linux-mm@kvack.org>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>,
Chandan Rajendra <chandan@linux.ibm.com>,
stable <stable@vger.kernel.org>,
Dan Williams <dan.j.williams@intel.com>
Subject: Re: [PATCH] mm: Fix modifying of page protection by insert_pfn()
Date: Wed, 27 Mar 2019 14:14:14 -0700 [thread overview]
Message-ID: <20190327141414.ad663db479afa8694ed270c6@linux-foundation.org> (raw)
In-Reply-To: <20190327173332.GA15475@quack2.suse.cz>
On Wed, 27 Mar 2019 18:33:32 +0100 Jan Kara <jack@suse.cz> wrote:
> On Mon 11-03-19 10:22:44, Dan Williams wrote:
> > On Mon, Mar 11, 2019 at 1:45 AM Jan Kara <jack@suse.cz> wrote:
> > >
> > > Aneesh has reported that PPC triggers the following warning when
> > > excercising DAX code:
> > >
> > > [c00000000007610c] set_pte_at+0x3c/0x190
> > > LR [c000000000378628] insert_pfn+0x208/0x280
> > > Call Trace:
> > > [c0000002125df980] [8000000000000104] 0x8000000000000104 (unreliable)
> > > [c0000002125df9c0] [c000000000378488] insert_pfn+0x68/0x280
> > > [c0000002125dfa30] [c0000000004a5494] dax_iomap_pte_fault.isra.7+0x734/0xa40
> > > [c0000002125dfb50] [c000000000627250] __xfs_filemap_fault+0x280/0x2d0
> > > [c0000002125dfbb0] [c000000000373abc] do_wp_page+0x48c/0xa40
> > > [c0000002125dfc00] [c000000000379170] __handle_mm_fault+0x8d0/0x1fd0
> > > [c0000002125dfd00] [c00000000037a9b0] handle_mm_fault+0x140/0x250
> > > [c0000002125dfd40] [c000000000074bb0] __do_page_fault+0x300/0xd60
> > > [c0000002125dfe20] [c00000000000acf4] handle_page_fault+0x18
> > >
> > > Now that is WARN_ON in set_pte_at which is
> > >
> > > VM_WARN_ON(pte_hw_valid(*ptep) && !pte_protnone(*ptep));
> > >
> > > The problem is that on some architectures set_pte_at() cannot cope with
> > > a situation where there is already some (different) valid entry present.
> > >
> > > Use ptep_set_access_flags() instead to modify the pfn which is built to
> > > deal with modifying existing PTE.
> > >
> > > CC: stable@vger.kernel.org
> > > Fixes: b2770da64254 "mm: add vm_insert_mixed_mkwrite()"
> > > Reported-by: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>
> > > Signed-off-by: Jan Kara <jack@suse.cz>
> >
> > Acked-by: Dan Williams <dan.j.williams@intel.com>
> >
> > Andrew, can you pick this up?
>
> Andrew, ping?
I merged this a couple of weeks ago and it's in the queue for 5.1.
next prev parent reply other threads:[~2019-03-27 21:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-11 8:45 [PATCH] mm: Fix modifying of page protection by insert_pfn() Jan Kara
2019-03-11 11:59 ` Aneesh Kumar K.V
2019-03-11 17:22 ` Dan Williams
2019-03-27 17:33 ` Jan Kara
2019-03-27 21:14 ` Andrew Morton [this message]
2019-03-28 3:18 ` Aneesh Kumar K.V
2019-03-28 9:02 ` Jan Kara
2019-03-28 9:02 ` Jan Kara
2019-03-25 0:38 ` Sasha Levin
2019-03-25 17:02 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190327141414.ad663db479afa8694ed270c6@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.ibm.com \
--cc=chandan@linux.ibm.com \
--cc=dan.j.williams@intel.com \
--cc=jack@suse.cz \
--cc=linux-mm@kvack.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).