From: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
To: Mike Kravetz <mike.kravetz@oracle.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
Davidlohr Bueso <dave@stgolabs.net>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Michal Hocko <mhocko@kernel.org>,
"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v2 0/2] A couple hugetlbfs fixes
Date: Wed, 3 Apr 2019 05:29:12 +0000 [thread overview]
Message-ID: <20190403052913.GA10888@hori.linux.bs1.fc.nec.co.jp> (raw)
In-Reply-To: <20190328234704.27083-1-mike.kravetz@oracle.com>
On Thu, Mar 28, 2019 at 04:47:02PM -0700, Mike Kravetz wrote:
> I stumbled on these two hugetlbfs issues while looking at other things:
> - The 'restore reserve' functionality at page free time should not
> be adjusting subpool counts.
> - A BUG can be triggered (not easily) due to temporarily mapping a
> page before doing a COW.
>
> Both are described in detail in the commit message of the patches.
> I would appreciate comments from Davidlohr Bueso as one patch is
> directly related to code he added in commit 8382d914ebf7.
>
> I did not cc stable as the first problem has been around since reserves
> were added to hugetlbfs and nobody has noticed. The second is very hard
> to hit/reproduce.
>
> v2 - Update definition and all callers of hugetlb_fault_mutex_hash as
> the arguments mm and vma are no longer used or necessary.
>
> Mike Kravetz (2):
> huegtlbfs: on restore reserve error path retain subpool reservation
> hugetlb: use same fault hash key for shared and private mappings
>
> fs/hugetlbfs/inode.c | 7 ++-----
> include/linux/hugetlb.h | 4 +---
> mm/hugetlb.c | 43 +++++++++++++++++++++--------------------
> mm/userfaultfd.c | 3 +--
> 4 files changed, 26 insertions(+), 31 deletions(-)
Both fixes look fine to me.
Reviewed-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
next prev parent reply other threads:[~2019-04-03 5:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-28 23:47 [PATCH v2 0/2] A couple hugetlbfs fixes Mike Kravetz
2019-03-28 23:47 ` [PATCH v2 1/2] huegtlbfs: on restore reserve error path retain subpool reservation Mike Kravetz
2019-03-28 23:47 ` [PATCH v2 2/2] hugetlb: use same fault hash key for shared and private mappings Mike Kravetz
2019-04-11 18:32 ` Mike Kravetz
2019-04-12 16:52 ` Davidlohr Bueso
2019-04-03 5:29 ` Naoya Horiguchi [this message]
2019-04-08 19:48 ` [PATCH v2 0/2] A couple hugetlbfs fixes Davidlohr Bueso
2019-04-09 3:30 ` Mike Kravetz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190403052913.GA10888@hori.linux.bs1.fc.nec.co.jp \
--to=n-horiguchi@ah.jp.nec.com \
--cc=akpm@linux-foundation.org \
--cc=dave@stgolabs.net \
--cc=iamjoonsoo.kim@lge.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=mike.kravetz@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).