From: Mike Rapoport <rppt@linux.ibm.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Mel Gorman <mgorman@techsingularity.net>,
Matthew Wilcox <willy@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>,
Mikulas Patocka <mpatocka@redhat.com>,
James Bottomley <James.Bottomley@hansenpartnership.com>,
linux-parisc@vger.kernel.org, linux-mm@kvack.org,
Vlastimil Babka <vbabka@suse.cz>,
LKML <linux-kernel@vger.kernel.org>,
linux-arch@vger.kernel.org
Subject: Re: DISCONTIGMEM is deprecated
Date: Wed, 24 Apr 2019 14:33:53 +0300 [thread overview]
Message-ID: <20190424113352.GA6278@rapoport-lnx> (raw)
In-Reply-To: <20190423071354.GB12114@infradead.org>
On Tue, Apr 23, 2019 at 12:13:54AM -0700, Christoph Hellwig wrote:
> On Sun, Apr 21, 2019 at 10:16:04PM +0100, Mel Gorman wrote:
> > 32-bit NUMA systems should be non-existent in practice. The last NUMA
> > system I'm aware of that was both NUMA and 32-bit only died somewhere
> > between 2004 and 2007. If someone is running a 64-bit capable system in
> > 32-bit mode with NUMA, they really are just punishing themselves for fun.
>
> Can we mark it as BROKEN to see if someone shouts and then remove it
> a year or two down the road? Or just kill it off now..
How about making SPARSEMEM default for x86-32?
From ac2dc27414e26f799ea063fd1d01e19d70056f43 Mon Sep 17 00:00:00 2001
From: Mike Rapoport <rppt@linux.ibm.com>
Date: Wed, 24 Apr 2019 14:32:12 +0300
Subject: [PATCH] x86/Kconfig: make SPARSEMEM default for X86_32
Signed-off-by: Mike Rapoport <rppt@linux.ibm.com>
---
arch/x86/Kconfig | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index 62fc3fd..77b17af 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -1609,10 +1609,6 @@ config ARCH_DISCONTIGMEM_ENABLE
def_bool y
depends on NUMA && X86_32
-config ARCH_DISCONTIGMEM_DEFAULT
- def_bool y
- depends on NUMA && X86_32
-
config ARCH_SPARSEMEM_ENABLE
def_bool y
depends on X86_64 || NUMA || X86_32 || X86_32_NON_STANDARD
@@ -1621,7 +1617,7 @@ config ARCH_SPARSEMEM_ENABLE
config ARCH_SPARSEMEM_DEFAULT
def_bool y
- depends on X86_64
+ depends on X86_64 || (NUMA && X86_32)
config ARCH_SELECT_MEMORY_MODEL
def_bool y
--
2.7.4
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2019-04-24 11:34 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-19 9:43 [PATCH] mm: Do not boost watermarks to avoid fragmentation for the DISCONTIG memory model Mel Gorman
2019-04-19 14:05 ` DISCONTIGMEM is deprecated Matthew Wilcox
2019-04-19 14:28 ` Mel Gorman
2019-04-19 20:08 ` Helge Deller
2019-05-05 8:53 ` Mike Rapoport
2019-04-21 6:38 ` Mike Rapoport
2019-04-21 13:26 ` Matthew Wilcox
2019-04-21 21:16 ` Mel Gorman
2019-04-23 7:13 ` Christoph Hellwig
2019-04-24 11:33 ` Mike Rapoport [this message]
2019-04-24 12:21 ` Mel Gorman
2019-04-28 8:11 ` Christoph Hellwig
2019-05-01 20:46 ` Mike Rapoport
2019-04-22 17:29 ` Christopher Lameter
2019-04-23 16:49 ` Meelis Roos
2019-04-28 8:13 ` Christoph Hellwig
2019-04-29 16:58 ` Luck, Tony
2019-04-29 20:09 ` Christoph Hellwig
2019-04-30 13:40 ` Christopher Lameter
2019-04-23 6:33 ` [PATCH] mm: Do not boost watermarks to avoid fragmentation for the DISCONTIG memory model Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190424113352.GA6278@rapoport-lnx \
--to=rppt@linux.ibm.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=akpm@linux-foundation.org \
--cc=hch@infradead.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-parisc@vger.kernel.org \
--cc=mgorman@techsingularity.net \
--cc=mpatocka@redhat.com \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).