From: Will Deacon <will.deacon@arm.com>
To: Anshuman Khandual <anshuman.khandual@arm.com>
Cc: linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org,
Toshi Kani <toshi.kani@hpe.com>,
Andrew Morton <akpm@linux-foundation.org>,
Chintan Pandya <cpandya@codeaurora.org>,
Thomas Gleixner <tglx@linutronix.de>,
Catalin Marinas <catalin.marinas@arm.com>
Subject: Re: [PATCH V4] mm/ioremap: Check virtual address alignment while creating huge mappings
Date: Wed, 15 May 2019 10:46:55 +0100 [thread overview]
Message-ID: <20190515094655.GB24357@fuggles.cambridge.arm.com> (raw)
In-Reply-To: <1557887716-17918-1-git-send-email-anshuman.khandual@arm.com>
On Wed, May 15, 2019 at 08:05:16AM +0530, Anshuman Khandual wrote:
> Virtual address alignment is essential in ensuring correct clearing for all
> intermediate level pgtable entries and freeing associated pgtable pages. An
> unaligned address can end up randomly freeing pgtable page that potentially
> still contains valid mappings. Hence also check it's alignment along with
> existing phys_addr check.
>
> Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>
> Cc: Toshi Kani <toshi.kani@hpe.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Will Deacon <will.deacon@arm.com>
> Cc: Chintan Pandya <cpandya@codeaurora.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> ---
> Changes in V4:
>
> - Added similar check for ioremap_try_huge_p4d() as per Toshi Kani
Sorry to be a pain, but in future please can you just resend the entire
series as a v4 (after giving it a few days for any other comments to come
in) if you make an update? It's a bit fiddly tracking which replies to which
individual patches need to be picked up, although I'm sure this varies
between maintainers.
No need to do anything this time, but just a small ask for future patches.
Will
next prev parent reply other threads:[~2019-05-15 9:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-09 4:46 [PATCH V3 0/2] mm/ioremap: Check virtual address alignment Anshuman Khandual
2019-05-09 4:46 ` [PATCH V3 1/2] mm/ioremap: Check virtual address alignment while creating huge mappings Anshuman Khandual
2019-05-13 22:26 ` Kani, Toshi
2019-05-14 5:55 ` Anshuman Khandual
2019-05-15 2:35 ` [PATCH V4] " Anshuman Khandual
2019-05-15 9:46 ` Will Deacon [this message]
2019-05-15 10:10 ` Anshuman Khandual
2019-05-16 18:38 ` Kani, Toshi
2019-06-06 13:51 ` Catalin Marinas
2019-05-09 4:46 ` [PATCH V3 2/2] arm64/mm: Change offset base address in [pud|pmd]_free_[pmd|pte]_page() Anshuman Khandual
2019-06-03 15:36 ` Catalin Marinas
2019-06-06 8:08 ` Anshuman Khandual
2019-06-04 14:24 ` Catalin Marinas
2019-06-06 4:44 ` Anshuman Khandual
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190515094655.GB24357@fuggles.cambridge.arm.com \
--to=will.deacon@arm.com \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=catalin.marinas@arm.com \
--cc=cpandya@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mm@kvack.org \
--cc=tglx@linutronix.de \
--cc=toshi.kani@hpe.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).