From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 417CDC04E53 for ; Wed, 15 May 2019 17:18:25 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E5C2D2089E for ; Wed, 15 May 2019 17:18:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=fb.com header.i=@fb.com header.b="M+r7TUT7"; dkim=pass (1024-bit key) header.d=fb.onmicrosoft.com header.i=@fb.onmicrosoft.com header.b="gBmRNMh/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E5C2D2089E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=fb.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7C8276B0006; Wed, 15 May 2019 13:18:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7785F6B0007; Wed, 15 May 2019 13:18:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 619706B0008; Wed, 15 May 2019 13:18:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from mail-it1-f199.google.com (mail-it1-f199.google.com [209.85.166.199]) by kanga.kvack.org (Postfix) with ESMTP id 409276B0006 for ; Wed, 15 May 2019 13:18:24 -0400 (EDT) Received: by mail-it1-f199.google.com with SMTP id u10so679577itb.5 for ; Wed, 15 May 2019 10:18:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:dkim-signature:dkim-signature:from:to:cc:subject :thread-topic:thread-index:date:message-id:references:in-reply-to :accept-language:content-language:content-id :content-transfer-encoding:mime-version; bh=M+HeQUN9gzaGB+aAqkdYsyx1NRhGEPa8nOV7GMToD1w=; b=L+ROsaQPNneqNbl6Edcmp24rQFnOX9QGwgecKKFvX+bBMm+zNA9D16qxO0TYdT9iK9 C5TG2uPAYw4xZPiYPvZs6Fy3cJzkhkvhioR/92/U9nOInDmPKlc8QU0r22Z11LVVrgJk nv7et5d1WNjJmPu/D9EeHb+ExMn0rcNr7zsMOjNOC96tBI8jJzRaVGT+4TLWRNB0xjiS NhWTuoR6bfBa6yXPQDBd/t6sI3kO4BKXCCJ/Y7LOYEyj3zKMplHItqLhFxPuHgolVBn9 ORYwqta9bxnIXijxHDxqy/WSdWuxsndjLPsAR5SH4f52AlcNIaAaDnvNk/2wYPacnwUu 29Lg== X-Gm-Message-State: APjAAAXcKEfArfyTIvp94/rElDHYFjmnGNZ2XYIwbCS3Yl4S0o8ul4x2 6OmaGSa6MmFGdA5vxqqYMYOamrJHMz0jzLyxucjtCoJplsmgE9P+YhWIOIfB7BmL1ZYXhXjVv4E Wo1J8HgnD1DwPH2o4Sp8Fn9sSAZOy2HiZJCRMAW/HBj2Y9KmNw7T3EHHobN9FmuLvtQ== X-Received: by 2002:a6b:7008:: with SMTP id l8mr23854885ioc.210.1557940703984; Wed, 15 May 2019 10:18:23 -0700 (PDT) X-Google-Smtp-Source: APXvYqyFInEiOZK/v6u43uYU5y4zHX606qoXfVODGBwD7xbt2g4wU/YQ+BCXqJRMeUZ0lrs5Evwu X-Received: by 2002:a6b:7008:: with SMTP id l8mr23854819ioc.210.1557940703021; Wed, 15 May 2019 10:18:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557940703; cv=none; d=google.com; s=arc-20160816; b=x/xmOzvNYF8duIW4e/4z4rUh3xEQ/Er3ck5qfS9pgw9DuLhqil++hqUsbp+TcdtIDF /57Y4t9xjNpGI2D90RsnEHztleyZz6cc6o5+9qQfjiyk+w5so+VATSVZ5GNX4S/tAAuW JwHMrrFro9ym2YGyjgLXR/Du78b5mbYdBUq5yXxbhe1xRMD+tVcsa2anydQ8EzuCET2/ DJClkuv/LsBM0SFXKm5yuKSP8MeWUUg98nu4u0AQwl0I0/2x19aIBFZwE52JLlClqSLV 74t9BH7KtjryADTfUjhLl9o77iVjAWZW+O73zfU89DpEOE23jV9WmxYmGAt/DqnE8UyK TMeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:content-id:content-language :accept-language:in-reply-to:references:message-id:date:thread-index :thread-topic:subject:cc:to:from:dkim-signature:dkim-signature; bh=M+HeQUN9gzaGB+aAqkdYsyx1NRhGEPa8nOV7GMToD1w=; b=BxCmUhEmM/thYoi5ZfEecVrvGl6s62N8+A3ajBQhmOe44qe+bNPh7V1pKFTSZojmNE QodlQtzwQnkA1XPHgKfcNa//IrvfBAbOBmDaeXmiXRv/7wvYrGhYcWtG78CZd1PUjK1i z9j8N1EINy/g0unB+XnyW1XUR/7ltcmDLjwttY7RaGw3SO5U/jtCruiK3h6rJAi9xqah 7uxvXX/o5nmDcjJTx8oRYx1UhYGdDAk79zNtAYGM+XJdMdeZBByNsblddqgiGJkyAfVu 1z0VXJwgvTnLDZplWBtaGENv1gSXnV1KQiAAK0eCxkHjRxg2jSQCz0XceHzFi7/jXyC1 cLRA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@fb.com header.s=facebook header.b=M+r7TUT7; dkim=pass header.i=@fb.onmicrosoft.com header.s=selector1-fb-onmicrosoft-com header.b="gBmRNMh/"; spf=pass (google.com: domain of prvs=0038d347e3=guro@fb.com designates 67.231.145.42 as permitted sender) smtp.mailfrom="prvs=0038d347e3=guro@fb.com"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=fb.com Received: from mx0a-00082601.pphosted.com (mx0a-00082601.pphosted.com. [67.231.145.42]) by mx.google.com with ESMTPS id p187si1772990itc.116.2019.05.15.10.18.22 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 15 May 2019 10:18:23 -0700 (PDT) Received-SPF: pass (google.com: domain of prvs=0038d347e3=guro@fb.com designates 67.231.145.42 as permitted sender) client-ip=67.231.145.42; Authentication-Results: mx.google.com; dkim=pass header.i=@fb.com header.s=facebook header.b=M+r7TUT7; dkim=pass header.i=@fb.onmicrosoft.com header.s=selector1-fb-onmicrosoft-com header.b="gBmRNMh/"; spf=pass (google.com: domain of prvs=0038d347e3=guro@fb.com designates 67.231.145.42 as permitted sender) smtp.mailfrom="prvs=0038d347e3=guro@fb.com"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=fb.com Received: from pps.filterd (m0044012.ppops.net [127.0.0.1]) by mx0a-00082601.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x4FHHqFe013433; Wed, 15 May 2019 10:18:11 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-id : content-transfer-encoding : mime-version; s=facebook; bh=M+HeQUN9gzaGB+aAqkdYsyx1NRhGEPa8nOV7GMToD1w=; b=M+r7TUT7f6CMSSlhHCLXLIYiF6S5zql9i9h1fA/wYXXKzi2qYmFJvokLjslyIpFWRiQ8 DNvpN689BXiCTKvgQB94axyfJWzoiQtO56FdD3v0Dg6DPQZsFiLiu+wcuG5WaLF621yG KhpBj8M/Ix+Wx+2KUDKcwoQLrr1baNV0rL8= Received: from mail.thefacebook.com (mailout.thefacebook.com [199.201.64.23]) by mx0a-00082601.pphosted.com with ESMTP id 2sgggysgak-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Wed, 15 May 2019 10:18:11 -0700 Received: from prn-mbx07.TheFacebook.com (2620:10d:c081:6::21) by prn-hub04.TheFacebook.com (2620:10d:c081:35::128) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.1.1713.5; Wed, 15 May 2019 10:18:08 -0700 Received: from prn-hub02.TheFacebook.com (2620:10d:c081:35::126) by prn-mbx07.TheFacebook.com (2620:10d:c081:6::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.1.1713.5; Wed, 15 May 2019 10:18:08 -0700 Received: from NAM04-SN1-obe.outbound.protection.outlook.com (192.168.54.28) by o365-in.thefacebook.com (192.168.16.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.1.1713.5 via Frontend Transport; Wed, 15 May 2019 10:18:08 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.onmicrosoft.com; s=selector1-fb-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=M+HeQUN9gzaGB+aAqkdYsyx1NRhGEPa8nOV7GMToD1w=; b=gBmRNMh/WSRLwfG0wSN98xYDBNTXLTC7avyveg5dCFD4nBdASpvdZJegmBViBXlk4NTCEmgi8xTE0YKlAYC3dl5K6ZrqwDdRPWIMuvAZlYh/KidUcC200KmUmawNzx9oCCgZhCSjGREmPVsx5ZwpKPSJpfG/hE4cTBl3BovSiuQ= Received: from BYAPR15MB2631.namprd15.prod.outlook.com (20.179.156.24) by BYAPR15MB3272.namprd15.prod.outlook.com (20.179.57.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1900.16; Wed, 15 May 2019 17:18:06 +0000 Received: from BYAPR15MB2631.namprd15.prod.outlook.com ([fe80::d4f6:b485:69ee:fd9a]) by BYAPR15MB2631.namprd15.prod.outlook.com ([fe80::d4f6:b485:69ee:fd9a%7]) with mapi id 15.20.1878.024; Wed, 15 May 2019 17:18:06 +0000 From: Roman Gushchin To: Anshuman Khandual CC: Andrew Morton , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Kernel Team , "Johannes Weiner" , Matthew Wilcox , Vlastimil Babka Subject: Re: [PATCH] mm: refactor __vunmap() to avoid duplicated call to find_vm_area() Thread-Topic: [PATCH] mm: refactor __vunmap() to avoid duplicated call to find_vm_area() Thread-Index: AQHVCq//khAEDBlALkSFD6zmmU+RfaZrl42AgADXXoA= Date: Wed, 15 May 2019 17:18:05 +0000 Message-ID: <20190515171800.GD9307@castle> References: <20190514235111.2817276-1-guro@fb.com> <78d9b650-4b47-60c5-4212-601c1719dba5@arm.com> In-Reply-To: <78d9b650-4b47-60c5-4212-601c1719dba5@arm.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: MWHPR2201CA0072.namprd22.prod.outlook.com (2603:10b6:301:5e::25) To BYAPR15MB2631.namprd15.prod.outlook.com (2603:10b6:a03:152::24) x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [2620:10d:c090:180::779] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: dd2df18a-eaa7-4aa6-3f2f-08d6d9594b39 x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(2017052603328)(7193020);SRVR:BYAPR15MB3272; x-ms-traffictypediagnostic: BYAPR15MB3272: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6430; x-forefront-prvs: 0038DE95A2 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(7916004)(396003)(136003)(39860400002)(366004)(376002)(346002)(189003)(199004)(71190400001)(71200400001)(6116002)(86362001)(1076003)(2906002)(33716001)(256004)(14444005)(5660300002)(6916009)(53936002)(305945005)(7736002)(4326008)(25786009)(66476007)(64756008)(52116002)(102836004)(386003)(6246003)(68736007)(316002)(8936002)(81156014)(81166006)(486006)(54906003)(46003)(11346002)(446003)(476003)(14454004)(478600001)(99286004)(186003)(6506007)(76176011)(53546011)(229853002)(6436002)(8676002)(6486002)(66556008)(73956011)(66446008)(66946007)(6512007)(9686003)(33656002)(37363001);DIR:OUT;SFP:1102;SCL:1;SRVR:BYAPR15MB3272;H:BYAPR15MB2631.namprd15.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: fb.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: ODA2eCa21J2+8xgnqORW5yH5C00xk9pJf18gs+NkAgx+UXTqGJMPlhhpvBK9CFxMZTVRCaPywhcve1AQ3/7infdBDeFYeBP/AUL+KlPX5LE0LuMNGeywb8744SrYo5Dk9CSLMvxyIwMT/ofFpn02Jt0JYvGJI0fW0qyTH6Z07Ulb18rfwAmJJT97S71K3PY8iensnp7VehoWnO3OZlPYoCChcvRibaUecrUW9l5/XGltax+2n3+tMt9bOJrYSKPd0KUqfVA2r9KmT9OxKwXR67YFJC4jcIfD9d4VcTQO5GeFRFECW7atNsmCbuWyMxFFBpCkgvZYwFUZFgX36RbeFbSNuzZtWzRTT9h3I6xQfFA0bQQQszSupYZb76u8J0U0eF9m2TWcW2jgaJAQt+OfHmCUGqbyq9KVNVrXzCr7b70= Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: dd2df18a-eaa7-4aa6-3f2f-08d6d9594b39 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 May 2019 17:18:05.9592 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR15MB3272 X-OriginatorOrg: fb.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-05-15_11:,, signatures=0 X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, May 15, 2019 at 09:57:11AM +0530, Anshuman Khandual wrote: >=20 >=20 > On 05/15/2019 05:21 AM, Roman Gushchin wrote: > > __vunmap() calls find_vm_area() twice without an obvious reason: > > first directly to get the area pointer, second indirectly by calling > > vm_remove_mappings()->remove_vm_area(), which is again searching > > for the area. > >=20 > > To remove this redundancy, let's split remove_vm_area() into > > __remove_vm_area(struct vmap_area *), which performs the actual area > > removal, and remove_vm_area(const void *addr) wrapper, which can > > be used everywhere, where it has been used before. Let's pass > > a pointer to the vm_area instead of vm_struct to vm_remove_mappings(), > > so it can pass it to __remove_vm_area() and avoid the redundant area > > lookup. > >=20 > > On my test setup, I've got 5-10% speed up on vfree()'ing 1000000 > > of 4-pages vmalloc blocks. >=20 > Though results from 1000000 single page vmalloc blocks remain inconclusi= ve, > 4-page based vmalloc block's result shows improvement in the range of 5-1= 0%. So you can confirm my numbers? Great, thank you!