From: Michal Hocko <mhocko@kernel.org>
To: Joel Savitz <jsavitz@redhat.com>
Cc: linux-kernel@vger.kernel.org, Rafael Aquini <aquini@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
David Rientjes <rientjes@google.com>,
linux-mm@kvack.org
Subject: Re: [RESEND PATCH v2] mm/oom_killer: Add task UID to info message on an oom kill
Date: Thu, 13 Jun 2019 10:23:18 +0200 [thread overview]
Message-ID: <20190613082318.GB9343@dhcp22.suse.cz> (raw)
In-Reply-To: <1560362273-534-1-git-send-email-jsavitz@redhat.com>
On Wed 12-06-19 13:57:53, Joel Savitz wrote:
> In the event of an oom kill, useful information about the killed
> process is printed to dmesg. Users, especially system administrators,
> will find it useful to immediately see the UID of the process.
Could you be more specific please? We already print uid when dumping
eligible tasks so it is not overly hard to find that information in the
oom report. Well, except when dumping of eligible tasks is disabled. Is
this what you are after?
Please always be specific about usecases in the changelog. A terse
statement that something is useful doesn't tell much very often.
Thanks!
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2019-06-13 8:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-12 17:57 [RESEND PATCH v2] mm/oom_killer: Add task UID to info message on an oom kill Joel Savitz
2019-06-12 18:40 ` Rafael Aquini
2019-06-13 1:00 ` Andrew Morton
2019-06-13 8:23 ` Michal Hocko [this message]
2019-09-21 0:13 ` Andrew Morton
2019-09-21 1:00 ` Rafael Aquini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190613082318.GB9343@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=aquini@redhat.com \
--cc=jsavitz@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).