From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CCA7C31E45 for ; Thu, 13 Jun 2019 12:11:21 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CFAF7208CA for ; Thu, 13 Jun 2019 12:11:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CFAF7208CA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.ibm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 224956B000E; Thu, 13 Jun 2019 08:11:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1D6676B0266; Thu, 13 Jun 2019 08:11:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0C53B6B026A; Thu, 13 Jun 2019 08:11:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by kanga.kvack.org (Postfix) with ESMTP id C87536B000E for ; Thu, 13 Jun 2019 08:11:19 -0400 (EDT) Received: by mail-pg1-f199.google.com with SMTP id a13so13708314pgw.19 for ; Thu, 13 Jun 2019 05:11:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:date:from:to :cc:subject:references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent:message-id; bh=E3Yahr2+zgc1tV3XIuhtZNSJf2eXGiM/TVvrAfX+42k=; b=a59il/13LoQR4U3a20FOvlNsTbQWXorYL+VEgsscUmj7gJxeERq0gvsysSc0MUvKvk Kf441t/RiyU+i8+nHutFm+WMP+i+XnOdY78RxxPpBXrRJxI4YhP9qJ0+w8XJt9zWE2mD KRItdaqYFy3s1WtgUbd1B4bf2uFkt09pb2ZP1qiWTIqOEAcRQcn2FkmCseq5oIcuGJyh wI9u01TQjTBsOP/362GjUjiQCgKa6z2tlFdO4yIa5XRVcyv5PbMPpQziQL9iKSMyN1zT xZ7ApifU1AurXVQoN5S85uB4cOJt2nV9TWudHWhm7uAonJlku5a8opGQCh5i0Jyn41QH gb5w== X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of rppt@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=rppt@linux.ibm.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ibm.com X-Gm-Message-State: APjAAAX02YFdy3XXJumUIjOob1LA0Iu+8m1NIv+P/twyS2UW1lw9OcvK jX7nD86d/f/91z2J38yDns7nucqLdDqG4enZPLXoYtpyHqJpIjBrnY5tn/ID54AthVKk4D11tM9 SseuyNpvSwc9qawHIZ93uSzZvyt+1MLT7XDw7POjt/hZeH2Kuv9rSiXOew6okFuWQnA== X-Received: by 2002:a65:530d:: with SMTP id m13mr31062586pgq.68.1560427879166; Thu, 13 Jun 2019 05:11:19 -0700 (PDT) X-Google-Smtp-Source: APXvYqyenGV39IMz2oG7dR/aHQ2zMsOFCNzdGEzQlFjm0U7rbmHU+DTaItXnR+ATl2b8FxNalIsW X-Received: by 2002:a65:530d:: with SMTP id m13mr31062471pgq.68.1560427877603; Thu, 13 Jun 2019 05:11:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560427877; cv=none; d=google.com; s=arc-20160816; b=WiiDzgMv5KlR+hWSm0EOR/nmxwIFdbxbW05g5UK03SG4zLY3Y7RJacTsvuL6ifxP5S UDVZSC3K6sPnXWNHgWxzeh+JpOJhMoXtfXY+r4WxXbBeDRBEsw8q3p0PZXk7wDAGPZaC D0+bEQD4AhpMYEOmiJuDRFOmyX8u1vbo5O3xbh+HDnQG6qEdyDpqTRqjPtcps3J0tpmk qJgliOkyoqbZ4NUr0/YePVNqDrm3UxJDqbnonww1Cpt+OjMZ90wd6By4MEsr1vuQNwDV FD7lnZdhBraEG0lAXeoyI9mgzgXU1SQSqCD9gvjaXwNklUqzATfY62caBe1WRAlVR/lJ MjkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=message-id:user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:subject:cc:to:from:date; bh=E3Yahr2+zgc1tV3XIuhtZNSJf2eXGiM/TVvrAfX+42k=; b=koF5012+U+d2kn9hq5MC46UL83gfxuO2JxKT5ZxVdtqiF6K6Pcaytz9SjFqtZGDeOb 254w79hbocjBw6/NzHtQAoRnNFBunA4iTHGnALDriizDTbPiiiqMX1Edx7TFhnF4ylgJ iGc4fGXUyor88VA7LRb+u4iKh74AgT8b2XIvc0/w4LfhSQnpUZVBF6Uh4enM0BqKTM2K P75Xlolraei0dUf9eYuOmxqxLNuDEPKeF4MXf3TIw+L5fFuyfqROQKsVUTxXsaSMS+D+ ZCi6c1uljHXh4NJEgRVhJ0QGfVW0lG9gM/fifaHHR6B69aTBLyUI+kPdtcL5AfB6ybAD CgCA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of rppt@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=rppt@linux.ibm.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com. [148.163.156.1]) by mx.google.com with ESMTPS id f14si3244006pgf.526.2019.06.13.05.11.17 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 13 Jun 2019 05:11:17 -0700 (PDT) Received-SPF: pass (google.com: domain of rppt@linux.ibm.com designates 148.163.156.1 as permitted sender) client-ip=148.163.156.1; Authentication-Results: mx.google.com; spf=pass (google.com: domain of rppt@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=rppt@linux.ibm.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x5DC32NO068616 for ; Thu, 13 Jun 2019 08:11:16 -0400 Received: from e06smtp07.uk.ibm.com (e06smtp07.uk.ibm.com [195.75.94.103]) by mx0a-001b2d01.pphosted.com with ESMTP id 2t3ne3ac37-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 13 Jun 2019 08:11:15 -0400 Received: from localhost by e06smtp07.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 13 Jun 2019 13:11:10 +0100 Received: from b06cxnps4076.portsmouth.uk.ibm.com (9.149.109.198) by e06smtp07.uk.ibm.com (192.168.101.137) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Thu, 13 Jun 2019 13:11:05 +0100 Received: from d06av23.portsmouth.uk.ibm.com (d06av23.portsmouth.uk.ibm.com [9.149.105.59]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x5DCB4pl49152030 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 13 Jun 2019 12:11:04 GMT Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 43EDFA4040; Thu, 13 Jun 2019 12:11:04 +0000 (GMT) Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 063E1A4055; Thu, 13 Jun 2019 12:11:03 +0000 (GMT) Received: from rapoport-lnx (unknown [9.148.204.162]) by d06av23.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Thu, 13 Jun 2019 12:11:02 +0000 (GMT) Date: Thu, 13 Jun 2019 15:11:01 +0300 From: Mike Rapoport To: Mark Rutland Cc: Qian Cai , Will Deacon , akpm@linux-foundation.org, Roman Gushchin , catalin.marinas@arm.com, linux-kernel@vger.kernel.org, mhocko@kernel.org, linux-mm@kvack.org, vdavydov.dev@gmail.com, hannes@cmpxchg.org, cgroups@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH -next] arm64/mm: fix a bogus GFP flag in pgd_alloc() References: <1559656836-24940-1-git-send-email-cai@lca.pw> <20190604142338.GC24467@lakrids.cambridge.arm.com> <20190610114326.GF15979@fuggles.cambridge.arm.com> <1560187575.6132.70.camel@lca.pw> <20190611100348.GB26409@lakrids.cambridge.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190611100348.GB26409@lakrids.cambridge.arm.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-TM-AS-GCONF: 00 x-cbid: 19061312-0028-0000-0000-00000379FAD3 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19061312-0029-0000-0000-00002439F36A Message-Id: <20190613121100.GB25164@rapoport-lnx> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-06-13_08:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=7 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1906130095 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: (added Roman) On Tue, Jun 11, 2019 at 11:03:49AM +0100, Mark Rutland wrote: > On Mon, Jun 10, 2019 at 01:26:15PM -0400, Qian Cai wrote: > > On Mon, 2019-06-10 at 12:43 +0100, Will Deacon wrote: > > > On Tue, Jun 04, 2019 at 03:23:38PM +0100, Mark Rutland wrote: > > > > On Tue, Jun 04, 2019 at 10:00:36AM -0400, Qian Cai wrote: > > > > > The commit "arm64: switch to generic version of pte allocation" > > > > > introduced endless failures during boot like, > > > > > > > > > > kobject_add_internal failed for pgd_cache(285:chronyd.service) (error: > > > > > -2 parent: cgroup) > > > > > > > > > > It turns out __GFP_ACCOUNT is passed to kernel page table allocations > > > > > and then later memcg finds out those don't belong to any cgroup. > > > > > > > > Mike, I understood from [1] that this wasn't expected to be a problem, > > > > as the accounting should bypass kernel threads. > > > > > > > > Was that assumption wrong, or is something different happening here? > > > > > > > > > > > > > > backtrace: > > > > >   kobject_add_internal > > > > >   kobject_init_and_add > > > > >   sysfs_slab_add+0x1a8 > > > > >   __kmem_cache_create > > > > >   create_cache > > > > >   memcg_create_kmem_cache > > > > >   memcg_kmem_cache_create_func > > > > >   process_one_work > > > > >   worker_thread > > > > >   kthread > > > > > > > > > > Signed-off-by: Qian Cai > > > > > --- > > > > >  arch/arm64/mm/pgd.c | 2 +- > > > > >  1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > > > diff --git a/arch/arm64/mm/pgd.c b/arch/arm64/mm/pgd.c > > > > > index 769516cb6677..53c48f5c8765 100644 > > > > > --- a/arch/arm64/mm/pgd.c > > > > > +++ b/arch/arm64/mm/pgd.c > > > > > @@ -38,7 +38,7 @@ pgd_t *pgd_alloc(struct mm_struct *mm) > > > > >   if (PGD_SIZE == PAGE_SIZE) > > > > >   return (pgd_t *)__get_free_page(gfp); > > > > >   else > > > > > - return kmem_cache_alloc(pgd_cache, gfp); > > > > > + return kmem_cache_alloc(pgd_cache, GFP_PGTABLE_KERNEL); > > > > > > > > This is used to allocate PGDs for both user and kernel pagetables (e.g. > > > > for the efi runtime services), so while this may fix the regression, I'm > > > > not sure it's the right fix. > > > > > > > > Do we need a separate pgd_alloc_kernel()? > > > > > > So can I take the above for -rc5, or is somebody else working on a different > > > fix to implement pgd_alloc_kernel()? > > > > The offensive commit "arm64: switch to generic version of pte allocation" is not > > yet in the mainline, but only in the Andrew's tree and linux-next, and I doubt > > Andrew will push this out any time sooner given it is broken. > > I'd assumed that Mike would respin these patches to implement and use > pgd_alloc_kernel() (or take gfp flags) and the updated patches would > replace these in akpm's tree. > > Mike, could you confirm what your plan is? I'm happy to review/test > updated patches for arm64. The log Qian Cai posted at [1] and partially cited below confirms that the failure happens when *user* PGDs are allocated and the addition of __GFP_ACCOUNT to gfp flags used by pgd_alloc() only uncovered another issue. I'm still failing to reproduce it with qemu and I'm not really familiar with slub/memcg code to say anything smart about it. Will keep looking. Note, that as failures start way after efi_virtmap_init() that allocates a PGD for efi_mm, there are no real fixes required for the original series, except that the check for mm == &init_mm I copied for some reason from powerpc is bogus and can be removed. I surely can add pgd_alloc_kernel() to be used by the EFI code to make sure we won't run into issues with memcg in the future. [ 82.125966] Freeing unused kernel memory: 28672K [ 87.940365] Checked W+X mappings: passed, no W+X pages found [ 87.946769] Run /init as init process [ 88.040040] systemd[1]: System time before build time, advancing clock. [ 88.054593] systemd[1]: Failed to insert module 'autofs4': No such file or directory [ 88.374129] modprobe (1726) used greatest stack depth: 28464 bytes left [ 88.470108] systemd[1]: systemd 239 running in system mode. (+PAM +AUDIT +SELINUX +IMA -APPARMOR +SMACK +SYSVINIT +UTMP +LIBCRYPTSETUP +GCRYPT +GNUTLS +ACL +XZ +LZ4 +SECCOMP +BLKID +ELFUTILS +KMOD +IDN2 -IDN +PCRE2 default-hierarchy=legacy) [ 88.498398] systemd[1]: Detected architecture arm64. [ 88.506517] systemd[1]: Running in initial RAM disk. [ 89.621995] mkdir (1730) used greatest stack depth: 27872 bytes left [ 90.222658] random: systemd: uninitialized urandom read (16 bytes read) [ 90.230072] systemd[1]: Reached target Swap. [ 90.240205] random: systemd: uninitialized urandom read (16 bytes read) [ 90.251088] systemd[1]: Reached target Timers. [ 90.261303] random: systemd: uninitialized urandom read (16 bytes read) [ 90.271209] systemd[1]: Listening on udev Control Socket. [ 90.283238] systemd[1]: Reached target Local File Systems. [ 90.296232] systemd[1]: Reached target Slices. [ 90.307239] systemd[1]: Listening on udev Kernel Socket. [ 90.608597] kobject_add_internal failed for pgd_cache(13:init.scope) (error: -2 parent: cgroup) [ 90.678007] kobject_add_internal failed for pgd_cache(13:init.scope)(error: -2 parent: cgroup) [ 90.713260] kobject_add_internal failed for pgd_cache(21:systemd-tmpfiles-setup.service) (error: -2 parent: cgroup) [ 90.820012] systemd-tmpfile (1759) used greatest stack depth: 27184 bytes left [ 90.861942] kobject_add_internal failed for pgd_cache(13:init.scope) error: -2 parent: cgroup) > Thanks, > Mark. > [1] https://cailca.github.io/files/dmesg.txt -- Sincerely yours, Mike.