From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46A83C31E49 for ; Thu, 13 Jun 2019 19:44:43 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id F2F012173C for ; Thu, 13 Jun 2019 19:44:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F2F012173C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.ibm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9CF298E0003; Thu, 13 Jun 2019 15:44:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 97FD88E0001; Thu, 13 Jun 2019 15:44:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 86EDF8E0003; Thu, 13 Jun 2019 15:44:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by kanga.kvack.org (Postfix) with ESMTP id 533DB8E0001 for ; Thu, 13 Jun 2019 15:44:42 -0400 (EDT) Received: by mail-pg1-f199.google.com with SMTP id c4so29110pgm.21 for ; Thu, 13 Jun 2019 12:44:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:date:from:to :cc:subject:references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent:message-id; bh=0IDi/qRKrGVOQODqp+IdzPDA49pRL6Y3IrxsHxxvIJ4=; b=O/pV1AGQCPxIzHm2OoAzXki/f7h5q5Y6mEp3x2mDn5Bq/BfmJ/bjhMYVa+n5LsvDOE aUott9KVBuB21GGJNYXdHPCHRDVYoHg8Xzlvtp0dVytaxVlaSvlVKIJBwwmXeQCpNirA wiQ8d605HAoOoR40pm4rdRHND7V/MkXkQoWBBhFu/yC1IgaXWwUlKcgCw/N5pxFGs/JY EefDqV+qK7jDCOpAPTne9duHsKnwMaecI7Otn16q7rZZI10p2eUg9yOkEFKbw5K64LBU WBGjPL+TLjD16nCHIQ+5wv8VqujZdzDuCNF6EY73vHFxdNhTyMeFyhqmOrZsXmXivUT8 zqNQ== X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of rppt@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=rppt@linux.ibm.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ibm.com X-Gm-Message-State: APjAAAUd5+8ti9iqxMrjo2qgVRgA0LsXNeAkOq65Xvz1ZI48cVZuXDt0 IIJFNjiPvUCZzZUqtlFT2LbksswKLNos+GwNkAo7/oUEltmdl0YkRY4N9gP7TKPU2h6hkPRC9oo utvLTK4uiYUJ87HlqwZyisxN7y39lIA1rQYOiLblQqKjNGgznevt/oSP55DA/fBX8mQ== X-Received: by 2002:a17:902:42d:: with SMTP id 42mr85676514ple.228.1560455081842; Thu, 13 Jun 2019 12:44:41 -0700 (PDT) X-Google-Smtp-Source: APXvYqzZYnrXg3S9vE0roSQtMfSpsDy7md4hWlgWA2uc/qXPlRcF2h65w5WY0GwWcvutH1pOhGTd X-Received: by 2002:a17:902:42d:: with SMTP id 42mr85676469ple.228.1560455080848; Thu, 13 Jun 2019 12:44:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560455080; cv=none; d=google.com; s=arc-20160816; b=Omjr0m/AKkSAKEFULMN7OV3/lvSWx3aK6B9LcKVMT81GS3jZSVi/VsLo9woA/B7vHs IFtcjrtnxg/05LaNs3kkCht/h0lPb1GvSMc9sQt8HwACNT/jy0fgo9geDoDhQwbYs7lt aJffOCjRP8obuH9AoDEnfsXyODLJAHGSGadIg+fQFzQO4nEbhhs+a9ypPEf6v/nDuPpi +BbEXw+1cg1vHl06ixqycd952VrzxvC+hSrCj8gi0VX5ekAeu2h/3FQQURTPgfXnqBNb YoVbyR+3hcoyxE6LDH7tEjt5pOj+34PBMhsQz287UrMskAlCibv3u5YDMFtWj7+XJNyK BpMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=message-id:user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:subject:cc:to:from:date; bh=0IDi/qRKrGVOQODqp+IdzPDA49pRL6Y3IrxsHxxvIJ4=; b=ASryB8R1aK+oqiNLuDskPJNjsYBpIE/iYF4l5IFwVv0DKeH2c/odQcggu/PVxrhot1 WkuajSbXYFo9X7Lm4+Vai+ahkFBu+bkGThe2B9mVKJCQRK3I93Pa2kDIpviSx/GrgVnZ dlk0jKTPeKqym+HOSCS6+DxwHOigrTf+JafXhJNAmis1YQUmveUpJSZiDxLDqfkdI2+S fDDofn8f0Bes06mRKO9Y5BZNyRKKjKI5OVbZi8gm1gxmaeZBCXJp5s5Jlyjp27h7SvRW EkWyt2f+TsTGpdY8eKNTGkEFhkK8OHhrn8Zyl6a6Q2d5SwfB71U8e5611mIW+jlwnLFF iBdQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of rppt@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=rppt@linux.ibm.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com. [148.163.156.1]) by mx.google.com with ESMTPS id m4si489094pgv.487.2019.06.13.12.44.40 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 13 Jun 2019 12:44:40 -0700 (PDT) Received-SPF: pass (google.com: domain of rppt@linux.ibm.com designates 148.163.156.1 as permitted sender) client-ip=148.163.156.1; Authentication-Results: mx.google.com; spf=pass (google.com: domain of rppt@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=rppt@linux.ibm.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: from pps.filterd (m0098404.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x5DJbUbA071330 for ; Thu, 13 Jun 2019 15:44:40 -0400 Received: from e06smtp02.uk.ibm.com (e06smtp02.uk.ibm.com [195.75.94.98]) by mx0a-001b2d01.pphosted.com with ESMTP id 2t3s629rpj-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 13 Jun 2019 15:44:39 -0400 Received: from localhost by e06smtp02.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 13 Jun 2019 20:44:37 +0100 Received: from b06cxnps3074.portsmouth.uk.ibm.com (9.149.109.194) by e06smtp02.uk.ibm.com (192.168.101.132) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Thu, 13 Jun 2019 20:44:32 +0100 Received: from d06av21.portsmouth.uk.ibm.com (d06av21.portsmouth.uk.ibm.com [9.149.105.232]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x5DJiVjb30933166 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 13 Jun 2019 19:44:31 GMT Received: from d06av21.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5E1755204F; Thu, 13 Jun 2019 19:44:31 +0000 (GMT) Received: from rapoport-lnx (unknown [9.148.204.162]) by d06av21.portsmouth.uk.ibm.com (Postfix) with ESMTPS id 2222252051; Thu, 13 Jun 2019 19:44:30 +0000 (GMT) Date: Thu, 13 Jun 2019 22:44:28 +0300 From: Mike Rapoport To: Qian Cai Cc: Mark Rutland , Will Deacon , akpm@linux-foundation.org, Roman Gushchin , catalin.marinas@arm.com, linux-kernel@vger.kernel.org, mhocko@kernel.org, linux-mm@kvack.org, vdavydov.dev@gmail.com, hannes@cmpxchg.org, cgroups@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH -next] arm64/mm: fix a bogus GFP flag in pgd_alloc() References: <1559656836-24940-1-git-send-email-cai@lca.pw> <20190604142338.GC24467@lakrids.cambridge.arm.com> <20190610114326.GF15979@fuggles.cambridge.arm.com> <1560187575.6132.70.camel@lca.pw> <20190611100348.GB26409@lakrids.cambridge.arm.com> <20190613121100.GB25164@rapoport-lnx> <1560432156.5154.11.camel@lca.pw> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1560432156.5154.11.camel@lca.pw> User-Agent: Mutt/1.5.24 (2015-08-30) X-TM-AS-GCONF: 00 x-cbid: 19061319-0008-0000-0000-000002F38C7A X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19061319-0009-0000-0000-00002260940A Message-Id: <20190613194427.GC25164@rapoport-lnx> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-06-13_12:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=2 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1906130146 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jun 13, 2019 at 09:22:36AM -0400, Qian Cai wrote: > On Thu, 2019-06-13 at 15:11 +0300, Mike Rapoport wrote: > > The log Qian Cai posted at [1] and partially cited below confirms that the > > failure happens when *user* PGDs are allocated and the addition of > > __GFP_ACCOUNT to gfp flags used by pgd_alloc() only uncovered another > > issue. > > > > I'm still failing to reproduce it with qemu and I'm not really familiar > > with slub/memcg code to say anything smart about it. Will keep looking. > > > > Note, that as failures start way after efi_virtmap_init() that allocates a > > PGD for efi_mm, there are no real fixes required for the original series, > > except that the check for mm == &init_mm I copied for some reason from > > powerpc is bogus and can be removed. > > Yes, there is more places are not happy with __GFP_ACCOUNT other than efi_mm. > For example, Here we allocate the pgd for a user process and it should be accounted. Actually, the whole point of changing the gfp flags in arm64::pgd_alloc() was to enable the accounting for memory occupied by user pgds, just like x86 and powerpc do. > [  132.786842][ T1501] kobject_add_internal failed for pgd_cache(49:systemd- > udevd.service) (error: -2 parent: cgroup) > [  132.795589][ T1889] CPU: 9 PID: 1889 Comm: systemd-udevd Tainted: > G        W         5.2.0-rc4-next-20190613+ #8 > [  132.807356][ T1889] Hardware name: HPE Apollo > 70             /C01_APACHE_MB         , BIOS L50_5.13_1.0.9 03/01/2019 > [  132.817872][ T1889] Call trace: > [  132.821017][ T1889]  dump_backtrace+0x0/0x268 > [  132.825372][ T1889]  show_stack+0x20/0x2c > [  132.829380][ T1889]  dump_stack+0xb4/0x108 > [  132.833475][ T1889]  pgd_alloc+0x34/0x5c > [  132.837396][ T1889]  mm_init+0x27c/0x32c > [  132.841315][ T1889]  dup_mm+0x84/0x7b4 > [  132.845061][ T1889]  copy_process+0xf20/0x24cc > [  132.849500][ T1889]  _do_fork+0xa4/0x66c > [  132.853420][ T1889]  __arm64_sys_clone+0x114/0x1b4 > [  132.858208][ T1889]  el0_svc_handler+0x198/0x260 > [  132.862821][ T1889]  el0_svc+0x8/0xc > > > > > I surely can add pgd_alloc_kernel() to be used by the EFI code to make sure > > we won't run into issues with memcg in the future. > > > > [   82.125966] Freeing unused kernel memory: 28672K > > [   87.940365] Checked W+X mappings: passed, no W+X pages found > > [   87.946769] Run /init as init process > > [   88.040040] systemd[1]: System time before build time, advancing clock. > > [   88.054593] systemd[1]: Failed to insert module 'autofs4': No such file or > > directory > > [   88.374129] modprobe (1726) used greatest stack depth: 28464 bytes left > > [   88.470108] systemd[1]: systemd 239 running in system mode. (+PAM +AUDIT > > +SELINUX +IMA -APPARMOR +SMACK +SYSVINIT +UTMP +LIBCRYPTSETUP +GCRYPT > > +GNUTLS +ACL +XZ +LZ4 +SECCOMP +BLKID +ELFUTILS +KMOD +IDN2 -IDN +PCRE2 > > default-hierarchy=legacy) > > [   88.498398] systemd[1]: Detected architecture arm64. > > [   88.506517] systemd[1]: Running in initial RAM disk. > > [   89.621995] mkdir (1730) used greatest stack depth: 27872 bytes left > > [   90.222658] random: systemd: uninitialized urandom read (16 bytes read) > > [   90.230072] systemd[1]: Reached target Swap. > > [   90.240205] random: systemd: uninitialized urandom read (16 bytes read) > > [   90.251088] systemd[1]: Reached target Timers. > > [   90.261303] random: systemd: uninitialized urandom read (16 bytes read) > > [   90.271209] systemd[1]: Listening on udev Control Socket. > > [   90.283238] systemd[1]: Reached target Local File Systems. > > [   90.296232] systemd[1]: Reached target Slices. > > [   90.307239] systemd[1]: Listening on udev Kernel Socket. > > [   90.608597] kobject_add_internal failed for pgd_cache(13:init.scope) > > (error: -2 parent: cgroup) > > [   90.678007] kobject_add_internal failed for pgd_cache(13:init.scope)(error: > > -2 parent: cgroup) > > [   90.713260] kobject_add_internal failed for pgd_cache(21:systemd-tmpfiles- > > setup.service) (error: -2 parent: cgroup) > > [   90.820012] systemd-tmpfile (1759) used greatest stack depth: 27184 bytes > > left > > [   90.861942] kobject_add_internal failed for pgd_cache(13:init.scope) error: > > -2 parent: cgroup) > >   > > > Thanks, > > > Mark. > > > > > > > [1] https://cailca.github.io/files/dmesg.txt > > -- Sincerely yours, Mike.