From: Mike Rapoport <rppt@linux.ibm.com>
To: Will Deacon <will.deacon@arm.com>
Cc: Mark Rutland <mark.rutland@arm.com>, Qian Cai <cai@lca.pw>,
akpm@linux-foundation.org, Roman Gushchin <guro@fb.com>,
catalin.marinas@arm.com, linux-kernel@vger.kernel.org,
mhocko@kernel.org, linux-mm@kvack.org, vdavydov.dev@gmail.com,
hannes@cmpxchg.org, cgroups@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH -next] arm64/mm: fix a bogus GFP flag in pgd_alloc()
Date: Tue, 18 Jun 2019 09:12:59 +0300 [thread overview]
Message-ID: <20190618061259.GB15497@rapoport-lnx> (raw)
In-Reply-To: <20190617163630.GH30800@fuggles.cambridge.arm.com>
On Mon, Jun 17, 2019 at 05:36:30PM +0100, Will Deacon wrote:
> Hi Mike,
>
> On Mon, Jun 17, 2019 at 06:12:52PM +0300, Mike Rapoport wrote:
> > Andrew, can you please add the patch below as an incremental fix?
> >
> > With this the arm64::pgd_alloc() should be in the right shape.
> >
> >
> > From 1c1ef0bc04c655689c6c527bd03b140251399d87 Mon Sep 17 00:00:00 2001
> > From: Mike Rapoport <rppt@linux.ibm.com>
> > Date: Mon, 17 Jun 2019 17:37:43 +0300
> > Subject: [PATCH] arm64/mm: don't initialize pgd_cache twice
> >
> > When PGD_SIZE != PAGE_SIZE, arm64 uses kmem_cache for allocation of PGD
> > memory. That cache was initialized twice: first through
> > pgtable_cache_init() alias and then as an override for weak
> > pgd_cache_init().
> >
> > After enabling accounting for the PGD memory, this created a confusion for
> > memcg and slub sysfs code which resulted in the following errors:
> >
> > [ 90.608597] kobject_add_internal failed for pgd_cache(13:init.scope) (error: -2 parent: cgroup)
> > [ 90.678007] kobject_add_internal failed for pgd_cache(13:init.scope) (error: -2 parent: cgroup)
> > [ 90.713260] kobject_add_internal failed for pgd_cache(21:systemd-tmpfiles-setup.service) (error: -2 parent: cgroup)
> >
> > Removing the alias from pgtable_cache_init() and keeping the only pgd_cache
> > initialization in pgd_cache_init() resolves the problem and allows
> > accounting of PGD memory.
> >
> > Reported-by: Qian Cai <cai@lca.pw>
> > Signed-off-by: Mike Rapoport <rppt@linux.ibm.com>
> > ---
> > arch/arm64/include/asm/pgtable.h | 3 +--
> > arch/arm64/mm/pgd.c | 5 +----
> > 2 files changed, 2 insertions(+), 6 deletions(-)
>
> Looks like this actually fixes caa841360134 ("x86/mm: Initialize PGD cache
> during mm initialization") due to an unlucky naming conflict!
>
> In which case, I'd actually prefer to take this fix asap via the arm64
> tree. Is that ok?
I suppose so, it just won't apply as is. Would you like a patch against the
current upstream?
> Will
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2019-06-18 6:13 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-04 14:00 [PATCH -next] arm64/mm: fix a bogus GFP flag in pgd_alloc() Qian Cai
2019-06-04 14:23 ` Mark Rutland
2019-06-04 14:30 ` Mark Rutland
2019-06-05 21:33 ` Mike Rapoport
2019-06-04 14:54 ` Mike Rapoport
2019-06-10 11:43 ` Will Deacon
2019-06-10 17:26 ` Qian Cai
2019-06-11 10:03 ` Mark Rutland
2019-06-11 12:41 ` Mike Rapoport
2019-06-11 12:46 ` Qian Cai
2019-06-12 6:57 ` Mike Rapoport
2019-06-12 18:35 ` Qian Cai
2019-06-11 13:02 ` Mark Rutland
2019-06-13 12:11 ` Mike Rapoport
2019-06-13 13:22 ` Qian Cai
2019-06-13 19:44 ` Mike Rapoport
2019-06-17 15:12 ` Mike Rapoport
2019-06-17 16:36 ` Will Deacon
2019-06-18 6:12 ` Mike Rapoport [this message]
2019-06-18 6:54 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190618061259.GB15497@rapoport-lnx \
--to=rppt@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=cai@lca.pw \
--cc=catalin.marinas@arm.com \
--cc=cgroups@vger.kernel.org \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mark.rutland@arm.com \
--cc=mhocko@kernel.org \
--cc=vdavydov.dev@gmail.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).