From: Michal Hocko <mhocko@suse.com>
To: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, David Rientjes <rientjes@google.com>,
Greg Thelen <gthelen@google.com>,
Johannes Weiner <hannes@cmpxchg.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Subject: Re: [PATCH] mm: oom: Remove thread group leader check in oom_evaluate_task().
Date: Tue, 18 Jun 2019 14:14:18 +0200 [thread overview]
Message-ID: <20190618121418.GC3318@dhcp22.suse.cz> (raw)
In-Reply-To: <1560853257-14934-1-git-send-email-penguin-kernel@I-love.SAKURA.ne.jp>
On Tue 18-06-19 19:20:57, Tetsuo Handa wrote:
> Since mem_cgroup_scan_tasks() uses CSS_TASK_ITER_PROCS, only thread group
> leaders will be scanned (unless dying leaders with live threads). Thus,
> commit d49ad9355420c743 ("mm, oom: prefer thread group leaders for display
> purposes") makes little sense.
This can be folded into mm-memcontrol-use-css_task_iter_procs-at-mem_cgroup_scan_tasks.patch
right?
> Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
> Cc: David Rientjes <rientjes@google.com>
> Cc: Johannes Weiner <hannes@cmpxchg.org>
> Cc: Michal Hocko <mhocko@suse.cz>
> Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
> Cc: Greg Thelen <gthelen@google.com>
> ---
> mm/oom_kill.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/mm/oom_kill.c b/mm/oom_kill.c
> index 32abc7a..09a5116 100644
> --- a/mm/oom_kill.c
> +++ b/mm/oom_kill.c
> @@ -348,9 +348,6 @@ static int oom_evaluate_task(struct task_struct *task, void *arg)
> if (!points || points < oc->chosen_points)
> goto next;
>
> - /* Prefer thread group leaders for display purposes */
> - if (points == oc->chosen_points && thread_group_leader(oc->chosen))
> - goto next;
> select:
> if (oc->chosen)
> put_task_struct(oc->chosen);
> --
> 1.8.3.1
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2019-06-18 12:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-18 10:20 [PATCH] mm: oom: Remove thread group leader check in oom_evaluate_task() Tetsuo Handa
2019-06-18 12:14 ` Michal Hocko [this message]
2019-06-18 13:23 ` Tetsuo Handa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190618121418.GC3318@dhcp22.suse.cz \
--to=mhocko@suse.com \
--cc=akpm@linux-foundation.org \
--cc=gthelen@google.com \
--cc=hannes@cmpxchg.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-mm@kvack.org \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).