From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Jan Kara <jack@suse.cz>
Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
linux-xfs@vger.kernel.org, Amir Goldstein <amir73il@gmail.com>,
Boaz Harrosh <boaz@plexistor.com>,
stable@vger.kernel.org
Subject: Re: [PATCH 2/3] fs: Export generic_fadvise()
Date: Fri, 12 Jul 2019 10:50:52 -0700 [thread overview]
Message-ID: <20190712175052.GZ1404256@magnolia> (raw)
In-Reply-To: <20190711140012.1671-3-jack@suse.cz>
On Thu, Jul 11, 2019 at 04:00:11PM +0200, Jan Kara wrote:
> Filesystems will need to call this function from their fadvise handlers.
>
> CC: stable@vger.kernel.org # Needed by "xfs: Fix stale data exposure when
> readahead races with hole punch"
> Signed-off-by: Jan Kara <jack@suse.cz>
Looks ok,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> ---
> include/linux/fs.h | 2 ++
> mm/fadvise.c | 4 ++--
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/fs.h b/include/linux/fs.h
> index f7fdfe93e25d..2666862ff00d 100644
> --- a/include/linux/fs.h
> +++ b/include/linux/fs.h
> @@ -3536,6 +3536,8 @@ extern void inode_nohighmem(struct inode *inode);
> /* mm/fadvise.c */
> extern int vfs_fadvise(struct file *file, loff_t offset, loff_t len,
> int advice);
> +extern int generic_fadvise(struct file *file, loff_t offset, loff_t len,
> + int advice);
>
> #if defined(CONFIG_IO_URING)
> extern struct sock *io_uring_get_socket(struct file *file);
> diff --git a/mm/fadvise.c b/mm/fadvise.c
> index 467bcd032037..4f17c83db575 100644
> --- a/mm/fadvise.c
> +++ b/mm/fadvise.c
> @@ -27,8 +27,7 @@
> * deactivate the pages and clear PG_Referenced.
> */
>
> -static int generic_fadvise(struct file *file, loff_t offset, loff_t len,
> - int advice)
> +int generic_fadvise(struct file *file, loff_t offset, loff_t len, int advice)
> {
> struct inode *inode;
> struct address_space *mapping;
> @@ -178,6 +177,7 @@ static int generic_fadvise(struct file *file, loff_t offset, loff_t len,
> }
> return 0;
> }
> +EXPORT_SYMBOL(generic_fadvise);
>
> int vfs_fadvise(struct file *file, loff_t offset, loff_t len, int advice)
> {
> --
> 2.16.4
>
next prev parent reply other threads:[~2019-07-12 17:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-11 14:00 [PATCH 0/3] xfs: Fix races between readahead and hole punching Jan Kara
2019-07-11 14:00 ` [PATCH 1/3] mm: Handle MADV_WILLNEED through vfs_fadvise() Jan Kara
2019-07-12 17:50 ` Darrick J. Wong
2019-07-12 23:55 ` Sasha Levin
2019-07-23 3:08 ` Boaz Harrosh
2019-07-11 14:00 ` [PATCH 2/3] fs: Export generic_fadvise() Jan Kara
2019-07-12 17:50 ` Darrick J. Wong [this message]
2019-07-12 23:55 ` Sasha Levin
2019-07-11 14:00 ` [PATCH 3/3] xfs: Fix stale data exposure when readahead races with hole punch Jan Kara
2019-07-11 15:28 ` Amir Goldstein
2019-07-11 15:49 ` Darrick J. Wong
2019-07-12 12:00 ` Jan Kara
2019-07-12 17:56 ` Darrick J. Wong
2019-08-29 13:10 [PATCH 0/3 v2] xfs: Fix races between readahead and hole punching Jan Kara
2019-08-29 13:10 ` [PATCH 2/3] fs: Export generic_fadvise() Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190712175052.GZ1404256@magnolia \
--to=darrick.wong@oracle.com \
--cc=amir73il@gmail.com \
--cc=boaz@plexistor.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).