linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Michal Hocko <mhocko@kernel.org>
To: Yang Shi <yang.shi@linux.alibaba.com>
Cc: dvyukov@google.com, catalin.marinas@arm.com,
	akpm@linux-foundation.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: page_alloc: document kmemleak's non-blockable __GFP_NOFAIL case
Date: Mon, 15 Jul 2019 15:17:32 +0200	[thread overview]
Message-ID: <20190715131732.GX29483@dhcp22.suse.cz> (raw)
In-Reply-To: <1562964544-59519-1-git-send-email-yang.shi@linux.alibaba.com>

On Sat 13-07-19 04:49:04, Yang Shi wrote:
> When running ltp's oom test with kmemleak enabled, the below warning was
> triggerred since kernel detects __GFP_NOFAIL & ~__GFP_DIRECT_RECLAIM is
> passed in:

kmemleak is broken and this is a long term issue. I thought that
Catalin had something to address this.

While this patch only adds a comment and discourages future changes of
the warning which is fine and probably something that we should do,
kmemleak really should be fixed sooner than later.
-- 
Michal Hocko
SUSE Labs


  parent reply	other threads:[~2019-07-15 13:17 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-12 20:49 [PATCH] mm: page_alloc: document kmemleak's non-blockable __GFP_NOFAIL case Yang Shi
2019-07-13 19:39 ` David Rientjes
2019-07-15  3:43   ` Yang Shi
2019-07-15 13:18   ` Michal Hocko
2019-07-13 21:25 ` Matthew Wilcox
2019-07-15  3:47   ` Yang Shi
2019-07-15 13:06     ` Matthew Wilcox
2019-07-15 17:00       ` Yang Shi
2019-07-15 13:17 ` Michal Hocko [this message]
2019-07-15 15:01   ` Catalin Marinas
2019-07-15 15:18     ` Qian Cai
2019-07-15 16:58       ` Yang Shi
2019-07-16 17:38     ` Yang Shi
2019-07-25  2:48 ` Andrew Morton
2019-07-25 17:21   ` Yang Shi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190715131732.GX29483@dhcp22.suse.cz \
    --to=mhocko@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=catalin.marinas@arm.com \
    --cc=dvyukov@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=yang.shi@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).