From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B169BC76194 for ; Tue, 23 Jul 2019 07:25:20 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7514021911 for ; Tue, 23 Jul 2019 07:25:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7514021911 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 104E36B0003; Tue, 23 Jul 2019 03:25:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 090778E0003; Tue, 23 Jul 2019 03:25:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E24278E0001; Tue, 23 Jul 2019 03:25:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by kanga.kvack.org (Postfix) with ESMTP id 90E046B0003 for ; Tue, 23 Jul 2019 03:25:19 -0400 (EDT) Received: by mail-wr1-f70.google.com with SMTP id s18so20360539wru.16 for ; Tue, 23 Jul 2019 00:25:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:date:from:to :cc:subject:message-id:references:mime-version:content-disposition :content-transfer-encoding:in-reply-to; bh=sHDKTXWU/xgPgNMn/V0t0D27DplpYbCWQ39JljnO3KE=; b=bxT2r0uRSt70PbamnEPErBgE3L7s3wqa0SP+HNC/7seW4WNaHPnTNozIchTvNu6I6S TW85oSigV7RToEOHvxipQ1KunERhhAogLJTN0C6L3+O7Z/jpfgaWYX1tKiFjwQnyaWC5 j7pi1BICP3fFklPZK8s0xXFvV5/dZcbyLk+aN64NMIrB3b/oyBLwUTE7mFVL4Zrv4it6 eNHMjsPCl9TXpNw5X569ctkB6m4RT7OkHM2istsClrNBKt6SbEadVe8z80/1KGf9YNdo OncGdZ+IUc+0vz5kxy28gYsDLx5zupL4VHpp7zoP5Y+VWnVraIeO1vAXbyEdyiZYDEnN bgww== X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of mst@redhat.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=mst@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com X-Gm-Message-State: APjAAAXLu232ZF2KzzXCgTkHcQ/I9XvWWP3qpl24S5PnyE+G62WX3/uU QWqE1dmeymPUwNRPtjKHuBVTTbtxNI8t+7VNXeYJuVJo/swSCh3vi6NDaGOMauqvqJ6JNibJIKA 9/g5z8XGTyRm73+gCk52RIxOOpllIgQ0K8KiOAIudLejGRymIfJMUNfgLMGkHYIjHTg== X-Received: by 2002:adf:cf02:: with SMTP id o2mr60023908wrj.352.1563866719115; Tue, 23 Jul 2019 00:25:19 -0700 (PDT) X-Received: by 2002:adf:cf02:: with SMTP id o2mr60023703wrj.352.1563866717854; Tue, 23 Jul 2019 00:25:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1563866717; cv=none; d=google.com; s=arc-20160816; b=wk1KxvE8+zOWvG8dKqFhCvEjGBf/QgWjF0b0yAg+x2S44fzdpsFtToVKrVgRpKQFFZ xXM1982rQeDl4w+MF9R8hIXMv8RG0CVqrxG/WUNIyvZM5kVP510OrOhz5DD7U5tT7WfW 4YMWpHXKee5+Y0zRiH2E1CZ6lJiQZqc5PiWfDgj0WcuxlmqCNyfXxImEi+96gbMF0BOB jkOoHE9ouoRtD/6HMk0KAY/UgM7ExqDJLX7Z6dw7En+WbsgumjRChx/s9M2svNJQXMLW ZzZs3k5Y+ueP3TOZjvzY1ZO1xhUpVJg75sikfhwy3zpITDW7ZBd3qKzWshdsPsrRmaWX 8wYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=sHDKTXWU/xgPgNMn/V0t0D27DplpYbCWQ39JljnO3KE=; b=M6CMoszTq1ufkU63V/8JhjJ/dByywkR1VMeszSWnOwsGTFU808MY5WjnUwuafsskoy pIfpQTCExEQ9+0u+2rHJEmeQUvVe/ExIrxEYzt5Wn/8vzGjuF8U0vUuBFzzwr6M1yJGi akXbwuBSXcBCR9ewfFeLfOc3vMNEdDbNkxljdK8GfIzNs7D0piRNonkMdlvbVOGTX1iZ EBDTlHtQZHLaxPAOawA3DMrWnGOoIg3k67VY20zBPr9DGWXzTCQmWjODIJbEl5tsZXxJ Toal4Zl2JALcyiaASwUSRHry2p12ihFFRYhfMjI5l0ExO3MbXt0SYZGfehazvTW71fcw w9tQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of mst@redhat.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=mst@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id m9sor33142449wru.1.2019.07.23.00.25.17 for (Google Transport Security); Tue, 23 Jul 2019 00:25:17 -0700 (PDT) Received-SPF: pass (google.com: domain of mst@redhat.com designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; Authentication-Results: mx.google.com; spf=pass (google.com: domain of mst@redhat.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=mst@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com X-Google-Smtp-Source: APXvYqz0SPP0qiQDLODbbW9L0gpUYgqPP98ti5rIHlXdUIG862jf2lYb199jfwAb8HW5mBizFMj7ug== X-Received: by 2002:adf:dd03:: with SMTP id a3mr33103542wrm.87.1563866717486; Tue, 23 Jul 2019 00:25:17 -0700 (PDT) Received: from redhat.com ([185.120.125.30]) by smtp.gmail.com with ESMTPSA id o7sm36354317wmf.43.2019.07.23.00.25.13 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 23 Jul 2019 00:25:16 -0700 (PDT) Date: Tue, 23 Jul 2019 03:25:11 -0400 From: "Michael S. Tsirkin" To: Jason Wang Cc: syzbot , aarcange@redhat.com, akpm@linux-foundation.org, christian@brauner.io, davem@davemloft.net, ebiederm@xmission.com, elena.reshetova@intel.com, guro@fb.com, hch@infradead.org, james.bottomley@hansenpartnership.com, jglisse@redhat.com, keescook@chromium.org, ldv@altlinux.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-parisc@vger.kernel.org, luto@amacapital.net, mhocko@suse.com, mingo@kernel.org, namit@vmware.com, peterz@infradead.org, syzkaller-bugs@googlegroups.com, viro@zeniv.linux.org.uk, wad@chromium.org Subject: Re: WARNING in __mmdrop Message-ID: <20190723032346-mutt-send-email-mst@kernel.org> References: <0000000000008dd6bb058e006938@google.com> <000000000000964b0d058e1a0483@google.com> <20190721044615-mutt-send-email-mst@kernel.org> <75c43998-3a1c-676f-99ff-3d04663c3fcc@redhat.com> <20190722035657-mutt-send-email-mst@kernel.org> <20190723010156-mutt-send-email-mst@kernel.org> <124be1a2-1c53-8e65-0f06-ee2294710822@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <124be1a2-1c53-8e65-0f06-ee2294710822@redhat.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jul 23, 2019 at 01:48:52PM +0800, Jason Wang wrote: > > On 2019/7/23 下午1:02, Michael S. Tsirkin wrote: > > On Tue, Jul 23, 2019 at 11:55:28AM +0800, Jason Wang wrote: > > > On 2019/7/22 下午4:02, Michael S. Tsirkin wrote: > > > > On Mon, Jul 22, 2019 at 01:21:59PM +0800, Jason Wang wrote: > > > > > On 2019/7/21 下午6:02, Michael S. Tsirkin wrote: > > > > > > On Sat, Jul 20, 2019 at 03:08:00AM -0700, syzbot wrote: > > > > > > > syzbot has bisected this bug to: > > > > > > > > > > > > > > commit 7f466032dc9e5a61217f22ea34b2df932786bbfc > > > > > > > Author: Jason Wang > > > > > > > Date: Fri May 24 08:12:18 2019 +0000 > > > > > > > > > > > > > > vhost: access vq metadata through kernel virtual address > > > > > > > > > > > > > > bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=149a8a20600000 > > > > > > > start commit: 6d21a41b Add linux-next specific files for 20190718 > > > > > > > git tree: linux-next > > > > > > > final crash: https://syzkaller.appspot.com/x/report.txt?x=169a8a20600000 > > > > > > > console output: https://syzkaller.appspot.com/x/log.txt?x=129a8a20600000 > > > > > > > kernel config: https://syzkaller.appspot.com/x/.config?x=3430a151e1452331 > > > > > > > dashboard link: https://syzkaller.appspot.com/bug?extid=e58112d71f77113ddb7b > > > > > > > syz repro: https://syzkaller.appspot.com/x/repro.syz?x=10139e68600000 > > > > > > > > > > > > > > Reported-by: syzbot+e58112d71f77113ddb7b@syzkaller.appspotmail.com > > > > > > > Fixes: 7f466032dc9e ("vhost: access vq metadata through kernel virtual > > > > > > > address") > > > > > > > > > > > > > > For information about bisection process see: https://goo.gl/tpsmEJ#bisection > > > > > > OK I poked at this for a bit, I see several things that > > > > > > we need to fix, though I'm not yet sure it's the reason for > > > > > > the failures: > > > > > > > > > > > > > > > > > > 1. mmu_notifier_register shouldn't be called from vhost_vring_set_num_addr > > > > > > That's just a bad hack, > > > > > This is used to avoid holding lock when checking whether the addresses are > > > > > overlapped. Otherwise we need to take spinlock for each invalidation request > > > > > even if it was the va range that is not interested for us. This will be very > > > > > slow e.g during guest boot. > > > > KVM seems to do exactly that. > > > > I tried and guest does not seem to boot any slower. > > > > Do you observe any slowdown? > > > > > > Yes I do. > > > > > > > > > > Now I took a hard look at the uaddr hackery it really makes > > > > me nervious. So I think for this release we want something > > > > safe, and optimizations on top. As an alternative revert the > > > > optimization and try again for next merge window. > > > > > > Will post a series of fixes, let me know if you're ok with that. > > > > > > Thanks > > I'd prefer you to take a hard look at the patch I posted > > which makes code cleaner, > > > I did. But it looks to me a series that is only about 60 lines of code can > fix all the issues we found without reverting the uaddr optimization. > > > > and ad optimizations on top. > > But other ways could be ok too. > > > I'm waiting for the test result from syzbot and will post. Let's see if you > are OK with that. > > Thanks Oh I didn't know one can push a test to syzbot and get back a result. How does one do that? > > > > >