From: Dennis Zhou <dennis@kernel.org>
To: sathyanarayanan kuppuswamy <sathyanarayanan.kuppuswamy@linux.intel.com>
Cc: Dave Hansen <dave.hansen@intel.com>,
Uladzislau Rezki <urezki@gmail.com>,
akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/1] mm/vmalloc.c: Fix percpu free VM area search criteria
Date: Tue, 30 Jul 2019 17:55:35 -0400 [thread overview]
Message-ID: <20190730215535.GA67664@dennisz-mbp.dhcp.thefacebook.com> (raw)
In-Reply-To: <9fdd44c2-a10e-23f0-a71c-bf8f3e6fc384@linux.intel.com>
On Tue, Jul 30, 2019 at 02:13:25PM -0700, sathyanarayanan kuppuswamy wrote:
>
> On 7/30/19 1:54 PM, Dave Hansen wrote:
> > On 7/30/19 1:46 PM, Uladzislau Rezki wrote:
> > > > + /*
> > > > + * If required width exeeds current VA block, move
> > > > + * base downwards and then recheck.
> > > > + */
> > > > + if (base + end > va->va_end) {
> > > > + base = pvm_determine_end_from_reverse(&va, align) - end;
> > > > + term_area = area;
> > > > + continue;
> > > > + }
> > > > +
> > > > /*
> > > > * If this VA does not fit, move base downwards and recheck.
> > > > */
> > > > - if (base + start < va->va_start || base + end > va->va_end) {
> > > > + if (base + start < va->va_start) {
> > > > va = node_to_va(rb_prev(&va->rb_node));
> > > > base = pvm_determine_end_from_reverse(&va, align) - end;
> > > > term_area = area;
> > > > --
> > > > 2.21.0
> > > >
> > > I guess it is NUMA related issue, i mean when we have several
> > > areas/sizes/offsets. Is that correct?
> > I don't think NUMA has anything to do with it. The vmalloc() area
> > itself doesn't have any NUMA properties I can think of. We don't, for
> > instance, partition it into per-node areas that I know of.
> >
> > I did encounter this issue on a system with ~100 logical CPUs, which is
> > a moderate amount these days.
>
> I agree with Dave. I don't think this issue is related to NUMA. The problem
> here is about the logic we use to find appropriate vm_area that satisfies
> the offset and size requirements of pcpu memory allocator.
>
> In my test case, I can reproduce this issue if we make request with offset
> (ffff000000) and size (600000).
>
> >
> --
> Sathyanarayanan Kuppuswamy
> Linux kernel developer
>
I misspoke earlier. I don't think it's numa related either, but I think
you could trigger this much more easily this way as it could skip more
viable vma space because it'd have to find more holes.
But it seems that pvm_determine_end_from_reverse() will return the free
vma below the address if it is aligned so:
base + end > va->va_end
will always be true and then push down the searching va instead of using
that va first.
Thanks,
Dennis
next prev parent reply other threads:[~2019-07-30 21:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-29 23:21 [PATCH v1 1/1] mm/vmalloc.c: Fix percpu free VM area search criteria sathyanarayanan.kuppuswamy
2019-07-30 20:46 ` Uladzislau Rezki
2019-07-30 20:54 ` Dave Hansen
2019-07-30 21:09 ` Dennis Zhou
2019-07-30 21:13 ` sathyanarayanan kuppuswamy
2019-07-30 21:55 ` Dennis Zhou [this message]
2019-07-30 22:25 ` sathyanarayanan kuppuswamy
2019-07-30 22:34 ` Uladzislau Rezki
2019-07-30 22:37 ` sathyanarayanan kuppuswamy
2019-07-31 12:04 ` Uladzislau Rezki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190730215535.GA67664@dennisz-mbp.dhcp.thefacebook.com \
--to=dennis@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=dave.hansen@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=urezki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).