From: Mel Gorman <mgorman@techsingularity.net>
To: Christoph Hellwig <hch@infradead.org>
Cc: Dave Chinner <david@fromorbit.com>,
Michal Hocko <mhocko@kernel.org>,
linux-mm@kvack.org, linux-xfs@vger.kernel.org,
Vlastimil Babka <vbabka@suse.cz>
Subject: Re: [PATCH] [Regression, v5.0] mm: boosted kswapd reclaim b0rks system cache balance
Date: Thu, 8 Aug 2019 18:04:37 +0100 [thread overview]
Message-ID: <20190808170437.GL2739@techsingularity.net> (raw)
In-Reply-To: <20190808153658.GA26893@infradead.org>
On Thu, Aug 08, 2019 at 08:36:58AM -0700, Christoph Hellwig wrote:
> > - if (sc->may_shrinkslab) {
> > - shrink_slab(sc->gfp_mask, pgdat->node_id,
> > - memcg, sc->priority);
> > - }
> > + shrink_slab(sc->gfp_mask, pgdat->node_id,
> > + memcg, sc->priority);
>
> Not the most useful comment, but the indentation for the continuing line
> is weird (already in the original code). This should be something like:
>
> shrink_slab(sc->gfp_mask, pgdat->node_id, memcg,
> sc->priority);
If that's the worst you found then I take it as good news. I have not
sent a version with an updated changelog so I can fix it up.
--
Mel Gorman
SUSE Labs
next prev parent reply other threads:[~2019-08-08 17:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-07 9:18 [PATCH] [Regression, v5.0] mm: boosted kswapd reclaim b0rks system cache balance Dave Chinner
2019-08-07 9:30 ` Michal Hocko
2019-08-07 15:03 ` Mel Gorman
2019-08-07 20:56 ` Mel Gorman
2019-08-07 22:32 ` Dave Chinner
2019-08-07 23:48 ` Mel Gorman
2019-08-08 0:26 ` Dave Chinner
2019-08-08 15:36 ` Christoph Hellwig
2019-08-08 17:04 ` Mel Gorman [this message]
2019-08-07 22:08 ` Dave Chinner
2019-08-07 22:33 ` Dave Chinner
2019-08-07 23:55 ` Mel Gorman
2019-08-08 0:30 ` Dave Chinner
2019-08-08 5:51 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190808170437.GL2739@techsingularity.net \
--to=mgorman@techsingularity.net \
--cc=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=mhocko@kernel.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).