From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A14FC0650F for ; Sun, 11 Aug 2019 18:46:27 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 38661204EC for ; Sun, 11 Aug 2019 18:46:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DAUesqdC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 38661204EC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9F6E46B0003; Sun, 11 Aug 2019 14:46:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9A5286B0005; Sun, 11 Aug 2019 14:46:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8BB3E6B0006; Sun, 11 Aug 2019 14:46:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0138.hostedemail.com [216.40.44.138]) by kanga.kvack.org (Postfix) with ESMTP id 68DBD6B0003 for ; Sun, 11 Aug 2019 14:46:26 -0400 (EDT) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with SMTP id 08312180AD7C1 for ; Sun, 11 Aug 2019 18:46:26 +0000 (UTC) X-FDA: 75811027572.15.swing66_1b017c15e644c X-HE-Tag: swing66_1b017c15e644c X-Filterd-Recvd-Size: 4401 Received: from mail-lj1-f193.google.com (mail-lj1-f193.google.com [209.85.208.193]) by imf11.hostedemail.com (Postfix) with ESMTP for ; Sun, 11 Aug 2019 18:46:25 +0000 (UTC) Received: by mail-lj1-f193.google.com with SMTP id t3so7903901ljj.12 for ; Sun, 11 Aug 2019 11:46:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=G0DOFHA8eVoNDoQdcja02y/muQPflx5tBcQTBpoDNTE=; b=DAUesqdCL/UDY5CBh48z8ZaXw12W2P3pXntHhwx0odgZ90g6ku9enum8kXMj7Jl801 6xIuICl2jKUK2CGqqzqvsRbGp+woveSHR3StSkXSDyDHQCIzVSzV8tHX6r0x6QDuFA0p Tl5Ah3Ss0AWssXrSPISLfUk9BBDGMPA3wAT7nOMeIgs58B/zPC20CleNlmJhCXn7wgVJ DrFos1G+JBSvRaUHW9/cc5JiRZM39+vJ3ZMX0w0oygqknabbOEtTYE9TabDNyOWfSEqR JCfZeImwzo+h/mwkX6uyWEJOlm6djgasegJGuUyydgrRvAcSA/GK/NLut58O+o10DMt6 0Iqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=G0DOFHA8eVoNDoQdcja02y/muQPflx5tBcQTBpoDNTE=; b=gXhrAFmyRTFxL5q/33xMwmnlHrib/C3/zZYs7T1yw0wsVs3Z3hsYxcMbHsG3bBd+o8 pzNRyQKNhk9lXijL4DmfMmSpCsWGsPWvg9p5XO3jShA3udtgYHjN83pUG7PPLa2nmCmg 8j3eOZJMZTeqJzWSgv36d+p/JZobDcErAYBjVIfBzWfGhJYyiFOS/nHScjde9y8MeGV7 4HvLOo0QX55hdVYv5fyu6H4UNzTdbDmsNEqS7WGxKBYJTLqPau7taqPD97RpdeRt+TA+ bkmo/vnglOnNv5OuN++ovlFQyWeHwiM2DSXB+kxLuDGJWkh65YNelhnGL5LykTAgHC/G /PFg== X-Gm-Message-State: APjAAAUY3vyBuRGCi1T12pm8YcSMqQPcdYb3gpmrNJmtWHgR/MPrprDq EhKiziE/+Z5NTvZ9nQFbV2s= X-Google-Smtp-Source: APXvYqyOYshbyWaswvLHHrzMXwMcaMRcuzVh2HZZb8c59GFe9C/ObyM7Ivv5RE7+z4NEjvweWWKjmw== X-Received: by 2002:a2e:9889:: with SMTP id b9mr7541875ljj.230.1565549183913; Sun, 11 Aug 2019 11:46:23 -0700 (PDT) Received: from localhost.localdomain ([37.212.199.11]) by smtp.gmail.com with ESMTPSA id t66sm1536425lje.66.2019.08.11.11.46.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 11 Aug 2019 11:46:23 -0700 (PDT) From: "Uladzislau Rezki (Sony)" To: Andrew Morton , Michel Lespinasse Cc: linux-mm@kvack.org, LKML , Peter Zijlstra , Roman Gushchin , Uladzislau Rezki , Hillf Danton , Michal Hocko , Matthew Wilcox , Oleksiy Avramchenko , Steven Rostedt Subject: [PATCH 0/2] some cleanups related to RB_DECLARE_CALLBACKS_MAX Date: Sun, 11 Aug 2019 20:46:11 +0200 Message-Id: <20190811184613.20463-1-urezki@gmail.com> X-Mailer: git-send-email 2.11.0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Recently we have got RB_DECLARE_CALLBACKS_MAX template that is supposed to be used in case of having an augmented value as scalar value. First patch just simplifies the *_compute_max() callback by using max3() macro that makes the code more transparent, i think. No functional changes. Second patch reuses RB_DECLARE_CALLBACKS_MAX template's internal functionality, that is generated to manage augment red-black tree instead of using our own and the same logic in vmalloc. Just get rid of duplication. No functional changes. Also i have open question related to validating of the augment tree, i mean in case of debugging to check that nodes are maintained correctly. Please have a look here: https://lkml.org/lkml/2019/7/29/304 Basically we can add one more function under RB_DECLARE_CALLBACKS_MAX template making it public that checks a tree and its augmented nodes. At least i see two users where it can be used: vmalloc and lib/rbtree_test.c. Appreciate for any comments. Uladzislau Rezki (Sony) (2): augmented rbtree: use max3() in the *_compute_max() function mm/vmalloc: use generated callback to populate subtree_max_size include/linux/rbtree_augmented.h | 40 +++++++++++++++++----------------- mm/vmalloc.c | 31 +------------------------- tools/include/linux/rbtree_augmented.h | 40 +++++++++++++++++----------------- 3 files changed, 41 insertions(+), 70 deletions(-) -- 2.11.0