From: Johannes Weiner <hannes@cmpxchg.org>
To: Song Liu <songliubraving@fb.com>
Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, matthew.wilcox@oracle.com,
kirill.shutemov@linux.intel.com, kernel-team@fb.com,
william.kucharski@oracle.com, akpm@linux-foundation.org,
hdanton@sina.com
Subject: Re: [PATCH v10 2/7] filemap: check compound_head(page)->mapping in pagecache_get_page()
Date: Mon, 12 Aug 2019 16:33:04 -0400 [thread overview]
Message-ID: <20190812203304.GA15498@cmpxchg.org> (raw)
In-Reply-To: <20190801184244.3169074-3-songliubraving@fb.com>
On Thu, Aug 01, 2019 at 11:42:39AM -0700, Song Liu wrote:
> Similar to previous patch, pagecache_get_page() avoids race condition
> with truncate by checking page->mapping == mapping. This does not work
> for compound pages. This patch let it check compound_head(page)->mapping
> instead.
>
> Suggested-by: Johannes Weiner <hannes@cmpxchg.org>
> Signed-off-by: Song Liu <songliubraving@fb.com>
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
next prev parent reply other threads:[~2019-08-12 20:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-01 18:42 [PATCH v10 0/7] Enable THP for text section of non-shmem files Song Liu
2019-08-01 18:42 ` [PATCH v10 1/7] filemap: check compound_head(page)->mapping in filemap_fault() Song Liu
2019-08-01 18:42 ` [PATCH v10 2/7] filemap: check compound_head(page)->mapping in pagecache_get_page() Song Liu
2019-08-12 20:33 ` Johannes Weiner [this message]
2019-08-01 18:42 ` [PATCH v10 3/7] filemap: update offset check in filemap_fault() Song Liu
2019-08-01 18:42 ` [PATCH v10 4/7] mm,thp: stats for file backed THP Song Liu
2019-08-01 18:42 ` [PATCH v10 5/7] khugepaged: rename collapse_shmem() and khugepaged_scan_shmem() Song Liu
2019-08-01 18:42 ` [PATCH v10 6/7] mm,thp: add read-only THP support for (non-shmem) FS Song Liu
2019-08-12 20:36 ` Johannes Weiner
2019-08-01 18:42 ` [PATCH v10 7/7] mm,thp: avoid writes to file with THP in pagecache Song Liu
2019-08-12 20:38 ` Johannes Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190812203304.GA15498@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=akpm@linux-foundation.org \
--cc=hdanton@sina.com \
--cc=kernel-team@fb.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=matthew.wilcox@oracle.com \
--cc=songliubraving@fb.com \
--cc=william.kucharski@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).