Re: [rgushchin:fix_vmstats 210/221] arch/microblaze/include/asm/pgalloc.h:63:7: error: implicit declaration of function 'pgtable_page_ctor'; did you mean 'pgtable_pmd_page_ctor'?

From: Mike Rapoport <rppt@linux.ibm.com>
To: Mark Rutland <mark.rutland@arm.com>
Cc: kbuild test robot <lkp@intel.com>,
	kbuild-all@01.org, Roman Gushchin <guro@fb.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linux Memory Management List <linux-mm@kvack.org>
Subject: Re: [rgushchin:fix_vmstats 210/221] arch/microblaze/include/asm/pgalloc.h:63:7: error: implicit declaration of function 'pgtable_page_ctor'; did you mean 'pgtable_pmd_page_ctor'?
Date: Tue, 13 Aug 2019 13:06:13 +0300	[thread overview]
Message-ID: <20190813100612.GA19524@rapoport-lnx> (raw)
In-Reply-To: <20190813095312.GB866@lakrids.cambridge.arm.com>

On Tue, Aug 13, 2019 at 10:53:12AM +0100, Mark Rutland wrote:
> On Tue, Aug 13, 2019 at 12:38:50PM +0800, kbuild test robot wrote:
> > tree:   https://github.com/rgushchin/linux.git fix_vmstats
> > head:   4ec858b5201ae067607e82706b36588631c1b990
> > commit: 8abab7c3016f03edee681cd2a8231c0a4f567ec9 [210/221] mm: treewide: clarify pgtable_page_{ctor,dtor}() naming
> > config: microblaze-mmu_defconfig (attached as .config)
> > compiler: microblaze-linux-gcc (GCC) 7.4.0
> > reproduce:
> >         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> >         chmod +x ~/bin/make.cross
> >         git checkout 8abab7c3016f03edee681cd2a8231c0a4f567ec9
> >         # save the attached .config to linux build tree
> >         GCC_VERSION=7.4.0 make.cross ARCH=microblaze 
> > 
> > If you fix the issue, kindly add following tag
> > Reported-by: kbuild test robot <lkp@intel.com>
> > 
> > All errors (new ones prefixed by >>):
> > 
> >    In file included from arch/microblaze/kernel/process.c:21:0:
> >    arch/microblaze/include/asm/pgalloc.h: In function 'pte_alloc_one':
> > >> arch/microblaze/include/asm/pgalloc.h:63:7: error: implicit declaration of function 'pgtable_page_ctor'; did you mean 'pgtable_pmd_page_ctor'? [-Werror=implicit-function-declaration]
> >      if (!pgtable_page_ctor(ptepage)) {
> >           ^~~~~~~~~~~~~~~~~
> >           pgtable_pmd_page_ctor
> >    cc1: some warnings being treated as errors
> 
> This was correctly changed to pgtable_pte_page_ctor()  in patch I posted
> [1], and the version in today's linux-next (next-20190813), so AFAICT a
> hunk went missing when it was applied to this tree.

There is a conflict between your patch and the removal of quicklist for pte
allocations for microblaze. I'm sending a "fix" in a short while.

> Dodgy rebase?
> 
> Thanks,
> Mark.
> 
> > 
> > vim +63 arch/microblaze/include/asm/pgalloc.h
> > 
> > 1f84e1ea0e87ad Michal Simek       2009-05-26  59  
> > 1f84e1ea0e87ad Michal Simek       2009-05-26  60  	ptepage = alloc_pages(flags, 0);
> > 8abe73465660f1 Kirill A. Shutemov 2013-11-14  61  	if (!ptepage)
> > 8abe73465660f1 Kirill A. Shutemov 2013-11-14  62  		return NULL;
> > 8abe73465660f1 Kirill A. Shutemov 2013-11-14 @63  	if (!pgtable_page_ctor(ptepage)) {
> > 8abe73465660f1 Kirill A. Shutemov 2013-11-14  64  		__free_page(ptepage);
> > 8abe73465660f1 Kirill A. Shutemov 2013-11-14  65  		return NULL;
> > 8abe73465660f1 Kirill A. Shutemov 2013-11-14  66  	}
> > 1f84e1ea0e87ad Michal Simek       2009-05-26  67  	return ptepage;
> > 1f84e1ea0e87ad Michal Simek       2009-05-26  68  }
> > 1f84e1ea0e87ad Michal Simek       2009-05-26  69  
> > 
> > :::::: The code at line 63 was first introduced by commit
> > :::::: 8abe73465660f12dee03871f681175f4dae62e7f microblaze: add missing pgtable_page_ctor/dtor calls
> > 
> > :::::: TO: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> > :::::: CC: Linus Torvalds <torvalds@linux-foundation.org>
> > 
> > ---
> > 0-DAY kernel test infrastructure                Open Source Technology Center
> > https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
> 
> 

-- 
Sincerely yours,
Mike.