From: Wei Yang <richard.weiyang@gmail.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: Wei Yang <richardw.yang@linux.intel.com>,
akpm@linux-foundation.org, osalvador@suse.de, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/hotplug: prevent memory leak when reuse pgdat
Date: Tue, 13 Aug 2019 13:13:12 +0000 [thread overview]
Message-ID: <20190813131312.l4pzy7ornmc4a5yj@master> (raw)
In-Reply-To: <20190813075707.GA17933@dhcp22.suse.cz>
On Tue, Aug 13, 2019 at 09:57:07AM +0200, Michal Hocko wrote:
>On Tue 13-08-19 10:06:08, Wei Yang wrote:
>> When offline a node in try_offline_node, pgdat is not released. So that
>> pgdat could be reused in hotadd_new_pgdat. While we re-allocate
>> pgdat->per_cpu_nodestats if this pgdat is reused.
>>
>> This patch prevents the memory leak by just allocate per_cpu_nodestats
>> when it is a new pgdat.
>
>Yes this makes sense! I was slightly confused why we haven't initialized
>the allocated pcp area because __alloc_percpu does GFP_KERNEL without
>__GFP_ZERO but then I've just found out that the zeroying is done
>regardless. A bit unexpected...
>
>> NOTE: This is not tested since I didn't manage to create a case to
>> offline a whole node. If my analysis is not correct, please let me know.
>>
>> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
>
>Acked-by: Michal Hocko <mhocko@suse.com>
>
>Thanks!
>
Thanks :-)
>> ---
>> mm/memory_hotplug.c | 10 +++++++++-
>> 1 file changed, 9 insertions(+), 1 deletion(-)
>>
>> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
>> index c73f09913165..efaf9e6f580a 100644
>> --- a/mm/memory_hotplug.c
>> +++ b/mm/memory_hotplug.c
>> @@ -933,8 +933,11 @@ static pg_data_t __ref *hotadd_new_pgdat(int nid, u64 start)
>> if (!pgdat)
>> return NULL;
>>
>> + pgdat->per_cpu_nodestats =
>> + alloc_percpu(struct per_cpu_nodestat);
>> arch_refresh_nodedata(nid, pgdat);
>> } else {
>> + int cpu;
>> /*
>> * Reset the nr_zones, order and classzone_idx before reuse.
>> * Note that kswapd will init kswapd_classzone_idx properly
>> @@ -943,6 +946,12 @@ static pg_data_t __ref *hotadd_new_pgdat(int nid, u64 start)
>> pgdat->nr_zones = 0;
>> pgdat->kswapd_order = 0;
>> pgdat->kswapd_classzone_idx = 0;
>> + for_each_online_cpu(cpu) {
>> + struct per_cpu_nodestat *p;
>> +
>> + p = per_cpu_ptr(pgdat->per_cpu_nodestats, cpu);
>> + memset(p, 0, sizeof(*p));
>> + }
>> }
>>
>> /* we can use NODE_DATA(nid) from here */
>> @@ -952,7 +961,6 @@ static pg_data_t __ref *hotadd_new_pgdat(int nid, u64 start)
>>
>> /* init node's zones as empty zones, we don't have any present pages.*/
>> free_area_init_core_hotplug(nid);
>> - pgdat->per_cpu_nodestats = alloc_percpu(struct per_cpu_nodestat);
>>
>> /*
>> * The node we allocated has no zone fallback lists. For avoiding
>> --
>> 2.17.1
>>
>
>--
>Michal Hocko
>SUSE Labs
--
Wei Yang
Help you, Help me
prev parent reply other threads:[~2019-08-13 13:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-13 2:06 [PATCH] mm/hotplug: prevent memory leak when reuse pgdat Wei Yang
2019-08-13 7:57 ` Michal Hocko
2019-08-13 13:13 ` Wei Yang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190813131312.l4pzy7ornmc4a5yj@master \
--to=richard.weiyang@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=osalvador@suse.de \
--cc=richardw.yang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).