From: Michal Hocko <mhocko@kernel.org>
To: Roman Gushchin <guro@fb.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, Johannes Weiner <hannes@cmpxchg.org>,
linux-kernel@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH] mm: memcontrol: flush percpu vmevents before releasing memcg
Date: Wed, 14 Aug 2019 13:33:10 +0200 [thread overview]
Message-ID: <20190814113310.GW17933@dhcp22.suse.cz> (raw)
In-Reply-To: <20190812233754.2570543-1-guro@fb.com>
On Mon 12-08-19 16:37:54, Roman Gushchin wrote:
> Similar to vmstats, percpu caching of local vmevents leads to an
> accumulation of errors on non-leaf levels. This happens because
> some leftovers may remain in percpu caches, so that they are
> never propagated up by the cgroup tree and just disappear into
> nonexistence with on releasing of the memory cgroup.
>
> To fix this issue let's accumulate and propagate percpu vmevents
> values before releasing the memory cgroup similar to what we're
> doing with vmstats.
>
> Since on cpu hotplug we do flush percpu vmstats anyway, we can
> iterate only over online cpus.
>
> Fixes: 42a300353577 ("mm: memcontrol: fix recursive statistics correctness & scalabilty")
> Signed-off-by: Roman Gushchin <guro@fb.com>
> Cc: Johannes Weiner <hannes@cmpxchg.org>
Acked-by: Michal Hocko <mhocko@suse.com>
> ---
> mm/memcontrol.c | 22 +++++++++++++++++++++-
> 1 file changed, 21 insertions(+), 1 deletion(-)
>
> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> index 6d2427abcc0c..249187907339 100644
> --- a/mm/memcontrol.c
> +++ b/mm/memcontrol.c
> @@ -3459,6 +3459,25 @@ static void memcg_flush_percpu_vmstats(struct mem_cgroup *memcg, bool slab_only)
> }
> }
>
> +static void memcg_flush_percpu_vmevents(struct mem_cgroup *memcg)
> +{
> + unsigned long events[NR_VM_EVENT_ITEMS];
> + struct mem_cgroup *mi;
> + int cpu, i;
> +
> + for (i = 0; i < NR_VM_EVENT_ITEMS; i++)
> + events[i] = 0;
> +
> + for_each_online_cpu(cpu)
> + for (i = 0; i < NR_VM_EVENT_ITEMS; i++)
> + events[i] += raw_cpu_read(
> + memcg->vmstats_percpu->events[i]);
> +
> + for (mi = memcg; mi; mi = parent_mem_cgroup(mi))
> + for (i = 0; i < NR_VM_EVENT_ITEMS; i++)
> + atomic_long_add(events[i], &mi->vmevents[i]);
> +}
> +
> static void memcg_offline_kmem(struct mem_cgroup *memcg)
> {
> struct cgroup_subsys_state *css;
> @@ -4860,10 +4879,11 @@ static void __mem_cgroup_free(struct mem_cgroup *memcg)
> int node;
>
> /*
> - * Flush percpu vmstats to guarantee the value correctness
> + * Flush percpu vmstats and vmevents to guarantee the value correctness
> * on parent's and all ancestor levels.
> */
> memcg_flush_percpu_vmstats(memcg, false);
> + memcg_flush_percpu_vmevents(memcg);
> for_each_node(node)
> free_mem_cgroup_per_node_info(memcg, node);
> free_percpu(memcg->vmstats_percpu);
> --
> 2.21.0
--
Michal Hocko
SUSE Labs
prev parent reply other threads:[~2019-08-14 11:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-12 23:37 [PATCH] mm: memcontrol: flush percpu vmevents before releasing memcg Roman Gushchin
2019-08-13 0:30 ` Roman Gushchin
2019-08-13 21:31 ` Andrew Morton
2019-08-13 21:47 ` Roman Gushchin
2019-08-14 11:33 ` Michal Hocko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190814113310.GW17933@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).