From: kbuild test robot <lkp@intel.com>
To: Mark Salyzyn <salyzyn@android.com>
Cc: kbuild-all@01.org, linux-kernel@vger.kernel.org,
kernel-team@android.com, "Mark Salyzyn" <salyzyn@android.com>,
"Stephen Smalley" <sds@tycho.nsa.gov>,
linux-security-module@vger.kernel.org, stable@vger.kernel.org,
"Gao Xiang" <gaoxiang25@huawei.com>,
"Chao Yu" <yuchao0@huawei.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Eric Van Hensbergen" <ericvh@gmail.com>,
"Latchesar Ionkov" <lucho@ionkov.net>,
"Dominique Martinet" <asmadeus@codewreck.org>,
"David Howells" <dhowells@redhat.com>, "Chris Mason" <clm@fb.com>,
"Josef Bacik" <josef@toxicpanda.com>,
"David Sterba" <dsterba@suse.com>,
"Jeff Layton" <jlayton@kernel.org>, "Sage Weil" <sage@redhat.com>,
"Ilya Dryomov" <idryomov@gmail.com>,
"Steve French" <sfrench@samba.org>,
"Tyler Hicks" <tyhicks@canonical.com>, "Jan Kara" <jack@suse.com>,
"Theodore Ts'o" <tytso@mit.edu>,
"Andreas Dilger" <adilger.kernel@dilger.ca>,
"Jaegeuk Kim" <jaegeuk@kernel.org>,
"Miklos Szeredi" <miklos@szeredi.hu>,
"Bob Peterson" <rpeterso@redhat.com>,
"Andreas Gruenbacher" <agruenba@redhat.com>,
"David Woodhouse" <dwmw2@infradead.org>,
"Richard Weinberger" <richard@nod.at>,
"Dave Kleikamp" <shaggy@kernel.org>, "Tejun Heo" <tj@kernel.org>,
"Trond Myklebust" <trond.myklebust@hammerspace.com>,
"Anna Schumaker" <anna.schumaker@netapp.com>,
"Mark Fasheh" <mark@fasheh.com>,
"Joel Becker" <jlbec@evilplan.org>,
"Joseph Qi" <joseph.qi@linux.alibaba.com>,
"Mike Marshall" <hubcap@omnibond.com>,
"Martin Brandenburg" <martin@omnibond.com>,
"Alexander Viro" <viro@zeniv.linux.org.uk>,
"Phillip Lougher" <phillip@squashfs.org.uk>,
"Artem Bityutskiy" <dedekind1@gmail.com>,
"Adrian Hunter" <adrian.hunter@intel.com>,
"Darrick J. Wong" <darrick.wong@oracle.com>,
linux-xfs@vger.kernel.org, "Hugh Dickins" <hughd@google.com>,
"David S. Miller" <davem@davemloft.net>,
"Serge Hallyn" <serge@hallyn.com>,
"James Morris" <jmorris@namei.org>,
"Mimi Zohar" <zohar@linux.ibm.com>,
"Paul Moore" <paul@paul-moore.com>,
"Eric Paris" <eparis@parisplace.org>,
"Casey Schaufler" <casey@schaufler-ca.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Mathieu Malaterre" <malat@debian.org>,
"Vyacheslav Dubeyko" <slava@dubeyko.com>,
Ernesto =?unknown-8bit?Q?A=2E_Fern=C3=A1ndez?=
<ernesto.mnd.fernandez@gmail.com>,
linux-erofs@lists.ozlabs.org, devel@driverdev.osuosl.org,
v9fs-developer@lists.sourceforge.net,
linux-afs@lists.infradead.org, linux-btrfs@vger.kernel.org,
ceph-devel@vger.kernel.org, linux-cifs@vger.kernel.org,
samba-technical@lists.samba.org, ecryptfs@vger.kernel.org,
linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-fsdevel@vger.kernel.org, cluster-devel@redhat.com,
linux-mtd@lists.infradead.org,
jfs-discussion@lists.sourceforge.net, linux-nfs@vger.kernel.org,
ocfs2-devel@oss.oracle.com, devel@lists.orangefs.org,
linux-unionfs@vger.kernel.org, reiserfs-devel@vger.kernel.org,
linux-mm@kvack.org, netdev@vger.kernel.org,
linux-integrity@vger.kernel.org, selinux@vger.kernel.org
Subject: Re: [PATCH v2] Add flags option to get xattr method paired to __vfs_getxattr
Date: Wed, 14 Aug 2019 13:57:30 +0800 [thread overview]
Message-ID: <201908141340.zUiNVpi0%lkp@intel.com> (raw)
In-Reply-To: <20190813145527.26289-1-salyzyn@android.com>
[-- Attachment #1: Type: text/plain, Size: 7289 bytes --]
Hi Mark,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linus/master]
[cannot apply to v5.3-rc4 next-20190813]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Mark-Salyzyn/Add-flags-option-to-get-xattr-method-paired-to-__vfs_getxattr/20190814-124805
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gcc (GCC) 7.4.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.4.0 make.cross ARCH=sh
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> fs/ubifs/xattr.c:326:9: error: conflicting types for 'ubifs_xattr_get'
ssize_t ubifs_xattr_get(struct inode *host, const char *name, void *buf,
^~~~~~~~~~~~~~~
In file included from fs/ubifs/xattr.c:46:0:
fs/ubifs/ubifs.h:2006:9: note: previous declaration of 'ubifs_xattr_get' was here
ssize_t ubifs_xattr_get(struct inode *host, const char *name, void *buf,
^~~~~~~~~~~~~~~
fs/ubifs/xattr.c: In function 'xattr_get':
>> fs/ubifs/xattr.c:678:9: error: too few arguments to function 'ubifs_xattr_get'
return ubifs_xattr_get(inode, name, buffer, size);
^~~~~~~~~~~~~~~
fs/ubifs/xattr.c:326:9: note: declared here
ssize_t ubifs_xattr_get(struct inode *host, const char *name, void *buf,
^~~~~~~~~~~~~~~
fs/ubifs/xattr.c: At top level:
fs/ubifs/xattr.c:699:9: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
.get = xattr_get,
^~~~~~~~~
fs/ubifs/xattr.c:699:9: note: (near initialization for 'ubifs_user_xattr_handler.get')
fs/ubifs/xattr.c:705:9: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
.get = xattr_get,
^~~~~~~~~
fs/ubifs/xattr.c:705:9: note: (near initialization for 'ubifs_trusted_xattr_handler.get')
fs/ubifs/xattr.c:712:9: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
.get = xattr_get,
^~~~~~~~~
fs/ubifs/xattr.c:712:9: note: (near initialization for 'ubifs_security_xattr_handler.get')
fs/ubifs/xattr.c: In function 'xattr_get':
fs/ubifs/xattr.c:679:1: warning: control reaches end of non-void function [-Wreturn-type]
}
^
cc1: some warnings being treated as errors
vim +/ubifs_xattr_get +326 fs/ubifs/xattr.c
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 325
ade46c3a6029de Richard Weinberger 2016-09-19 @326 ssize_t ubifs_xattr_get(struct inode *host, const char *name, void *buf,
ac76fdcb4aadfd Mark Salyzyn 2019-08-13 327 size_t size, int flags)
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 328 {
ce23e640133484 Al Viro 2016-04-11 329 struct inode *inode;
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 330 struct ubifs_info *c = host->i_sb->s_fs_info;
f4f61d2cc6d878 Richard Weinberger 2016-11-11 331 struct fscrypt_name nm = { .disk_name = FSTR_INIT((char *)name, strlen(name))};
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 332 struct ubifs_inode *ui;
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 333 struct ubifs_dent_node *xent;
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 334 union ubifs_key key;
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 335 int err;
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 336
f4f61d2cc6d878 Richard Weinberger 2016-11-11 337 if (fname_len(&nm) > UBIFS_MAX_NLEN)
2b88fc21cae91e Andreas Gruenbacher 2016-04-22 338 return -ENAMETOOLONG;
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 339
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 340 xent = kmalloc(UBIFS_MAX_XENT_NODE_SZ, GFP_NOFS);
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 341 if (!xent)
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 342 return -ENOMEM;
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 343
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 344 xent_key_init(c, &key, host->i_ino, &nm);
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 345 err = ubifs_tnc_lookup_nm(c, &key, xent, &nm);
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 346 if (err) {
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 347 if (err == -ENOENT)
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 348 err = -ENODATA;
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 349 goto out_unlock;
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 350 }
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 351
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 352 inode = iget_xattr(c, le64_to_cpu(xent->inum));
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 353 if (IS_ERR(inode)) {
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 354 err = PTR_ERR(inode);
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 355 goto out_unlock;
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 356 }
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 357
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 358 ui = ubifs_inode(inode);
6eb61d587f4515 Richard Weinberger 2018-07-12 359 ubifs_assert(c, inode->i_size == ui->data_len);
6eb61d587f4515 Richard Weinberger 2018-07-12 360 ubifs_assert(c, ubifs_inode(host)->xattr_size > ui->data_len);
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 361
ab92a20bce3b4c Dongsheng Yang 2015-08-18 362 mutex_lock(&ui->ui_mutex);
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 363 if (buf) {
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 364 /* If @buf is %NULL we are supposed to return the length */
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 365 if (ui->data_len > size) {
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 366 err = -ERANGE;
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 367 goto out_iput;
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 368 }
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 369
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 370 memcpy(buf, ui->data, ui->data_len);
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 371 }
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 372 err = ui->data_len;
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 373
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 374 out_iput:
ab92a20bce3b4c Dongsheng Yang 2015-08-18 375 mutex_unlock(&ui->ui_mutex);
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 376 iput(inode);
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 377 out_unlock:
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 378 kfree(xent);
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 379 return err;
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 380 }
1e51764a3c2ac0 Artem Bityutskiy 2008-07-14 381
:::::: The code at line 326 was first introduced by commit
:::::: ade46c3a6029dea49dbc6c7734b0f6a78d3f104c ubifs: Export xattr get and set functions
:::::: TO: Richard Weinberger <richard@nod.at>
:::::: CC: Richard Weinberger <richard@nod.at>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 51784 bytes --]
next prev parent reply other threads:[~2019-08-14 5:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-13 14:55 [PATCH v2] Add flags option to get xattr method paired to __vfs_getxattr Mark Salyzyn
2019-08-14 5:57 ` kbuild test robot [this message]
2019-08-14 11:00 ` Jan Kara
2019-08-14 14:54 ` Mark Salyzyn
2019-08-15 15:30 ` Jan Kara
2019-08-14 11:59 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201908141340.zUiNVpi0%lkp@intel.com \
--to=lkp@intel.com \
--cc=adilger.kernel@dilger.ca \
--cc=adrian.hunter@intel.com \
--cc=agruenba@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=anna.schumaker@netapp.com \
--cc=asmadeus@codewreck.org \
--cc=casey@schaufler-ca.com \
--cc=ceph-devel@vger.kernel.org \
--cc=clm@fb.com \
--cc=cluster-devel@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=davem@davemloft.net \
--cc=dedekind1@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=devel@lists.orangefs.org \
--cc=dhowells@redhat.com \
--cc=dsterba@suse.com \
--cc=dwmw2@infradead.org \
--cc=ecryptfs@vger.kernel.org \
--cc=eparis@parisplace.org \
--cc=ericvh@gmail.com \
--cc=ernesto.mnd.fernandez@gmail.com \
--cc=gaoxiang25@huawei.com \
--cc=gregkh@linuxfoundation.org \
--cc=hubcap@omnibond.com \
--cc=hughd@google.com \
--cc=idryomov@gmail.com \
--cc=jack@suse.com \
--cc=jaegeuk@kernel.org \
--cc=jfs-discussion@lists.sourceforge.net \
--cc=jlayton@kernel.org \
--cc=jlbec@evilplan.org \
--cc=jmorris@namei.org \
--cc=josef@toxicpanda.com \
--cc=joseph.qi@linux.alibaba.com \
--cc=kbuild-all@01.org \
--cc=kernel-team@android.com \
--cc=linux-afs@lists.infradead.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=lucho@ionkov.net \
--cc=malat@debian.org \
--cc=mark@fasheh.com \
--cc=martin@omnibond.com \
--cc=miklos@szeredi.hu \
--cc=netdev@vger.kernel.org \
--cc=ocfs2-devel@oss.oracle.com \
--cc=paul@paul-moore.com \
--cc=phillip@squashfs.org.uk \
--cc=reiserfs-devel@vger.kernel.org \
--cc=richard@nod.at \
--cc=rpeterso@redhat.com \
--cc=sage@redhat.com \
--cc=salyzyn@android.com \
--cc=samba-technical@lists.samba.org \
--cc=sds@tycho.nsa.gov \
--cc=selinux@vger.kernel.org \
--cc=serge@hallyn.com \
--cc=sfrench@samba.org \
--cc=shaggy@kernel.org \
--cc=slava@dubeyko.com \
--cc=stable@vger.kernel.org \
--cc=tj@kernel.org \
--cc=trond.myklebust@hammerspace.com \
--cc=tyhicks@canonical.com \
--cc=tytso@mit.edu \
--cc=v9fs-developer@lists.sourceforge.net \
--cc=viro@zeniv.linux.org.uk \
--cc=yuchao0@huawei.com \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).