Linux-mm Archive on lore.kernel.org
 help / color / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "Christoph Hellwig" <hch@lst.de>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Thomas Hellström" <thomas@shipmail.org>,
	"Jerome Glisse" <jglisse@redhat.com>,
	"Jason Gunthorpe" <jgg@mellanox.com>,
	"Steven Price" <steven.price@arm.com>,
	Linux-MM <linux-mm@kvack.org>,
	"Linux List Kernel Mailing" <linux-kernel@vger.kernel.org>
Subject: Re: cleanup the walk_page_range interface
Date: Thu, 15 Aug 2019 23:27:51 -0700
Message-ID: <20190816062751.GA16169@infradead.org> (raw)
In-Reply-To: <CAHk-=wh3jZnD3zaYJpW276WL=N0Vgo4KGW8M2pcFymHthwf0Vg@mail.gmail.com>

On Thu, Aug 08, 2019 at 10:50:37AM -0700, Linus Torvalds wrote:
> On Thu, Aug 8, 2019 at 8:42 AM Christoph Hellwig <hch@lst.de> wrote:
> >
> > this series is based on a patch from Linus to split the callbacks
> > passed to walk_page_range and walk_page_vma into a separate structure
> > that can be marked const, with various cleanups from me on top.
> 
> The whole series looks good to me. Ack.
> 
> > Note that both Thomas and Steven have series touching this area pending,
> > and there are a couple consumer in flux too - the hmm tree already
> > conflicts with this series, and I have potential dma changes on top of
> > the consumers in Thomas and Steven's series, so we'll probably need a
> > git tree similar to the hmm one to synchronize these updates.
> 
> I'd be willing to just merge this now, if that helps. The conversion
> is mechanical, and my only slight worry would be that at least for my
> original patch I didn't build-test the (few) non-x86
> architecture-specific cases. But I did end up looking at them fairly
> closely  (basically using some grep/sed scripts to see that the
> conversions I did matched the same patterns). And your changes look
> like obvious improvements too where any mistake would have been caught
> by the compiler.
> 
> So I'm not all that worried from a functionality standpoint, and if
> this will help the next merge window, I'll happily pull now.

So what is the plan forward?  Probably a little late for 5.3,
so queue it up in -mm for 5.4 and deal with the conflicts in at least
hmm?  Queue it up in the hmm tree even if it doesn't 100% fit?


  parent reply index

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-08 15:42 Christoph Hellwig
2019-08-08 15:42 ` [PATCH 1/3] mm: split out a new pagewalk.h header from mm.h Christoph Hellwig
2019-08-08 15:42 ` [PATCH 2/3] pagewalk: seperate function pointers from iterator data Christoph Hellwig
2019-08-08 20:34   ` Thomas Hellstrom
2019-08-09  8:57   ` Steven Price
2019-08-08 15:42 ` [PATCH 3/3] pagewalk: use lockdep_assert_held for locking validation Christoph Hellwig
2019-08-08 18:18   ` Matthew Wilcox
2019-08-08 17:50 ` cleanup the walk_page_range interface Linus Torvalds
2019-08-08 21:56   ` Christoph Hellwig
2019-08-08 22:21     ` Thomas Hellstrom
2019-08-09 14:36       ` Christoph Hellwig
2019-08-12  6:17     ` Mike Rapoport
2019-08-16  6:27   ` Christoph Hellwig [this message]
2019-08-16 11:57     ` Jason Gunthorpe
2019-08-16 12:32       ` Christoph Hellwig
2019-08-16 16:20         ` Linus Torvalds
2019-08-16 21:06         ` Andrew Morton
2019-08-17  6:41           ` Stephen Rothwell
2019-08-17  6:43             ` Christoph Hellwig
2019-08-17  6:58               ` Stephen Rothwell
2019-08-17  7:37             ` Linus Torvalds
2019-08-23 13:43     ` Jason Gunthorpe
2019-08-23 15:36       ` Steven Price
2019-08-24 22:26       ` Christoph Hellwig
2019-08-27  1:34         ` Jason Gunthorpe
2019-08-27 23:34           ` Andrew Morton
2019-08-27 23:36             ` Jason Gunthorpe
2019-08-28  6:20               ` Christoph Hellwig
2019-08-28 13:23               ` Steven Price

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190816062751.GA16169@infradead.org \
    --to=hch@infradead.org \
    --cc=akpm@linux-foundation.org \
    --cc=hch@lst.de \
    --cc=jgg@mellanox.com \
    --cc=jglisse@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=steven.price@arm.com \
    --cc=thomas@shipmail.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-mm Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-mm/0 linux-mm/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-mm linux-mm/ https://lore.kernel.org/linux-mm \
		linux-mm@kvack.org linux-mm@archiver.kernel.org
	public-inbox-index linux-mm


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kvack.linux-mm


AGPL code for this site: git clone https://public-inbox.org/ public-inbox