From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95381C3A589 for ; Tue, 20 Aug 2019 17:26:34 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 525A222DD3 for ; Tue, 20 Aug 2019 17:26:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="NLMiPJMw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 525A222DD3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A39036B0005; Tue, 20 Aug 2019 13:26:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9E9E46B0006; Tue, 20 Aug 2019 13:26:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 900AB6B0007; Tue, 20 Aug 2019 13:26:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0135.hostedemail.com [216.40.44.135]) by kanga.kvack.org (Postfix) with ESMTP id 6D4DD6B0005 for ; Tue, 20 Aug 2019 13:26:33 -0400 (EDT) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with SMTP id E7D43181AC9C4 for ; Tue, 20 Aug 2019 17:26:32 +0000 (UTC) X-FDA: 75843485424.12.look73_907102d61f31e X-HE-Tag: look73_907102d61f31e X-Filterd-Recvd-Size: 2815 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf37.hostedemail.com (Postfix) with ESMTP for ; Tue, 20 Aug 2019 17:26:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=PeDiA2PJoiVzWMd8z0SSPQVZ1TUnorKfJ5pi4QQ5XHA=; b=NLMiPJMwoo1sgK07WC6S4AT3n BSQEFtSik6WtzPk16YY7ml01GFKIZV13XUbnlKXIIZOrRox6n8FoDRmZ4+pRNV2+XJ3aEYWthRAic SvIoNHa5ZX8UjUNg7osTsC/e9VSPqeInLNYi3cVTGuGuKoUNN66X9aiaPmreE2J0tt8IpvIzEBoDN NtZApH+De7jPQIDaS/XGjsbErclA9QIpbBUuSDl22z/6DhKrzF86czfskWc18jZYi7IYOTpNcEO1u T1G4dvI1Ft4obl2l7Z2WYUKRFKmSiDTMwAimJANn1d2YHqfHmkESiQlNJyknqJrq66WYAHyYrSPdk 0X4MV+EQg==; Received: from willy by bombadil.infradead.org with local (Exim 4.92 #3 (Red Hat Linux)) id 1i07tt-0004yW-EF; Tue, 20 Aug 2019 17:26:29 +0000 Date: Tue, 20 Aug 2019 10:26:29 -0700 From: Matthew Wilcox To: Vlastimil Babka Cc: Wei Yang , Christoph Hellwig , akpm@linux-foundation.org, mgorman@techsingularity.net, osalvador@suse.de, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] mm/mmap.c: extract __vma_unlink_list as counter part for __vma_link_list Message-ID: <20190820172629.GB4949@bombadil.infradead.org> References: <20190814021755.1977-1-richardw.yang@linux.intel.com> <20190814021755.1977-3-richardw.yang@linux.intel.com> <20190814051611.GA1958@infradead.org> <20190814065703.GA6433@richard> <2c5cdffd-f405-23b8-98f5-37b95ca9b027@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2c5cdffd-f405-23b8-98f5-37b95ca9b027@suse.cz> User-Agent: Mutt/1.11.4 (2019-03-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Aug 14, 2019 at 11:19:37AM +0200, Vlastimil Babka wrote: > On 8/14/19 8:57 AM, Wei Yang wrote: > > On Tue, Aug 13, 2019 at 10:16:11PM -0700, Christoph Hellwig wrote: > >>Btw, is there any good reason we don't use a list_head for vma linkage? > > > > Not sure, maybe there is some historical reason? > > Seems it was single-linked until 2010 commit 297c5eee3724 ("mm: make the vma > list be doubly linked") and I guess it was just simpler to add the vm_prev link. > > Conversion to list_head might be an interesting project for some "advanced > beginner" in the kernel :) I'm working to get rid of vm_prev and vm_next, so it would probably be wasted effort.